Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/Generator/Frontend.php

Summary

Maintainability
F
6 days
Test Coverage

Function frontendSelectContent has a Cognitive Complexity of 107 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendSelectContent(
        $Division = null,
        $Person = null,
        $Certificate = null,
        $Content = array(),
Severity: Minor
Found in Application/Education/Certificate/Generator/Frontend.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method frontendSelectContent has 289 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendSelectContent(
        $Division = null,
        $Person = null,
        $Certificate = null,
        $Content = array(),
Severity: Major
Found in Application/Education/Certificate/Generator/Frontend.php - About 1 day to fix

    File Frontend.php has 531 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Education\Certificate\Generator;

use SPHERE\Application\Document\Explorer\Storage\Storage;
use SPHERE\Application\Education\Certificate\Generator\Service\Entity\TblCertificate;
    Severity: Major
    Found in Application/Education/Certificate/Generator/Frontend.php - About 1 day to fix

      Method frontendSelectCertificate has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendSelectCertificate($Division = null, $Person = null)
    {

        $Stage = new Stage('Zeugnisvorlage', 'wählen');
        // Zurück button bei bedarf einbauen
      Severity: Major
      Found in Application/Education/Certificate/Generator/Frontend.php - About 3 hrs to fix

        Function frontendSelectCertificate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendSelectCertificate($Division = null, $Person = null)
    {

        $Stage = new Stage('Zeugnisvorlage', 'wählen');
        // Zurück button bei bedarf einbauen
        Severity: Minor
        Found in Application/Education/Certificate/Generator/Frontend.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method frontendSelectStudent has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendSelectStudent($Division = null)
    {

        $Stage = new Stage('Schüler', 'wählen');
        // Zurück button bei bedarf einbauen
        Severity: Minor
        Found in Application/Education/Certificate/Generator/Frontend.php - About 2 hrs to fix

          Method frontendSelectDivision has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendSelectDivision($SinceYears = 1)
    {

        $Stage = new Stage('Klasse', 'wählen');
        // Zurück button bei bedarf einbauen
          Severity: Minor
          Found in Application/Education/Certificate/Generator/Frontend.php - About 1 hr to fix

            Function frontendSelectStudent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendSelectStudent($Division = null)
    {

        $Stage = new Stage('Schüler', 'wählen');
        // Zurück button bei bedarf einbauen
            Severity: Minor
            Found in Application/Education/Certificate/Generator/Frontend.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method frontendSelectContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $Division = null,
        $Person = null,
        $Certificate = null,
        $Content = array(),
        $SaveAs = null
            Severity: Minor
            Found in Application/Education/Certificate/Generator/Frontend.php - About 35 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                          $FormField = array(
                                'Content.Person.Common.BirthDates.Birthday' => 'DatePicker',

                                'Content.Input.KBE'            => 'TextField',
                                'Content.Input.KFL'            => 'TextField',
              Severity: Major
              Found in Application/Education/Certificate/Generator/Frontend.php and 2 other locations - About 1 hr to fix
              Application/Platform/System/Database/ReportingUpgrade.php on lines 34..57
              Application/Reporting/Standard/Person/Frontend.php on lines 1078..1100

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status