Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/Generator/Service.php

Summary

Maintainability
F
3 days
Test Coverage

Function createCertificateSetting has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public function createCertificateSetting(
        IFormInterface $Form,
        TblCertificate $tblCertificate,
        $GradeList,
        $SubjectList
Severity: Minor
Found in Application/Education/Certificate/Generator/Service.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getReferenceForLanguageByStudent has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function getReferenceForLanguageByStudent(
        TblCertificate $tblCertificate,
        TblStudentSubject $tblStudentSubject,
        TblPerson $tblPerson,
        TblDivision $tblDivision
Severity: Minor
Found in Application/Education/Certificate/Generator/Service.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 361 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Education\Certificate\Generator;

use SPHERE\Application\Education\Certificate\Generator\Service\Data;
use SPHERE\Application\Education\Certificate\Generator\Service\Entity\TblCertificate;
Severity: Minor
Found in Application/Education/Certificate/Generator/Service.php - About 4 hrs to fix

    Service has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Service extends AbstractService
{

    /**
     * @param bool $doSimulation
    Severity: Minor
    Found in Application/Education/Certificate/Generator/Service.php - About 3 hrs to fix

      Method createCertificateSetting has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createCertificateSetting(
        IFormInterface $Form,
        TblCertificate $tblCertificate,
        $GradeList,
        $SubjectList
      Severity: Major
      Found in Application/Education/Certificate/Generator/Service.php - About 2 hrs to fix

        Method getReferenceForLanguageByStudent has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getReferenceForLanguageByStudent(
        TblCertificate $tblCertificate,
        TblStudentSubject $tblStudentSubject,
        TblPerson $tblPerson,
        TblDivision $tblDivision
        Severity: Minor
        Found in Application/Education/Certificate/Generator/Service.php - About 1 hr to fix

          Function updateCertificateType has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateCertificateType(
        IFormInterface $Form,
        $Data
    ) {
          Severity: Minor
          Found in Application/Education/Certificate/Generator/Service.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getFormField()
    {

        return array(
            'Content.Input.Remark'             => 'TextArea',
          Severity: Major
          Found in Application/Education/Certificate/Generator/Service.php and 1 other location - About 1 hr to fix
          Application/Education/Certificate/Generator/Service.php on lines 440..465

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getFormLabel()
    {

        return array(
            'Content.Input.Remark'             => 'Bemerkungen',
          Severity: Major
          Found in Application/Education/Certificate/Generator/Service.php and 1 other location - About 1 hr to fix
          Application/Education/Certificate/Generator/Service.php on lines 410..435

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status