Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/GradeInformation/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

Function frontendSetting has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
Open

    public function frontendSetting($PrepareId = null, $Route = 'Teacher', $Grades = null, $Remarks = null)
    {

        $Stage = new Stage('Noteninformation', 'Klassenübersicht');
Severity: Minor
Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Frontend.php has 668 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 28.09.2016
Severity: Major
Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 1 day to fix

    Method frontendSetting has 153 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendSetting($PrepareId = null, $Route = 'Teacher', $Grades = null, $Remarks = null)
    {

        $Stage = new Stage('Noteninformation', 'Klassenübersicht');
    Severity: Major
    Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 6 hrs to fix

      Method frontendPreview has 116 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendPreview($PrepareId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Klassenübersicht');
      Severity: Major
      Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 4 hrs to fix

        Method frontendShowTemplate has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendShowTemplate($PrepareId = null, $PersonId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Vorschau und Herunterladen');
        $Stage->addButton(new Standard(
        Severity: Major
        Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 3 hrs to fix

          Function frontendShowTemplate has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendShowTemplate($PrepareId = null, $PersonId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Vorschau und Herunterladen');
        $Stage->addButton(new Standard(
          Severity: Minor
          Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method frontendTeacherSelectDivision has 79 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendTeacherSelectDivision($IsAllYears = false, $YearId = null)
    {

        $Stage = new Stage('Noteninformation', 'Klasse auswählen');
          Severity: Major
          Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 3 hrs to fix

            Method frontendGradeInformation has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendGradeInformation($DivisionId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Übersicht');
        $Stage->addButton(new Standard(
            Severity: Major
            Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 2 hrs to fix

              Method frontendHeadmasterSelectDivision has 65 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendHeadmasterSelectDivision($IsAllYears = false, $YearId = null)
    {
        $Stage = new Stage('Noteninformation', 'Klasse auswählen');

        $hasHeadmasterRight = Access::useService()->hasAuthorization('/Education/Certificate/GradeInformation/Headmaster');
              Severity: Major
              Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 2 hrs to fix

                Function frontendTeacherSelectDivision has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendTeacherSelectDivision($IsAllYears = false, $YearId = null)
    {

        $Stage = new Stage('Noteninformation', 'Klasse auswählen');
                Severity: Minor
                Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function frontendHeadmasterSelectDivision has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendHeadmasterSelectDivision($IsAllYears = false, $YearId = null)
    {
        $Stage = new Stage('Noteninformation', 'Klasse auswählen');

        $hasHeadmasterRight = Access::useService()->hasAuthorization('/Education/Certificate/GradeInformation/Headmaster');
                Severity: Minor
                Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function frontendPreview has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendPreview($PrepareId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Klassenübersicht');
                Severity: Minor
                Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                                                    if ($tblPrepareInformation->getField() == 'Remark') {
                                        $Global->POST['Remarks'][$tblPerson->getId()] = $tblPrepareInformation->getValue();
                                    }
                Severity: Major
                Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                  if (!isset($tblGradeTypeList[$tblGradeType->getId()])) {
                                    $tblGradeTypeList[$tblGradeType->getId()] = $tblGradeType;
                                    $columnTable['GradeType' . $tblGradeType->getId()] = $tblGradeType->getName();
                                }
                  Severity: Major
                  Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 45 mins to fix

                    Function frontendGradeInformation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function frontendGradeInformation($DivisionId = null, $Route = 'Teacher')
    {

        $Stage = new Stage('Noteninformation', 'Übersicht');
        $Stage->addButton(new Standard(
                    Severity: Minor
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            $Stage->setContent(
            new Layout(array(
                new LayoutGroup(array(
                    new LayoutRow(array(
                        empty($buttonList)
                    Severity: Major
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php and 1 other location - About 6 hrs to fix
                    Application/Education/Certificate/GradeInformation/Frontend.php on lines 152..180

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 206.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            $Stage->setContent(
            new Layout(array(
                new LayoutGroup(array(
                    new LayoutRow(array(
                        empty($buttonList)
                    Severity: Major
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php and 1 other location - About 6 hrs to fix
                    Application/Education/Certificate/GradeInformation/Frontend.php on lines 235..263

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 206.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (($tblDivisionList = Division::useService()->getDivisionAll())) {
            foreach ($tblDivisionList as $tblDivision) {
                // Bei einem ausgewähltem Schuljahr die anderen Schuljahre ignorieren
                /** @var TblYear $tblYear */
                if ($tblYear && $tblDivision && $tblDivision->getServiceTblYear()
                    Severity: Major
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php and 1 other location - About 2 hrs to fix
                    Application/Education/Certificate/Prepare/Frontend.php on lines 435..461

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 134.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        new LayoutGroup(array(
                        new LayoutRow(array(
                            new LayoutColumn(array(
                                new Panel(
                                    'Noteninformation',
                    Severity: Major
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php and 1 other location - About 2 hrs to fix
                    Application/Education/Certificate/GradeInformation/Frontend.php on lines 757..776

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 123.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        new LayoutGroup(array(
                        new LayoutRow(array(
                            new LayoutColumn(array(
                                new Panel(
                                    'Noteninformation',
                    Severity: Major
                    Found in Application/Education/Certificate/GradeInformation/Frontend.php and 1 other location - About 2 hrs to fix
                    Application/Education/Certificate/GradeInformation/Frontend.php on lines 502..521

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 123.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status