Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/GradeInformation/Service.php

Summary

Maintainability
D
1 day
Test Coverage

Function updatePrepareBehaviorGradesAndRemark has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function updatePrepareBehaviorGradesAndRemark(
        IFormInterface $Stage = null,
        TblPrepareCertificate $tblPrepare,
        $Route = 'Teacher',
        $Grades,
Severity: Minor
Found in Application/Education/Certificate/GradeInformation/Service.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createGradeInformation has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function createGradeInformation(
        IFormInterface $Stage = null,
        TblDivision $tblDivision,
        $Route = 'Teacher',
        $Data
Severity: Minor
Found in Application/Education/Certificate/GradeInformation/Service.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updatePrepareBehaviorGradesAndRemark has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updatePrepareBehaviorGradesAndRemark(
        IFormInterface $Stage = null,
        TblPrepareCertificate $tblPrepare,
        $Route = 'Teacher',
        $Grades,
Severity: Major
Found in Application/Education/Certificate/GradeInformation/Service.php - About 2 hrs to fix

    Method createGradeInformation has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createGradeInformation(
        IFormInterface $Stage = null,
        TblDivision $tblDivision,
        $Route = 'Teacher',
        $Data
    Severity: Major
    Found in Application/Education/Certificate/GradeInformation/Service.php - About 2 hrs to fix

      Method updateGradeInformation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateGradeInformation(
        IFormInterface $Stage = null,
        TblPrepareCertificate $tblPrepare,
        $Route = 'Teacher',
        $Data
      Severity: Minor
      Found in Application/Education/Certificate/GradeInformation/Service.php - About 1 hr to fix

        Method updatePrepareBehaviorGradesAndRemark has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                IFormInterface $Stage = null,
        TblPrepareCertificate $tblPrepare,
        $Route = 'Teacher',
        $Grades,
        $Remarks
        Severity: Minor
        Found in Application/Education/Certificate/GradeInformation/Service.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status