Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/Prepare/Abitur/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 578 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 15.03.2018
Severity: Major
Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 1 day to fix

    Method frontendPrepareDiplomaAbiturPreview has 215 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendPrepareDiplomaAbiturPreview($PrepareId = null, $GroupId = null)
    {

        $stage = new Stage('Zeugnisvorbereitungen', 'Übersicht');
    Severity: Major
    Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 1 day to fix

      Function frontendPrepareDiplomaAbiturPreview has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendPrepareDiplomaAbiturPreview($PrepareId = null, $GroupId = null)
    {

        $stage = new Stage('Zeugnisvorbereitungen', 'Übersicht');
      Severity: Minor
      Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function frontendPrepareDiplomaAbiturOtherInformation has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendPrepareDiplomaAbiturOtherInformation(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $Data = null
      Severity: Minor
      Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method frontendPrepareDiplomaAbiturOtherInformation has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendPrepareDiplomaAbiturOtherInformation(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $Data = null
      Severity: Major
      Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 5 hrs to fix

        Method frontendPrepareDiplomaAbiturBlockI has 118 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendPrepareDiplomaAbiturBlockI(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $View = BlockIView::PREVIEW,
        Severity: Major
        Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 4 hrs to fix

          Function frontendPrepareDiplomaAbiturBlockI has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendPrepareDiplomaAbiturBlockI(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $View = BlockIView::PREVIEW,
          Severity: Minor
          Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method frontendPrepareDiplomaAbiturBlockI has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $View = BlockIView::PREVIEW,
        $Data = null
          Severity: Minor
          Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function frontendPrepareDiplomaAbiturBlockII(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $Data = null
            Severity: Major
            Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php and 1 other location - About 5 hrs to fix
            Application/Education/Certificate/Prepare/Abitur/Frontend.php on lines 502..531

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 191.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function frontendPrepareDiplomaAbiturLevelTen(
        $PrepareId = null,
        $GroupId = null,
        $PersonId = null,
        $Data = null
            Severity: Major
            Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php and 1 other location - About 5 hrs to fix
            Application/Education/Certificate/Prepare/Abitur/Frontend.php on lines 462..491

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 191.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status