Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/Prepare/Abitur/LeavePoints.php

Summary

Maintainability
F
3 days
Test Coverage

Function setSubjectRow has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    private function setSubjectRow($array, $subjectName)
    {

        $course = '';
        $grades = array();
Severity: Minor
Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LeavePoints.php has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 22.05.2018
Severity: Minor
Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 3 hrs to fix

    Function setPrepareStudentList has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private function setPrepareStudentList()
    {
        $prepareStudentList = array();
        // Zensuren von Kurshalbjahreszeugnissen
        if (($tblLeaveStudent = $this->tblLeaveStudent)
    Severity: Minor
    Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setSubjectRow has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function setSubjectRow($array, $subjectName)
    {

        $course = '';
        $grades = array();
    Severity: Major
    Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 2 hrs to fix

      Method setPrepareStudentList has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function setPrepareStudentList()
    {
        $prepareStudentList = array();
        // Zensuren von Kurshalbjahreszeugnissen
        if (($tblLeaveStudent = $this->tblLeaveStudent)
      Severity: Minor
      Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

                                    if (($tblAppointedDateTask = $tblPrepare->getServiceTblAppointedDateTask())
                                && ($tblDivisionItem = $tblPrepare->getServiceTblDivision())
                                && ($tblYear = $tblDivisionItem->getServiceTblYear())
                                && ($tblPeriodList = $tblYear->getTblPeriodAll($tblLevel && $tblLevel->getName() == '12'))
                                && ($tblPeriod = $tblAppointedDateTask->getServiceTblPeriodByDivision($tblDivision))
        Severity: Critical
        Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 1 hr to fix

          Method getForm has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getForm()
    {

        $form = new Form(array(
            new FormGroup(array(
          Severity: Minor
          Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if ($tblLeaveStudent->isApproved()) {
                                $selectBox->setDisabled();
                            }
            Severity: Major
            Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ($tblLeaveAdditionalGrade
                            && $tblLeaveAdditionalGrade->getGrade() !== null
                            && $tblLeaveAdditionalGrade->getGrade() !== ''
                        ) {
                            $value = str_pad($tblLeaveAdditionalGrade->getGrade(),2, 0, STR_PAD_LEFT);
              Severity: Major
              Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if ($tblLeaveAdditionalGrade) {
                            $global->POST['Data'][$midTerm][$tblSubject->getId()] = $tblLeaveAdditionalGrade->getGrade();
                        }
                Severity: Major
                Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 45 mins to fix

                  Consider simplifying this complex logical expression.
                  Open

                          if (($tblLeaveStudent = $this->tblLeaveStudent)
            && (($tblPerson = $tblLeaveStudent->getServiceTblPerson()))
            && ($tblStudent = $tblPerson->getStudent())
            && ($tblStudentSubjectType = Student::useService()->getStudentSubjectTypeByIdentifier('RELIGION'))
            && ($tblStudentSubjectRanking = Student::useService()->getStudentSubjectRankingByIdentifier('1'))
                  Severity: Major
                  Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 40 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                                            if ($tblPrepare->getServiceTblGenerateCertificate()
                            && ($tblCertificateType = $tblPrepare->getServiceTblGenerateCertificate()->getServiceTblCertificateType())
                            && ($tblCertificateType->getIdentifier() == 'MID_TERM_COURSE')
                            && ($tblPrepareStudent = Prepare::useService()->getPrepareStudentBy($tblPrepare,
                                $tblPerson))
                    Severity: Major
                    Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 40 mins to fix

                      Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function __construct(TblLeaveStudent $tblLeaveStudent, $view = BlockIView::PREVIEW)
    {
        $this->tblLeaveStudent = $tblLeaveStudent;
        $this->View = $view;
                      Severity: Minor
                      Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                              if ($tblPrepare->getServiceTblGenerateCertificate()
                            && ($tblCertificateType = $tblPrepare->getServiceTblGenerateCertificate()->getServiceTblCertificateType())
                            && ($tblCertificateType->getIdentifier() == 'MID_TERM_COURSE')
                            && ($tblPrepareStudent = Prepare::useService()->getPrepareStudentBy($tblPrepare,
                                $tblPerson))
                      Severity: Major
                      Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php and 1 other location - About 2 hrs to fix
                      Application/Education/Certificate/Prepare/Abitur/BlockI.php on lines 210..231

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 135.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          private function getSocialTable()
    {

        $dataList = array();
        $dataList = $this->setSubjectRow($dataList, 'Geschichte');
                      Severity: Major
                      Found in Application/Education/Certificate/Prepare/Abitur/LeavePoints.php and 1 other location - About 1 hr to fix
                      Application/Education/Certificate/Prepare/Abitur/BlockI.php on lines 380..397

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 102.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status