Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Certificate/Setting/Frontend.php

Summary

Maintainability
D
2 days
Test Coverage

Method frontendCertificateSetting has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendCertificateSetting($Certificate = 0, $Grade = array(), $Subject = array(), $Data = null)
    {

        $Stage = new Stage('Einstellungen', 'Vorlage bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Certificate/Setting/Template', new ChevronLeft()));
Severity: Major
Found in Application/Education/Certificate/Setting/Frontend.php - About 4 hrs to fix

    Function frontendCertificateSetting has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendCertificateSetting($Certificate = 0, $Grade = array(), $Subject = array(), $Data = null)
    {

        $Stage = new Stage('Einstellungen', 'Vorlage bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Certificate/Setting/Template', new ChevronLeft()));
    Severity: Minor
    Found in Application/Education/Certificate/Setting/Frontend.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Frontend.php has 327 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\Education\Certificate\Setting;

use SPHERE\Application\Education\Certificate\Generator\Generator;
use SPHERE\Application\Education\Certificate\Generator\Service\Entity\TblCertificate;
    Severity: Minor
    Found in Application/Education/Certificate/Setting/Frontend.php - About 3 hrs to fix

      Method frontendSelectCertificate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendSelectCertificate()
    {

        $Stage = new Stage('Einstellungen', 'Zeugnisvorlage auswählen');
        $Stage = self::setSettingMenue($Stage, 'Template');
      Severity: Major
      Found in Application/Education/Certificate/Setting/Frontend.php - About 2 hrs to fix

        Method frontendApproval has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendApproval($Data = null)
    {

        $Stage = new Stage('Einsellungen', 'Automatische Freigabe');
        $Stage = self::setSettingMenue($Stage, 'Approval');
        Severity: Minor
        Found in Application/Education/Certificate/Setting/Frontend.php - About 1 hr to fix

          Method getSubject has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getSubject(
        TblCertificate $tblCertificate,
        $tblSubjectAll,
        $LaneIndex,
        $LaneRanking,
          Severity: Minor
          Found in Application/Education/Certificate/Setting/Frontend.php - About 1 hr to fix

            Function frontendSelectCertificate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendSelectCertificate()
    {

        $Stage = new Stage('Einstellungen', 'Zeugnisvorlage auswählen');
        $Stage = self::setSettingMenue($Stage, 'Template');
            Severity: Minor
            Found in Application/Education/Certificate/Setting/Frontend.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getGrade has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    TblCertificate $tblCertificate,
        $tblGradeTypeAll,
        $LaneIndex,
        $LaneRanking,
        $LabelName = 'Betragen',
            Severity: Major
            Found in Application/Education/Certificate/Setting/Frontend.php - About 50 mins to fix

              Method getSubject has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      TblCertificate $tblCertificate,
        $tblSubjectAll,
        $LaneIndex,
        $LaneRanking,
        $LaneTitle = '',
              Severity: Minor
              Found in Application/Education/Certificate/Setting/Frontend.php - About 45 mins to fix

                Function frontendApproval has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendApproval($Data = null)
    {

        $Stage = new Stage('Einsellungen', 'Automatische Freigabe');
        $Stage = self::setSettingMenue($Stage, 'Approval');
                Severity: Minor
                Found in Application/Education/Certificate/Setting/Frontend.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            $Content = new TableData($TemplateTable, null, array(
                'Typ'         => 'Typ',
                'Category'         => 'Kategorie',
                'Name'        => 'Name',
                'Description' => 'Beschreibung',
                Severity: Major
                Found in Application/Education/Certificate/Setting/Frontend.php and 1 other location - About 2 hrs to fix
                Application/Education/Certificate/Approve/Frontend.php on lines 387..407

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 133.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status