Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/ClassRegister/Absence/Service.php

Summary

Maintainability
F
1 wk
Test Coverage

Function createAbsenceList has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

    public function createAbsenceList(
        IFormInterface $Stage = null,
        TblDivision $tblDivision,
        $BasicRoute = '',
        \DateTime $date = null,
Severity: Minor
Found in Application/Education/ClassRegister/Absence/Service.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 428 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 08.07.2016
Severity: Minor
Found in Application/Education/ClassRegister/Absence/Service.php - About 6 hrs to fix

    Function updateAbsence has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateAbsence(IFormInterface $Stage = null, TblAbsence $tblAbsence, $BasicRoute = '', $Data)
    {

        /**
         * Skip to Frontend
    Severity: Minor
    Found in Application/Education/ClassRegister/Absence/Service.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getAbsenceAllByDay has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getAbsenceAllByDay(\DateTime $dateTime, TblType $tblType = null, $divisionList = array())
    {
        $resultList = array();
        $tblAbsenceList = array();
        if (!empty($divisionList)
    Severity: Minor
    Found in Application/Education/ClassRegister/Absence/Service.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createAbsence has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createAbsence(
        IFormInterface $Stage = null,
        TblPerson $tblPerson,
        TblDivision $tblDivision,
        $BasicRoute = '',
    Severity: Minor
    Found in Application/Education/ClassRegister/Absence/Service.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createAbsenceList has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createAbsenceList(
        IFormInterface $Stage = null,
        TblDivision $tblDivision,
        $BasicRoute = '',
        \DateTime $date = null,
    Severity: Major
    Found in Application/Education/ClassRegister/Absence/Service.php - About 3 hrs to fix

      Function getAbsenceListByDate has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getAbsenceListByDate(TblPerson $tblPerson, TblDivision $tblDivision, \DateTime $date)
    {

        $resultList = array();
        if (($tblAbsenceList = $this->getAbsenceAllByPerson($tblPerson, $tblDivision))){
      Severity: Minor
      Found in Application/Education/ClassRegister/Absence/Service.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateAbsence has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateAbsence(IFormInterface $Stage = null, TblAbsence $tblAbsence, $BasicRoute = '', $Data)
    {

        /**
         * Skip to Frontend
      Severity: Major
      Found in Application/Education/ClassRegister/Absence/Service.php - About 2 hrs to fix

        Method createAbsence has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createAbsence(
        IFormInterface $Stage = null,
        TblPerson $tblPerson,
        TblDivision $tblDivision,
        $BasicRoute = '',
        Severity: Major
        Found in Application/Education/ClassRegister/Absence/Service.php - About 2 hrs to fix

          Method getAbsenceAllByDay has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getAbsenceAllByDay(\DateTime $dateTime, TblType $tblType = null, $divisionList = array())
    {
        $resultList = array();
        $tblAbsenceList = array();
        if (!empty($divisionList)
          Severity: Major
          Found in Application/Education/ClassRegister/Absence/Service.php - About 2 hrs to fix

            Function getExcusedDaysByPerson has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getExcusedDaysByPerson(TblPerson $tblPerson, TblDivision $tblDivision, \DateTime $tillDate = null)
    {

        $list = array();
        // Fehlzeiten aus alle Klassen des Schuljahrs
            Severity: Minor
            Found in Application/Education/ClassRegister/Absence/Service.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getUnexcusedDaysByPerson has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                function getUnexcusedDaysByPerson(TblPerson $tblPerson, TblDivision $tblDivision, \DateTime $tillDate = null)
    {

        $list = array();
        // Fehlzeiten aus alle Klassen des Schuljahrs
            Severity: Minor
            Found in Application/Education/ClassRegister/Absence/Service.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createAbsence has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    IFormInterface $Stage = null,
        TblPerson $tblPerson,
        TblDivision $tblDivision,
        $BasicRoute = '',
        $Data
            Severity: Minor
            Found in Application/Education/ClassRegister/Absence/Service.php - About 35 mins to fix

              Method createAbsenceList has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      IFormInterface $Stage = null,
        TblDivision $tblDivision,
        $BasicRoute = '',
        \DateTime $date = null,
        $Data
              Severity: Minor
              Found in Application/Education/ClassRegister/Absence/Service.php - About 35 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (($tblYear = $tblDivision->getServiceTblYear())) {
                $tblLevel = $tblDivision->getTblLevel();
                $tblPeriodList = Term::useService()->getPeriodAllByYear($tblYear, $tblLevel && $tblLevel->getName() == '12');
                if ($tblPeriodList) {
                    foreach ($tblPeriodList as $tblPeriod) {
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 4 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 128..145

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 182.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (($tblYear = $tblDivision->getServiceTblYear())) {
            $tblLevel = $tblDivision->getTblLevel();
            $tblPeriodList = Term::useService()->getPeriodAllByYear($tblYear, $tblLevel && $tblLevel->getName() == '12');
            if ($tblPeriodList) {
                foreach ($tblPeriodList as $tblPeriod) {
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 4 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 228..245

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 182.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (!$Error && $minDate && $maxDate) {
                if (new \DateTime($Data['FromDate']) < $minDate) {
                    $Stage->setError('Data[FromDate]',
                        'Eingabe außerhalb des Schuljahres ('.$minDate->format('d.m.Y').' - '.$maxDate->format('d.m.Y').')');
                    $Error = true;
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 3 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 146..157

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 155.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (!$Error && $minDate && $maxDate) {
            if (new \DateTime($Data['FromDate']) < $minDate) {
                $Stage->setError('Data[FromDate]',
                    'Eingabe außerhalb des Schuljahres ('.$minDate->format('d.m.Y').' - '.$maxDate->format('d.m.Y').')');
                $Error = true;
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 3 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 246..257

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 155.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getExcusedDaysByPerson(TblPerson $tblPerson, TblDivision $tblDivision, \DateTime $tillDate = null)
    {

        $list = array();
        // Fehlzeiten aus alle Klassen des Schuljahrs
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 3 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 298..319

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 151.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    function getUnexcusedDaysByPerson(TblPerson $tblPerson, TblDivision $tblDivision, \DateTime $tillDate = null)
    {

        $list = array();
        // Fehlzeiten aus alle Klassen des Schuljahrs
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 3 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 328..350

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 151.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (isset($Data['FromDate']) && !empty($Data['FromDate'])
            && isset($Data['ToDate']) && !empty($Data['ToDate'])
        ) {
            $fromDate = new \DateTime($Data['FromDate']);
            $toDate = new \DateTime($Data['ToDate']);
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 2 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 208..217

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (isset($Data['FromDate']) && !empty($Data['FromDate'])
            && isset($Data['ToDate']) && !empty($Data['ToDate'])
        ) {
            $fromDate = new \DateTime($Data['FromDate']);
            $toDate = new \DateTime($Data['ToDate']);
                Severity: Major
                Found in Application/Education/ClassRegister/Absence/Service.php and 1 other location - About 2 hrs to fix
                Application/Education/ClassRegister/Absence/Service.php on lines 115..124

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status