Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Graduation/Evaluation/Service/Data.php

Summary

Maintainability
F
1 wk
Test Coverage

File Data.php has 732 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Education\Graduation\Evaluation\Service;

use SPHERE\Application\Education\Graduation\Evaluation\Service\Entity\TblTask;
use SPHERE\Application\Education\Graduation\Evaluation\Service\Entity\TblTest;
Severity: Major
Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 day to fix

    Function updateDivisionBehaviorTaskAsBulk has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateDivisionBehaviorTaskAsBulk(
        $behaviorTaskAddList,
        $behaviorTaskRemoveTestList
    ) {
    Severity: Minor
    Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateDivisionAppointedDateTaskAsBulk has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateDivisionAppointedDateTaskAsBulk(
        $addList,
        $removeList
    ) {
    Severity: Minor
    Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Data has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Data extends AbstractData
{

    public function setupDatabaseContent()
    {
    Severity: Minor
    Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 4 hrs to fix

      Method getTestAllByTypeAndDivisionAndSubjectAndPeriodAndSubjectGroup has 90 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getTestAllByTypeAndDivisionAndSubjectAndPeriodAndSubjectGroup(
        TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblTestType $tblTestType = null,
        TblPeriod $tblPeriod = null,
      Severity: Major
      Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 3 hrs to fix

        Function getTestAllByTypeAndDivisionAndSubjectAndPeriodAndSubjectGroup has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getTestAllByTypeAndDivisionAndSubjectAndPeriodAndSubjectGroup(
        TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblTestType $tblTestType = null,
        TblPeriod $tblPeriod = null,
        Severity: Minor
        Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method updateDivisionBehaviorTaskAsBulk has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updateDivisionBehaviorTaskAsBulk(
        $behaviorTaskAddList,
        $behaviorTaskRemoveTestList
    ) {
        Severity: Major
        Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 2 hrs to fix

          Method updateDivisionAppointedDateTaskAsBulk has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateDivisionAppointedDateTaskAsBulk(
        $addList,
        $removeList
    ) {
          Severity: Major
          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 2 hrs to fix

            Method createTest has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createTest(
        TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblSubjectGroup $tblSubjectGroup = null,
        TblPeriod $tblPeriod = null,
            Severity: Minor
            Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

              Method createTest has 13 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblSubjectGroup $tblSubjectGroup = null,
        TblPeriod $tblPeriod = null,
        TblGradeType $tblGradeType = null,
              Severity: Major
              Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

                Function getTestLinkAllByTest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getTestLinkAllByTest(TblTest $tblTest)
    {

        $resultList = array();
        /** @var TblTestLink $tblTestLink */
                Severity: Minor
                Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method updateTask has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        TblTask $tblTask,
        TblTestType $tblTestType,
        $Name,
        $Date = null,
        $FromDate = null,
                Severity: Major
                Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

                  Method createTask has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          TblTestType $tblTestType,
        $Name,
        $Date = null,
        $FromDate = null,
        $ToDate = null,
                  Severity: Major
                  Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

                    Method updateTest has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            TblTest $tblTest,
        $Description = '',
        $Date = null,
        $CorrectionDate = null,
        $ReturnDate = null,
                    Severity: Major
                    Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 50 mins to fix

                      Method getTestAllByTypeAndDivisionAndSubjectAndPeriodAndSubjectGroup has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblTestType $tblTestType = null,
        TblPeriod $tblPeriod = null,
        TblSubjectGroup $tblSubjectGroup = null
                      Severity: Minor
                      Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 35 mins to fix

                        Method existsTestByTaskAndGradeType has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                TblTask $tblTask,
        TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblGradeType $tblGradeType,
        TblSubjectGroup $tblSubjectGroup = null
                        Severity: Minor
                        Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 35 mins to fix

                          Function getNextLinkId has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getNextLinkId()
    {

        $list = $this->getCachedEntityList(__METHOD__, $this->getConnection()->getEntityManager(), 'TblTestLink');
        $max = 0;
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function destroyTest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function destroyTest(TblTest $tblTest)
    {

        $Manager = $this->getConnection()->getEntityManager();
        /** @var TblTest $Entity */
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function destroyTask has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function destroyTask(TblTask $tblTask)
    {

        $Manager = $this->getConnection()->getEntityManager();
        /** @var TblTask $Entity */
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function getTaskAllByDivision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getTaskAllByDivision(TblDivision $tblDivision, TblTestType $tblTestType)
    {

        $resultList = array();
        $list = $this->getCachedEntityListBy(__METHOD__, $this->getConnection()->getEntityManager(), 'TblTest',
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function createTest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function createTest(
        TblDivision $tblDivision,
        TblSubject $tblSubject,
        TblSubjectGroup $tblSubjectGroup = null,
        TblPeriod $tblPeriod = null,
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      } else {
                if ($tblPeriod === null) {
                    $list = $this->getCachedEntityListBy(__METHOD__, $this->getConnection()->getEntityManager(),
                        'TblTest',
                        array(
                          Severity: Major
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 4 hrs to fix
                          Application/Education/Graduation/Gradebook/Service/Data.php on lines 373..417

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 173.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if ($tblSubjectGroup === null) {
                if ($tblPeriod === null) {
                    $list = $this->getCachedEntityListBy(__METHOD__, $this->getConnection()->getEntityManager(),
                        'TblTest',
                        array(
                          Severity: Major
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 3 hrs to fix
                          Application/Education/Graduation/Evaluation/Service/Data.php on lines 119..140

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 151.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      } else {
                if ($tblPeriod === null) {
                    $list = $this->getCachedEntityListBy(__METHOD__, $this->getConnection()->getEntityManager(),
                        'TblTest',
                        array(
                          Severity: Major
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 3 hrs to fix
                          Application/Education/Graduation/Evaluation/Service/Data.php on lines 142..186

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 151.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function existsTestByDivisionSubject(TblDivisionSubject $tblDivisionSubject)
    {

        return $this->getCachedEntityBy(__METHOD__, $this->getConnection()->getEntityManager(), 'TblTest', array(
            TblTest::ATTR_SERVICE_TBL_DIVISION => $tblDivisionSubject->getTblDivision()->getId(),
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 55 mins to fix
                          Application/Education/Graduation/Gradebook/Service/Data.php on lines 720..729

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 99.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function getTestTypeAllWhereTask()
    {

        $queryBuilder = $this->getConnection()->getEntityManager()->getQueryBuilder();
        $queryBuilder->select('t')
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 35 mins to fix
                          Application/Education/Graduation/Evaluation/Service/Data.php on lines 294..307

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function getTestTypesForGradeTypes()
    {

        $queryBuilder = $this->getConnection()->getEntityManager()->getQueryBuilder();
        $queryBuilder->select('t')
                          Severity: Minor
                          Found in Application/Education/Graduation/Evaluation/Service/Data.php and 1 other location - About 35 mins to fix
                          Application/Education/Graduation/Evaluation/Service/Data.php on lines 312..325

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status