Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php

Summary

Maintainability
F
4 days
Test Coverage

File Frontend.php has 482 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 20.09.2016
Severity: Minor
Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 7 hrs to fix

    Method frontendMinimumGradeCount has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendMinimumGradeCount($MinimumGradeCount = null)
    {

        $Stage = new Stage('Mindestnotenanzahl', 'Übersicht');
        $Stage->setMessage(
    Severity: Major
    Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 5 hrs to fix

      Function frontendDestroyMinimumGradeCount has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendDestroyMinimumGradeCount(
        $Id = null,
        $Confirm = false
    ) {
      Severity: Minor
      Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method formMinimumGradeCount has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function formMinimumGradeCount()
    {

        if (($tblTestType = Evaluation::useService()->getTestTypeByIdentifier('TEST'))) {
            $tblGradeTypeList = Gradebook::useService()->getGradeTypeAllByTestType($tblTestType);
      Severity: Major
      Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 3 hrs to fix

        Function frontendMinimumGradeCount has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendMinimumGradeCount($MinimumGradeCount = null)
    {

        $Stage = new Stage('Mindestnotenanzahl', 'Übersicht');
        $Stage->setMessage(
        Severity: Minor
        Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method frontendDestroyMinimumGradeCount has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendDestroyMinimumGradeCount(
        $Id = null,
        $Confirm = false
    ) {
        Severity: Major
        Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 3 hrs to fix

          Function frontendEditMinimumGradeCount has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendEditMinimumGradeCount($Id = null, $MinimumGradeCount = null)
    {

        $Stage = new Stage('Mindestnotenanzahl', 'Bearbeiten');
        $Stage->addButton(
          Severity: Minor
          Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setMinimumGradeCountReporting has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function setMinimumGradeCountReporting($Data, $IsDivisionTeacher, $PersonId = null)
    {
        $stage = new Stage('Mindestnotenanzahl', 'Auswertung');
        $stage->addButton(new Standard(
            'Zurück',
          Severity: Major
          Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 2 hrs to fix

            Method frontendEditMinimumGradeCount has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendEditMinimumGradeCount($Id = null, $MinimumGradeCount = null)
    {

        $Stage = new Stage('Mindestnotenanzahl', 'Bearbeiten');
        $Stage->addButton(
            Severity: Major
            Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 2 hrs to fix

              Function formMinimumGradeCount has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function formMinimumGradeCount()
    {

        if (($tblTestType = Evaluation::useService()->getTestTypeByIdentifier('TEST'))) {
            $tblGradeTypeList = Gradebook::useService()->getGradeTypeAllByTestType($tblTestType);
              Severity: Minor
              Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                              if (!$Confirm) {
                    $Stage->setContent(
                        new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(array(
                            new Panel(new Question() . ' Diese Mindestnotenanzahl wirklich löschen?',
                                array(
              Severity: Major
              Found in Application/Education/Graduation/Gradebook/MinimumGradeCount/Frontend.php and 3 other locations - About 1 hr to fix
              Application/Education/Graduation/Gradebook/Frontend.php on lines 1766..1804
              Application/Education/Graduation/Gradebook/ScoreRule/Frontend.php on lines 1982..2016
              Application/Education/Graduation/Gradebook/ScoreRule/Frontend.php on lines 2073..2105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 110.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status