Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Lesson/Subject/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 930 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Education\Lesson\Subject;

use SPHERE\Application\Education\Lesson\Division\Division;
use SPHERE\Application\Education\Lesson\Subject\Service\Entity\TblCategory;
Severity: Major
Found in Application/Education/Lesson/Subject/Frontend.php - About 2 days to fix

    Function frontendSubjectPersonAdd has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendSubjectPersonAdd(
        $Id = null,
        $SubjectId = null,
        $Group = null,
        $DataAddPerson = null,
    Severity: Minor
    Found in Application/Education/Lesson/Subject/Frontend.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method frontendSubjectPersonAdd has 231 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendSubjectPersonAdd(
        $Id = null,
        $SubjectId = null,
        $Group = null,
        $DataAddPerson = null,
    Severity: Major
    Found in Application/Education/Lesson/Subject/Frontend.php - About 1 day to fix

      Function frontendLinkPerson has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendLinkPerson($Id = null)
    {

        $Stage = new Stage('', 'Zuordnung');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
      Severity: Minor
      Found in Application/Education/Lesson/Subject/Frontend.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method frontendLinkPerson has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendLinkPerson($Id = null)
    {

        $Stage = new Stage('', 'Zuordnung');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
      Severity: Major
      Found in Application/Education/Lesson/Subject/Frontend.php - About 2 hrs to fix

        Method frontendCreateCategory has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendCreateCategory($Category = null)
    {

        $Stage = new Stage('Kategorien', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
        Severity: Minor
        Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

          Method frontendDestroySubject has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendDestroySubject(
        $Id = null,
        $Confirm = false
    ) {
          Severity: Minor
          Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

            Method frontendCreateSubject has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendCreateSubject($Subject = null)
    {

        $Stage = new Stage('Fächer', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
            Severity: Minor
            Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

              Method frontendDestroyCategory has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendDestroyCategory(
        $Id = null,
        $Confirm = false
    ) {
              Severity: Minor
              Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                Method formLinkCategory has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function formLinkCategory(TblGroup $tblGroup = null, $IsStandardGroup = false)
    {

        $tblCategoryAllSelected = $tblGroup->getTblCategoryAll();
        if ($tblCategoryAllSelected) {
                Severity: Minor
                Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                  Method frontendChangeSubject has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function frontendChangeSubject($Id, $Subject)
    {

        $Stage = new Stage('Fach', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject/Create/Subject', new ChevronLeft()));
                  Severity: Minor
                  Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                    Method formSubject has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function formSubject(TblSubject $tblSubject = null)
    {

        $acAcronymAll = array();
        $acNameAll = array();
                    Severity: Minor
                    Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                      Method frontendChangeCategory has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function frontendChangeCategory($Id, $Category)
    {

        $Stage = new Stage('Kategorie', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject/Create/Category', new ChevronLeft()));
                      Severity: Minor
                      Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                        Method frontendLinkCategory has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function frontendLinkCategory($Id, $Category = null)
    {

        $Stage = new Stage('Kategorien', 'Verknüpfung');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
                        Severity: Minor
                        Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                          Method formCategory has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function formCategory(TblCategory $tblCategory = null)
    {

        $tblCategoryAll = Subject::useService()->getCategoryAll();
        $acAcronymAll = array();
                          Severity: Minor
                          Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                            Method frontendLinkSubject has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function frontendLinkSubject($Id, $Subject = null)
    {

        $Stage = new Stage('Fächer', 'Verknüpfung');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Subject', new ChevronLeft()));
                            Severity: Minor
                            Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                              Function formFilter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  private function formFilter()
    {

//        $tblGroupAll = Group::useService()->getGroupAllSorted();
        $tblDivisionList = array();
                              Severity: Minor
                              Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method formLinkSubject has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function formLinkSubject(TblCategory $tblCategory = null)
    {

        $tblSubjectAllSelected = $tblCategory->getTblSubjectAll();
        if ($tblSubjectAllSelected) {
                              Severity: Minor
                              Found in Application/Education/Lesson/Subject/Frontend.php - About 1 hr to fix

                                Method frontendSubjectPersonAdd has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        $Id = null,
        $SubjectId = null,
        $Group = null,
        $DataAddPerson = null,
        $DataRemovePerson = null,
                                Severity: Major
                                Found in Application/Education/Lesson/Subject/Frontend.php - About 50 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                  if ($StudentSubject->getServiceTblSubject()->getName() == $tblSubject->getName()) {
                                    $tblPersonList[] = $tblPersonStudent;
                                }
                                  Severity: Major
                                  Found in Application/Education/Lesson/Subject/Frontend.php - About 45 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return $Stage;
                                    Severity: Major
                                    Found in Application/Education/Lesson/Subject/Frontend.php - About 30 mins to fix

                                      Function setPersonData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function setPersonData(TblPerson $tblPerson, $DataName)
    {
        $result = array();
        $result['Check'] = new CheckBox(
            $DataName.'['.$tblPerson->getId().']',
                                      Severity: Minor
                                      Found in Application/Education/Lesson/Subject/Frontend.php - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  if (!$Confirm) {
                $Stage->setContent(
                    new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(array(
                                new Panel(
                                    'Kategorie',
                                      Severity: Major
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 5 hrs to fix
                                      Application/Education/Graduation/Gradebook/Frontend.php on lines 1766..1804

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 203.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                      $displayAvailablePersons = new TableData(
                    $tblPersonAll,
                    new \SPHERE\Common\Frontend\Table\Repository\Title('Fach "'.$tblSubject->getName().'" von der Kategorie "'.$SubjectGroup.'" der Personen',
                        'hinzufügen'),
                    array(
                                      Severity: Major
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 5 hrs to fix
                                      Application/Education/Lesson/Subject/Frontend.php on lines 688..722

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 193.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                                      ? new TableData(
                                    $tblPersonList,
                                    new \SPHERE\Common\Frontend\Table\Repository\Title('Fach "'.$tblSubject->getName().'" von der Kategorie "'.$SubjectGroup.'" der Personen',
                                        'entfernen'),
                                    array(
                                      Severity: Major
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 5 hrs to fix
                                      Application/Education/Lesson/Subject/Frontend.php on lines 644..678

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 193.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  new Layout(
                new LayoutGroup(
                    new LayoutRow(
                        new LayoutColumn(
                            new Panel('Fach', $tblSubject->getAcronym() . ' - ' . $tblSubject->getName(),
                                      Severity: Major
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 1 hr to fix
                                      Application/Education/Lesson/Subject/Frontend.php on lines 361..385

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 107.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  new Layout(
                new LayoutGroup(
                    new LayoutRow(
                        new LayoutColumn(
                            new Panel('Kategorie',
                                      Severity: Major
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 1 hr to fix
                                      Application/Education/Lesson/Subject/Frontend.php on lines 205..228

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 107.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                      new LayoutGroup(
                    new LayoutRow(
                        new LayoutColumn(
                            new Well(
                                Subject::useService()->changeCategorySubject(
                                      Severity: Minor
                                      Found in Application/Education/Lesson/Subject/Frontend.php and 1 other location - About 50 mins to fix
                                      Application/Setting/Authorization/Account/Frontend.php on lines 500..510

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 97.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status