Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Education/Lesson/Term/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 881 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Education\Lesson\Term;

use SPHERE\Application\Education\Lesson\Term\Service\Entity\TblHoliday;
use SPHERE\Application\Education\Lesson\Term\Service\Entity\TblPeriod;
Severity: Major
Found in Application/Education/Lesson/Term/Frontend.php - About 2 days to fix

    Method frontendSelectHoliday has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendSelectHoliday(
        $YearId = null,
        $DataAddHoliday = null,
        $DataRemoveHoliday = null
    ) {
    Severity: Major
    Found in Application/Education/Lesson/Term/Frontend.php - About 5 hrs to fix

      Method frontendChoosePeriod has 142 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendChoosePeriod($Id = null, $Period = null, $Remove = null)
    {

        $tblYear = $Id === null ? false : Term::useService()->getYearById($Id);
        if ($tblYear) {
      Severity: Major
      Found in Application/Education/Lesson/Term/Frontend.php - About 5 hrs to fix

        Method frontendCreatePeriod has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendCreatePeriod($Period = null)
    {

        $Stage = new Stage('Zeitraum', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Term', new ChevronLeft()));
        Severity: Major
        Found in Application/Education/Lesson/Term/Frontend.php - About 2 hrs to fix

          Function frontendSelectHoliday has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendSelectHoliday(
        $YearId = null,
        $DataAddHoliday = null,
        $DataRemoveHoliday = null
    ) {
          Severity: Minor
          Found in Application/Education/Lesson/Term/Frontend.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method frontendHoliday has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendHoliday($Data = null)
    {

        $Stage = new Stage('Unterrichtsfreie Tage', 'Übersicht');
          Severity: Major
          Found in Application/Education/Lesson/Term/Frontend.php - About 2 hrs to fix

            Method frontendDestroyHoliday has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendDestroyHoliday($Id = null, $Confirm = false)
    {

        $Stage = new Stage('Unterrichtsfreie Tage', 'Löschen');
            Severity: Major
            Found in Application/Education/Lesson/Term/Frontend.php - About 2 hrs to fix

              Method frontendCreateYear has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendCreateYear($Year = null)
    {

        $Stage = new Stage('Schuljahr', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Term', new ChevronLeft()));
              Severity: Major
              Found in Application/Education/Lesson/Term/Frontend.php - About 2 hrs to fix

                Method frontendEditHoliday has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function frontendEditHoliday($Id = null, $Data = null)
    {

        $Stage = new Stage('Unterrichtsfreie Tage', 'Bearbeiten');
        $tblHoliday = Term::useService()->getHolidayById($Id);
                Severity: Minor
                Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                  Method formPeriod has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function formPeriod(TblPeriod $tblPeriod = null)
    {

        $tblPeriodAll = Term::useService()->getPeriodAll();
        $acNameAll = array();
                  Severity: Minor
                  Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                    Function frontendChoosePeriod has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function frontendChoosePeriod($Id = null, $Period = null, $Remove = null)
    {

        $tblYear = $Id === null ? false : Term::useService()->getYearById($Id);
        if ($tblYear) {
                    Severity: Minor
                    Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method formYear has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function formYear(TblYear $tblYear = null)
    {

        $YearList = array();
        for ($i = -1; $i < 5; $i++) {
                    Severity: Minor
                    Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                      Method frontendEditPeriod has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function frontendEditPeriod($Id = null, $Period = null)
    {

        $Stage = new Stage('Zeitraum', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Term/Create/Period', new ChevronLeft()));
                      Severity: Minor
                      Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                        Function formYear has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function formYear(TblYear $tblYear = null)
    {

        $YearList = array();
        for ($i = -1; $i < 5; $i++) {
                        Severity: Minor
                        Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method frontendEditYear has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function frontendEditYear($Id = null, $Year = null)
    {

        $Stage = new Stage('Schuljahr', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Education/Lesson/Term/Create/Year', new ChevronLeft()));
                        Severity: Minor
                        Found in Application/Education/Lesson/Term/Frontend.php - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  new FormColumn(array(
                            ($tblHolidayList
                                ? new TableData(
                                    $tblHolidayList,
                                    new \SPHERE\Common\Frontend\Table\Repository\Title('Unterrichtsfreie Tage des Schuljahrs "' . $tblYear->getName() . '"',
                          Severity: Major
                          Found in Application/Education/Lesson/Term/Frontend.php and 1 other location - About 7 hrs to fix
                          Application/Education/Lesson/Term/Frontend.php on lines 932..963

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 231.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  new FormColumn(array(
                            ($tblHolidayAll
                                ? new TableData(
                                    $tblHolidayAll,
                                    new \SPHERE\Common\Frontend\Table\Repository\Title('Weitere mögliche Unterrichtsfreie Tage dem Schuljahr "' . $tblYear->getDisplayName() . '"',
                          Severity: Major
                          Found in Application/Education/Lesson/Term/Frontend.php and 1 other location - About 7 hrs to fix
                          Application/Education/Lesson/Term/Frontend.php on lines 900..931

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 231.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  new LayoutColumn(array(
                            new Title('Zeiträume', 'Verfügbar'),
                            (empty($tblPeriodAvailableList)
                                ? new Info('Keine weiteren Zeiträume verfügbar')
                                : new TableData($contentPeriodAvailable, null,
                          Severity: Major
                          Found in Application/Education/Lesson/Term/Frontend.php and 1 other location - About 3 hrs to fix
                          Application/Education/Lesson/Term/Frontend.php on lines 431..455

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 149.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  new LayoutColumn(array(
                            new Title('Zeiträume', 'Zugewiesen'),
                            (empty($tblPeriodUsedList)
                                ? new Warning('Kein Zeitraum zugewiesen')
                                : new TableData($contentPeriodUsed, null,
                          Severity: Major
                          Found in Application/Education/Lesson/Term/Frontend.php and 1 other location - About 3 hrs to fix
                          Application/Education/Lesson/Term/Frontend.php on lines 456..480

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 149.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (!$Confirm) {
                $Stage->setContent(
                    new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(array(
                        new Panel(
                            new Question() . ' Diese Unterrichtsfreien Tage wirklich löschen?',
                          Severity: Major
                          Found in Application/Education/Lesson/Term/Frontend.php and 1 other location - About 2 hrs to fix
                          Application/Education/Certificate/Generate/Frontend.php on lines 1118..1195

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 128.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status