Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Group/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 713 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\People\Group;

use SPHERE\Application\Education\Lesson\Division\Division;
use SPHERE\Application\Education\Lesson\Term\Term;
Severity: Major
Found in Application/People/Group/Frontend.php - About 1 day to fix

    Method frontendGroupPersonAdd has 196 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendGroupPersonAdd(
        $Id = null,
        $DataAddPerson = null,
        $DataRemovePerson = null,
        $Filter = null,
    Severity: Major
    Found in Application/People/Group/Frontend.php - About 7 hrs to fix

      Function frontendGroupPersonAdd has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendGroupPersonAdd(
        $Id = null,
        $DataAddPerson = null,
        $DataRemovePerson = null,
        $Filter = null,
      Severity: Minor
      Found in Application/People/Group/Frontend.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function frontendSaveRelationshipCustody has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendSaveRelationshipCustody()
    {
        $stage = new Stage('Einordnung der Sorgeberechtigten', 'nach S1, S2, S3');
        $stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
      Severity: Minor
      Found in Application/People/Group/Frontend.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method frontendSaveRelationshipCustody has 86 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendSaveRelationshipCustody()
    {
        $stage = new Stage('Einordnung der Sorgeberechtigten', 'nach S1, S2, S3');
        $stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
      Severity: Major
      Found in Application/People/Group/Frontend.php - About 3 hrs to fix

        Method frontendGroup has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendGroup($Group = null)
    {

        $Stage = new Stage('Gruppen', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/People', new ChevronLeft()));
        Severity: Major
        Found in Application/People/Group/Frontend.php - About 3 hrs to fix

          Method frontendRelationshipCustody has 79 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendRelationshipCustody()
    {
        $stage = new Stage('Einordnung der Sorgeberechtigten', 'nach S1, S2, S3');
        $stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
          Severity: Major
          Found in Application/People/Group/Frontend.php - About 3 hrs to fix

            Function frontendRelationshipCustody has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendRelationshipCustody()
    {
        $stage = new Stage('Einordnung der Sorgeberechtigten', 'nach S1, S2, S3');
        $stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
            Severity: Minor
            Found in Application/People/Group/Frontend.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method frontendEditGroup has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendEditGroup($Id, $Group = null)
    {

        $Stage = new Stage('Gruppe', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
            Severity: Major
            Found in Application/People/Group/Frontend.php - About 2 hrs to fix

              Method frontendDestroyGroup has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendDestroyGroup($Id, $Confirm = false)
    {

        $Stage = new Stage('Gruppe', 'Löschen');
        $Stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
              Severity: Major
              Found in Application/People/Group/Frontend.php - About 2 hrs to fix

                Method formFilter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function formFilter()
    {

        $tblGroupAll = Group::useService()->getGroupAllSorted();
        $tblDivisionList = array();
                Severity: Minor
                Found in Application/People/Group/Frontend.php - About 1 hr to fix

                  Function formFilter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function formFilter()
    {

        $tblGroupAll = Group::useService()->getGroupAllSorted();
        $tblDivisionList = array();
                  Severity: Minor
                  Found in Application/People/Group/Frontend.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function frontendDestroyGroup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function frontendDestroyGroup($Id, $Confirm = false)
    {

        $Stage = new Stage('Gruppe', 'Löschen');
        $Stage->addButton(new Standard('Zurück', '/People/Group', new ChevronLeft()));
                  Severity: Minor
                  Found in Application/People/Group/Frontend.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method frontendGroupPersonAdd has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $Id = null,
        $DataAddPerson = null,
        $DataRemovePerson = null,
        $Filter = null,
        $FilterGroupId = null,
                  Severity: Minor
                  Found in Application/People/Group/Frontend.php - About 45 mins to fix

                    Function frontendGroup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function frontendGroup($Group = null)
    {

        $Stage = new Stage('Gruppen', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/People', new ChevronLeft()));
                    Severity: Minor
                    Found in Application/People/Group/Frontend.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function setPersonData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function setPersonData(TblPerson $tblPerson, $DataName)
    {
        $result = array();
        $result['Check'] = new CheckBox(
            $DataName . '[' . $tblPerson->getId() . ']',
                    Severity: Minor
                    Found in Application/People/Group/Frontend.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    new TableData(
                    $content,
                    new \SPHERE\Common\Frontend\Table\Repository\Title('Vorschau', '(grün = wird geändert, gelb/rot = keine automatische Zuordnung)'),
                    array(
                        'Student' => 'Schüler / Interessent / Ehemalige',
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 4 hrs to fix
                    Application/People/Group/Frontend.php on lines 807..833

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 168.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    . new TableData(
                    $content,
                    new \SPHERE\Common\Frontend\Table\Repository\Title('Keine automatische Zuordnung für folgende Datensätze',
                        'manuelle Korrektur in der Personenverwaltung notwendig'),
                    array(
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 4 hrs to fix
                    Application/People/Group/Frontend.php on lines 703..728

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 168.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    $content[] = array(
                    'Student' => $custodySorter->getTblPerson()->getLastFirstName(),
                    'S1' => $custodySorter->getCustody1() ? $custodySorter->getCustody1()->getName() : '',
                    'S2' => $custodySorter->getCustody2() ? $custodySorter->getCustody2()->getName() : '',
                    'S3' => $custodySorter->getCustody3() ? $custodySorter->getCustody3()->getName() : '',
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 4 hrs to fix
                    Application/People/Group/Frontend.php on lines 779..793

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 162.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                        $content[] = array(
                        'Student' => $custodySorter->getTblPerson()->getLastFirstName(),
                        'S1' => $custodySorter->getCustody1() ? $custodySorter->getCustody1()->getName() : '',
                        'S2' => $custodySorter->getCustody2() ? $custodySorter->getCustody2()->getName() : '',
                        'S3' => $custodySorter->getCustody3() ? $custodySorter->getCustody3()->getName() : '',
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 4 hrs to fix
                    Application/People/Group/Frontend.php on lines 685..699

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 162.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (!$Confirm) {
                $Stage->setContent(
                    new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(
                        new Panel(new Question() . ' Diese Gruppe wirklich löschen?', array(
                            $tblGroup->getName() . ' ' . $tblGroup->getDescription(),
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 3 hrs to fix
                    Application/Corporation/Group/Frontend.php on lines 235..277

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 158.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        private function formGroup()
    {

        return new Form(
            new FormGroup(
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 3 hrs to fix
                    Application/Corporation/Group/Frontend.php on lines 143..163

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 144.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            $Stage->setContent(
            new Layout(array(
                new LayoutGroup(
                    $LayoutRowList
                    , new Title(new ListingTable() . ' Übersicht')
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 1 other location - About 2 hrs to fix
                    Application/Corporation/Group/Frontend.php on lines 115..136

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 136.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                        new LayoutGroup(
                        new LayoutRow(
                            new LayoutColumn(
                                new Well(
                                    Group::useService()->updateGroup(
                    Severity: Major
                    Found in Application/People/Group/Frontend.php and 2 other locations - About 40 mins to fix
                    Application/Corporation/Group/Frontend.php on lines 188..201
                    Application/Education/Lesson/Division/Frontend.php on lines 293..305

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 94.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status