Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Group/Service.php

Summary

Maintainability
F
1 wk
Test Coverage

Function filterPersonListByGroupAndDivision has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

    public function filterPersonListByGroupAndDivision(
        $tblPersonList,
        TblGroup $tblGroup = null,
        TblDivision $tblDivision = null
    ) {
Severity: Minor
Found in Application/People/Group/Service.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\People\Group;

use SPHERE\Application\Education\Lesson\Division\Division;
use SPHERE\Application\Education\Lesson\Division\Service\Entity\TblDivision;
Severity: Minor
Found in Application/People/Group/Service.php - About 6 hrs to fix

    Function getTudorGroupAll has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getTudorGroupAll(TblPerson $tblPerson = null)
    {
        $list = array();
        if (($tblStudentGroup = $this->getGroupByMetaTable(TblGroup::META_TABLE_STUDENT))
            && ($tblTudorGroup = $this->getGroupByMetaTable(TblGroup::META_TABLE_TUDOR))
    Severity: Minor
    Found in Application/People/Group/Service.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Service has 40 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Service extends AbstractService
{

    /**
     * @return false|ViewPeopleGroupMember[]
    Severity: Minor
    Found in Application/People/Group/Service.php - About 5 hrs to fix

      Function getTudors has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getTudors(TblGroup $tblGroup)
    {

        if ($tblGroup->isLocked()) {
            return false;
      Severity: Minor
      Found in Application/People/Group/Service.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filterPersonListByGroupAndDivision has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function filterPersonListByGroupAndDivision(
        $tblPersonList,
        TblGroup $tblGroup = null,
        TblDivision $tblDivision = null
    ) {
      Severity: Minor
      Found in Application/People/Group/Service.php - About 1 hr to fix

        Method getTudorGroupAll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getTudorGroupAll(TblPerson $tblPerson = null)
    {
        $list = array();
        if (($tblStudentGroup = $this->getGroupByMetaTable(TblGroup::META_TABLE_STUDENT))
            && ($tblTudorGroup = $this->getGroupByMetaTable(TblGroup::META_TABLE_TUDOR))
        Severity: Minor
        Found in Application/People/Group/Service.php - About 1 hr to fix

          Function updateGroup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateGroup(IFormInterface $Form = null, TblGroup $tblGroup, $Group)
    {

        /**
         * Skip to Frontend
          Severity: Minor
          Found in Application/People/Group/Service.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createGroup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createGroup(IFormInterface $Form = null, $Group)
    {

        /**
         * Skip to Frontend
          Severity: Minor
          Found in Application/People/Group/Service.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createGroup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createGroup(IFormInterface $Form = null, $Group)
    {

        /**
         * Skip to Frontend
          Severity: Minor
          Found in Application/People/Group/Service.php - About 1 hr to fix

            Method updateGroup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function updateGroup(IFormInterface $Form = null, TblGroup $tblGroup, $Group)
    {

        /**
         * Skip to Frontend
            Severity: Minor
            Found in Application/People/Group/Service.php - About 1 hr to fix

              Method addPersonsToGroup has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      IFormInterface $Form,
        TblGroup $tblGroup,
        $DataAddPerson = null,
        $DataRemovePerson = null,
        TblGroup $tblFilterGroup = null,
              Severity: Minor
              Found in Application/People/Group/Service.php - About 45 mins to fix

                Function getGroupAllSortedByPerson has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getGroupAllSortedByPerson(TblPerson $tblPerson)
    {
        $lockedList = array();
        $customList = array();
        $tblGroupAll = $this->getGroupAllByPerson($tblPerson);
                Severity: Minor
                Found in Application/People/Group/Service.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getGroupAllSorted has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getGroupAllSorted()
    {

        $lockedList = array();
        $customList = array();
                Severity: Minor
                Found in Application/People/Group/Service.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addGroupPersonList has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function addGroupPersonList(TblGroup $tblGroup, $tblPersonList)
    {

        $result = (new Data($this->getBinding()))->addGroupPersonList($tblGroup, $tblPersonList);
        if($tblGroup->getMetaTable() == TblGroup::META_TABLE_STUDENT){
                Severity: Minor
                Found in Application/People/Group/Service.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function updateGroup(IFormInterface $Form = null, TblGroup $tblGroup, $Group)
    {

        /**
         * Skip to Frontend
                Severity: Major
                Found in Application/People/Group/Service.php and 1 other location - About 1 day to fix
                Application/Corporation/Group/Service.php on lines 186..223

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 281.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function createGroup(IFormInterface $Form = null, $Group)
    {

        /**
         * Skip to Frontend
                Severity: Major
                Found in Application/People/Group/Service.php and 1 other location - About 1 day to fix
                Application/Corporation/Group/Service.php on lines 108..144

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 250.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getGroupAllSorted()
    {

        $lockedList = array();
        $customList = array();
                Severity: Major
                Found in Application/People/Group/Service.php and 1 other location - About 3 hrs to fix
                Application/Corporation/Group/Service.php on lines 69..89

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 145.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status