Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Meta/Common/Service/Setup.php

Summary

Maintainability
D
2 days
Test Coverage

Function setupDatabaseSchema has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function setupDatabaseSchema($Simulate = true, $UTF8 = false)
    {

        /**
         * Table
Severity: Minor
Found in Application/People/Meta/Common/Service/Setup.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setupDatabaseSchema has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setupDatabaseSchema($Simulate = true, $UTF8 = false)
    {

        /**
         * Table
Severity: Minor
Found in Application/People/Meta/Common/Service/Setup.php - About 1 hr to fix

    Function setTableCommonBirthDates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function setTableCommonBirthDates(Schema &$Schema, Table $tblCommonGender)
    {

        $Table = $this->createTable($Schema, 'tblCommonBirthDates');
        $this->createColumn( $Table, 'Birthday', self::FIELD_TYPE_DATETIME, true );
    Severity: Minor
    Found in Application/People/Meta/Common/Service/Setup.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private function setTableCommon(Schema &$Schema, Table $tblCommonBirthDates, Table $tblCommonInformation)
    {

        $Table = $this->getConnection()->createTable($Schema, 'tblCommon');
        if (!$this->getConnection()->hasColumn('tblCommon', 'serviceTblPerson')) {
    Severity: Major
    Found in Application/People/Meta/Common/Service/Setup.php and 1 other location - About 6 hrs to fix
    Application/People/Meta/Prospect/Service/Setup.php on lines 107..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 218.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        private function setTableCommonInformation(Schema &$Schema)
    {

        $Table = $this->getConnection()->createTable($Schema, 'tblCommonInformation');
        if (!$this->getConnection()->hasColumn('tblCommonInformation', 'Nationality')) {
    Severity: Major
    Found in Application/People/Meta/Common/Service/Setup.php and 4 other locations - About 3 hrs to fix
    Application/Document/Storage/Service/Setup.php on lines 52..69
    Application/Education/Lesson/Subject/Service/Setup.php on lines 56..73
    Application/Education/Lesson/Subject/Service/Setup.php on lines 80..97
    Application/People/Meta/Student/Service/Setup.php on lines 211..228

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            $this->getConnection()->createView(
            (new View($this->getConnection(), 'viewPeopleMetaCommon'))
                ->addLink(new TblCommon(), 'tblCommonBirthDates', new TblCommonBirthDates(), 'Id', View::JOIN_LEFT)
                ->addLink(new TblCommonBirthDates(), 'tblCommonGender', new TblCommonGender(), 'Id', View::JOIN_LEFT)
                ->addLink(new TblCommon(), 'tblCommonInformation', new TblCommonInformation(), 'Id', View::JOIN_LEFT)
    Severity: Major
    Found in Application/People/Meta/Common/Service/Setup.php and 3 other locations - About 1 hr to fix
    Application/People/Meta/Student/Service/Setup.php on lines 111..116
    Application/People/Meta/Student/Service/Setup.php on lines 140..145
    Application/People/Meta/Student/Service/Setup.php on lines 154..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status