Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Meta/Student/Service/Data.php

Summary

Maintainability
F
4 days
Test Coverage

File Data.php has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\People\Meta\Student\Service;

use SPHERE\Application\People\Meta\Student\Service\Data\Support;
use SPHERE\Application\People\Meta\Student\Service\Entity\TblStudent;
Severity: Minor
Found in Application/People/Meta/Student/Service/Data.php - About 7 hrs to fix

    Method setupDatabaseContent has 165 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function setupDatabaseContent()
    {

        $tblStudentAgreementCategory = $this->createStudentAgreementCategory(
            'Foto des Schülers',
    Severity: Major
    Found in Application/People/Meta/Student/Service/Data.php - About 6 hrs to fix

      Function setupDatabaseContent has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setupDatabaseContent()
    {

        $tblStudentAgreementCategory = $this->createStudentAgreementCategory(
            'Foto des Schülers',
      Severity: Minor
      Found in Application/People/Meta/Student/Service/Data.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Data has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Data extends Support
{

    /**
     * @return false|ViewStudent[]
      Severity: Minor
      Found in Application/People/Meta/Student/Service/Data.php - About 3 hrs to fix

        Method updateStudentMedicalRecord has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TblStudentMedicalRecord $tblStudentMedicalRecord,
        $Disease,
        $Medication,
        $AttendingDoctor,
        $InsuranceState,
        Severity: Minor
        Found in Application/People/Meta/Student/Service/Data.php - About 45 mins to fix

          Method createStudentMedicalRecord has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $Disease,
        $Medication,
        $AttendingDoctor,
        $InsuranceState,
        $Insurance
          Severity: Minor
          Found in Application/People/Meta/Student/Service/Data.php - About 35 mins to fix

            Method updateStudentTransport has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    TblStudentTransport $tblStudentTransport,
        $Route,
        $StationEntrance,
        $StationExit,
        $Remark
            Severity: Minor
            Found in Application/People/Meta/Student/Service/Data.php - About 35 mins to fix

              Function bulkSaveEntityList has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function bulkSaveEntityList($EntityList = array(), $ProtocolList = array())
    {

        $Manager = $this->getConnection()->getEntityManager();
        if (!empty($EntityList)) {
              Severity: Minor
              Found in Application/People/Meta/Student/Service/Data.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function updateStudentTransport(
        TblStudentTransport $tblStudentTransport,
        $Route,
        $StationEntrance,
        $StationExit,
              Severity: Major
              Found in Application/People/Meta/Student/Service/Data.php and 1 other location - About 4 hrs to fix
              Application/People/Meta/Common/Service/Data.php on lines 275..297

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  public function updateStudentLocker(
        TblStudentLocker $tblStudentLocker,
        $LockerNumber,
        $LockerLocation,
        $KeyNumber
              Severity: Major
              Found in Application/People/Meta/Student/Service/Data.php and 3 other locations - About 3 hrs to fix
              Application/Corporation/Group/Service/Data.php on lines 88..104
              Application/People/Group/Service/Data.php on lines 94..110
              Application/People/Meta/Custody/Service/Data.php on lines 70..90

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 149.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function createStudentTransport(
        $Route,
        $StationEntrance,
        $StationExit,
        $Remark
              Severity: Major
              Found in Application/People/Meta/Student/Service/Data.php and 1 other location - About 1 hr to fix
              Application/People/Meta/Common/Service/Data.php on lines 112..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 114.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  public function createStudentMedicalRecord(
        $Disease,
        $Medication,
        $AttendingDoctor,
        $InsuranceState,
              Severity: Major
              Found in Application/People/Meta/Student/Service/Data.php and 4 other locations - About 1 hr to fix
              Application/Billing/Accounting/Account/Service/Data.php on lines 206..225
              Application/People/Meta/Student/Service/Data/Support.php on lines 166..185
              Application/Reporting/Individual/Service/Data.php on lines 249..261
              Application/Reporting/Individual/Service/Data.php on lines 272..284

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status