DerDu/SPHERE-Framework

View on GitHub
Application/People/Meta/Student/Service/Data/Integration.php

Summary

Maintainability
D
2 days
Test Coverage

Integration has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Integration extends Subject
{

    /**
     * @param string $Name
Severity: Minor
Found in Application/People/Meta/Student/Service/Data/Integration.php - About 2 hrs to fix

    File Integration.php has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    namespace SPHERE\Application\People\Meta\Student\Service\Data;
    
    use SPHERE\Application\Corporation\Company\Service\Entity\TblCompany;
    use SPHERE\Application\People\Meta\Student\Service\Entity\TblStudent;
    Severity: Minor
    Found in Application/People/Meta/Student/Service/Data/Integration.php - About 2 hrs to fix

      Method updateStudentIntegration has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TblStudentIntegration $tblStudentIntegration,
              TblPerson $tblPerson = null,
              TblCompany $tblCompany = null,
              $CoachingRequestDate,
              $CoachingCounselDate,
      Severity: Major
      Found in Application/People/Meta/Student/Service/Data/Integration.php - About 1 hr to fix

        Method createStudentIntegration has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TblPerson $tblPerson = null,
                TblCompany $tblCompany = null,
                $CoachingRequestDate,
                $CoachingCounselDate,
                $CoachingDecisionDate,
        Severity: Major
        Found in Application/People/Meta/Student/Service/Data/Integration.php - About 1 hr to fix

          Similar blocks of code found in 23 locations. Consider refactoring.
          Open

              public function addStudentDisorder(
                  TblStudent $tblStudent,
                  TblStudentDisorderType $tblStudentDisorderType
              ) {
          
          
          Application/Billing/Bookkeeping/Basket/Service/Data.php on lines 459..480
          Application/Billing/Inventory/Document/Service/Data.php on lines 166..184
          Application/Billing/Inventory/Item/Service/Data.php on lines 569..593
          Application/Corporation/Group/Service/Data.php on lines 286..303
          Application/Education/Certificate/Generator/Service/Data.php on lines 4382..4404
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 496..519
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 595..618
          Application/Education/Lesson/Division/Service/Data.php on lines 1095..1112
          Application/Education/Lesson/Division/Service/Data.php on lines 1120..1138
          Application/Education/Lesson/Subject/Service/Data.php on lines 221..238
          Application/Education/Lesson/Subject/Service/Data.php on lines 272..289
          Application/Education/Lesson/Term/Service/Data.php on lines 234..251
          Application/People/Group/Service/Data.php on lines 365..382
          Application/People/Meta/Student/Service/Data/Agreement.php on lines 182..205
          Application/People/Meta/Student/Service/Data/Liberation.php on lines 165..188
          Application/Platform/Gatekeeper/Authorization/Access/Service/Data.php on lines 285..302
          Application/Platform/Gatekeeper/Authorization/Access/Service/Data.php on lines 328..345
          Application/Platform/Gatekeeper/Authorization/Access/Service/Data.php on lines 371..388
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 294..311
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 319..336
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 1132..1149
          Application/Reporting/SerialLetter/Service/Data.php on lines 472..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 148.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 9 locations. Consider refactoring.
          Open

              public function createStudentFocusType($Name, $Description = '')
              {
          
                  $Manager = $this->getConnection()->getEntityManager();
                  $Entity = $Manager->getEntity('TblStudentFocusType')->findOneBy(array(
          Application/Education/School/Course/Service/Data.php on lines 30..46
          Application/Education/School/Type/Service/Data.php on lines 36..52
          Application/People/Meta/Student/Service/Data/Agreement.php on lines 24..39
          Application/People/Meta/Student/Service/Data/Integration.php on lines 51..66
          Application/People/Meta/Student/Service/Data/Liberation.php on lines 24..39
          Application/People/Meta/Student/Service/Data/Support.php on lines 29..44
          Application/People/Meta/Student/Service/Data/Support.php on lines 52..67
          Application/Reporting/CheckList/Service/Data.php on lines 508..530

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 9 locations. Consider refactoring.
          Open

              public function createStudentDisorderType($Name, $Description = '')
              {
          
                  $Manager = $this->getConnection()->getEntityManager();
                  $Entity = $Manager->getEntity('TblStudentDisorderType')->findOneBy(array(
          Application/Education/School/Course/Service/Data.php on lines 30..46
          Application/Education/School/Type/Service/Data.php on lines 36..52
          Application/People/Meta/Student/Service/Data/Agreement.php on lines 24..39
          Application/People/Meta/Student/Service/Data/Integration.php on lines 28..43
          Application/People/Meta/Student/Service/Data/Liberation.php on lines 24..39
          Application/People/Meta/Student/Service/Data/Support.php on lines 29..44
          Application/People/Meta/Student/Service/Data/Support.php on lines 52..67
          Application/Reporting/CheckList/Service/Data.php on lines 508..530

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 57 locations. Consider refactoring.
          Open

              public function removeStudentFocus(TblStudentFocus $tblStudentFocus)
              {
          
                  $Manager = $this->getConnection()->getEntityManager();
                  /** @var TblStudentFocus $Entity */
          Severity: Major
          Found in Application/People/Meta/Student/Service/Data/Integration.php and 56 other locations - About 55 mins to fix
          Application/Billing/Accounting/Creditor/Service/Data.php on lines 136..149
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 665..678
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 685..698
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 705..718
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 725..738
          Application/Billing/Inventory/Document/Service/Data.php on lines 216..230
          Application/Billing/Inventory/Item/Service/Data.php on lines 600..614
          Application/Billing/Inventory/Item/Service/Data.php on lines 621..634
          Application/Billing/Inventory/Item/Service/Data.php on lines 641..654
          Application/Billing/Inventory/Item/Service/Data.php on lines 661..674
          Application/Contact/Address/Service/Data.php on lines 789..801
          Application/Contact/Mail/Service/Data.php on lines 255..267
          Application/Contact/Phone/Service/Data.php on lines 257..269
          Application/Contact/Web/Service/Data.php on lines 223..235
          Application/Corporation/Company/Service/Data.php on lines 230..243
          Application/Corporation/Group/Service/Data.php on lines 334..346
          Application/Corporation/Group/Service/Data.php on lines 353..365
          Application/Corporation/Group/Service/Data.php on lines 372..384
          Application/Education/Certificate/Generator/Service/Data.php on lines 3924..3936
          Application/Education/Graduation/Gradebook/MinimumGradeCount/Data.php on lines 257..270
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 659..671
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 678..690
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 697..709
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 716..728
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 735..747
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 1097..1112
          Application/Education/Graduation/Gradebook/Service/Data.php on lines 230..243
          Application/Education/Graduation/Gradebook/Service/Data.php on lines 618..631
          Application/Education/Lesson/Division/Service/Data.php on lines 1641..1654
          Application/Education/Lesson/Term/Service/Data.php on lines 893..908
          Application/People/Group/Service/Data.php on lines 452..464
          Application/People/Group/Service/Data.php on lines 471..483
          Application/People/Meta/Student/Service/Data/Agreement.php on lines 212..224
          Application/People/Meta/Student/Service/Data/Integration.php on lines 351..363
          Application/People/Meta/Student/Service/Data/Liberation.php on lines 195..207
          Application/People/Meta/Student/Service/Data/Student.php on lines 404..416
          Application/People/Meta/Student/Service/Data/Subject.php on lines 240..254
          Application/People/Meta/Student/Service/Data/Support.php on lines 694..706
          Application/People/Meta/Student/Service/Data/Support.php on lines 713..725
          Application/People/Meta/Student/Service/Data/Support.php on lines 732..744
          Application/People/Meta/Student/Service/Data/Support.php on lines 751..763
          Application/People/Meta/Student/Service/Data/Support.php on lines 770..782
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 158..170
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 463..475
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 697..709
          Application/Platform/System/Test/Service/Data.php on lines 65..80
          Application/Reporting/CheckList/Service/Data.php on lines 676..688
          Application/Reporting/Individual/Service/Data.php on lines 341..353
          Application/Reporting/Individual/Service/Data.php on lines 360..372
          Application/Reporting/Individual/Service/Data.php on lines 379..391
          Application/Reporting/SerialLetter/Service/Data.php on lines 887..900
          Application/Reporting/SerialLetter/Service/Data.php on lines 907..920
          Application/Setting/Consumer/Responsibility/Service/Data.php on lines 113..127
          Application/Setting/Consumer/School/Service/Data.php on lines 142..156
          Application/Setting/Consumer/SponsorAssociation/Service/Data.php on lines 72..86
          Application/Setting/User/Account/Service/Data.php on lines 277..289

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 57 locations. Consider refactoring.
          Open

              public function removeStudentDisorder(TblStudentDisorder $tblStudentDisorder)
              {
          
                  $Manager = $this->getConnection()->getEntityManager();
                  /** @var TblStudentDisorder $Entity */
          Severity: Major
          Found in Application/People/Meta/Student/Service/Data/Integration.php and 56 other locations - About 55 mins to fix
          Application/Billing/Accounting/Creditor/Service/Data.php on lines 136..149
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 665..678
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 685..698
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 705..718
          Application/Billing/Accounting/Debtor/Service/Data.php on lines 725..738
          Application/Billing/Inventory/Document/Service/Data.php on lines 216..230
          Application/Billing/Inventory/Item/Service/Data.php on lines 600..614
          Application/Billing/Inventory/Item/Service/Data.php on lines 621..634
          Application/Billing/Inventory/Item/Service/Data.php on lines 641..654
          Application/Billing/Inventory/Item/Service/Data.php on lines 661..674
          Application/Contact/Address/Service/Data.php on lines 789..801
          Application/Contact/Mail/Service/Data.php on lines 255..267
          Application/Contact/Phone/Service/Data.php on lines 257..269
          Application/Contact/Web/Service/Data.php on lines 223..235
          Application/Corporation/Company/Service/Data.php on lines 230..243
          Application/Corporation/Group/Service/Data.php on lines 334..346
          Application/Corporation/Group/Service/Data.php on lines 353..365
          Application/Corporation/Group/Service/Data.php on lines 372..384
          Application/Education/Certificate/Generator/Service/Data.php on lines 3924..3936
          Application/Education/Graduation/Gradebook/MinimumGradeCount/Data.php on lines 257..270
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 659..671
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 678..690
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 697..709
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 716..728
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 735..747
          Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 1097..1112
          Application/Education/Graduation/Gradebook/Service/Data.php on lines 230..243
          Application/Education/Graduation/Gradebook/Service/Data.php on lines 618..631
          Application/Education/Lesson/Division/Service/Data.php on lines 1641..1654
          Application/Education/Lesson/Term/Service/Data.php on lines 893..908
          Application/People/Group/Service/Data.php on lines 452..464
          Application/People/Group/Service/Data.php on lines 471..483
          Application/People/Meta/Student/Service/Data/Agreement.php on lines 212..224
          Application/People/Meta/Student/Service/Data/Integration.php on lines 409..421
          Application/People/Meta/Student/Service/Data/Liberation.php on lines 195..207
          Application/People/Meta/Student/Service/Data/Student.php on lines 404..416
          Application/People/Meta/Student/Service/Data/Subject.php on lines 240..254
          Application/People/Meta/Student/Service/Data/Support.php on lines 694..706
          Application/People/Meta/Student/Service/Data/Support.php on lines 713..725
          Application/People/Meta/Student/Service/Data/Support.php on lines 732..744
          Application/People/Meta/Student/Service/Data/Support.php on lines 751..763
          Application/People/Meta/Student/Service/Data/Support.php on lines 770..782
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 158..170
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 463..475
          Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 697..709
          Application/Platform/System/Test/Service/Data.php on lines 65..80
          Application/Reporting/CheckList/Service/Data.php on lines 676..688
          Application/Reporting/Individual/Service/Data.php on lines 341..353
          Application/Reporting/Individual/Service/Data.php on lines 360..372
          Application/Reporting/Individual/Service/Data.php on lines 379..391
          Application/Reporting/SerialLetter/Service/Data.php on lines 887..900
          Application/Reporting/SerialLetter/Service/Data.php on lines 907..920
          Application/Setting/Consumer/Responsibility/Service/Data.php on lines 113..127
          Application/Setting/Consumer/School/Service/Data.php on lines 142..156
          Application/Setting/Consumer/SponsorAssociation/Service/Data.php on lines 72..86
          Application/Setting/User/Account/Service/Data.php on lines 277..289

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status