File Support.php
has 630 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace SPHERE\Application\People\Meta\Student\Service\Service;
use SPHERE\Application\People\Meta\Student\Service\Data;
use SPHERE\Application\People\Meta\Student\Service\Entity\TblHandyCap;
Support
has 48 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class Support extends Integration
{
/**
* @param $Id
Function updateSpecial
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
public function updateSpecial($PersonId, $SpecialId, $Data = array())
{
$tblSpecial = Student::useService()->getSpecialById($SpecialId);
$tblPerson = Person::useService()->getPersonById($PersonId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSupportByPersonNewest
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
public function getSupportByPersonNewest(TblPerson $tblPerson, $Type = array())
{
$tblSupportMatch = false;
if(($tblSupportList = $this->getSupportByPerson($tblPerson))){
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateSupport
has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring. Open
public function updateSupport($PersonId, $SupportId, $Data = array())
{
$tblSupport = Student::useService()->getSupportById($SupportId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createSpecial
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function createSpecial($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
$tblAccount = Account::useService()->getAccountBySession();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createSupport
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function createSupport($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSupportForReportingByPerson
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function getSupportForReportingByPerson(TblPerson $tblPerson)
{
$tblSupport = false;
if (($tblSupportType = Student::useService()->getSupportTypeByName('Förderbescheid'))
&& ($tblSupportList = Student::useService()->getSupportAllByPersonAndSupportType($tblPerson, $tblSupportType))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method updateSupport
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateSupport($PersonId, $SupportId, $Data = array())
{
$tblSupport = Student::useService()->getSupportById($SupportId);
Function updateHandyCap
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function updateHandyCap($PersonId, $HandyCapId, $Data = array())
{
$tblHandyCap = Student::useService()->getHandyCapById($HandyCapId);
$tblPerson = Person::useService()->getPersonById($PersonId);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createHandyCap
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function createHandyCap($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
$tblAccount = Account::useService()->getAccountBySession();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method updateSpecial
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateSpecial($PersonId, $SpecialId, $Data = array())
{
$tblSpecial = Student::useService()->getSpecialById($SpecialId);
$tblPerson = Person::useService()->getPersonById($PersonId);
Method createSupport
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createSupport($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
Method createSpecial
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createSpecial($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
$tblAccount = Account::useService()->getAccountBySession();
Method updateHandyCap
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function updateHandyCap($PersonId, $HandyCapId, $Data = array())
{
$tblHandyCap = Student::useService()->getHandyCapById($HandyCapId);
$tblPerson = Person::useService()->getPersonById($PersonId);
Method createHandyCap
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function createHandyCap($PersonId, $Data = array())
{
$tblPerson = Person::useService()->getPersonById($PersonId);
$tblAccount = Account::useService()->getAccountBySession();
Method getSupportForReportingByPerson
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getSupportForReportingByPerson(TblPerson $tblPerson)
{
$tblSupport = false;
if (($tblSupportType = Student::useService()->getSupportTypeByName('Förderbescheid'))
&& ($tblSupportList = Student::useService()->getSupportAllByPersonAndSupportType($tblPerson, $tblSupportType))
Method importSupport
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public function importSupport(TblPerson $tblPerson,
TblSupportType $tblSupportType,
$Date = '',
$Company = '',
$PersonSupport = '',
Consider simplifying this complex logical expression. Open
if (isset($Data['PrimaryFocus'])
&& isset($Data['SupportType'])
&& ($tblSupportType = Student::useService()->getSupportTypeById($Data['SupportType']))
&& ($tblSupportType->getName() == 'Förderantrag' || $tblSupportType->getName() == 'Förderbescheid')
&& !($tblPrimaryFocusType = Student::useService()->getSupportFocusTypeById($Data['PrimaryFocus']))
Function deleteSupport
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function deleteSupport(TblSupport $tblSupport)
{
$IsRemove = true;
if(($tblSupportFocusList = $this->getSupportFocusListBySupport($tblSupport))){
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function deleteSpecial
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function deleteSpecial(TblSpecial $tblSpecial)
{
$IsRemove = true;
if(($tblSpecialDisorderList = $this->getSpecialDisorderAllBySpecial($tblSpecial))){
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkInputSupport
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function checkInputSupport($PersonId, $Data, $SupportId = null)
{
$Error = false;
$form = Student::useFrontend()->formSupport($PersonId, $SupportId);
if (isset($Data['Date']) && empty($Data['Date'])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getPrimaryFocusBySupport
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getPrimaryFocusBySupport(TblSupport $tblSupport)
{
$FocusList = false;
$tblSupportFocusList = (new Data($this->getBinding()))->getSupportFocusBySupport($tblSupport);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getIsSupportByPerson
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getIsSupportByPerson(TblPerson $tblPerson)
{
$return = false;
$tblSupport = Student::useService()->getSupportByPersonNewest($tblPerson, array('Förderbescheid'));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSpecialDisorderTypeAllBySpecial
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getSpecialDisorderTypeAllBySpecial(TblSpecial $tblSpecial)
{
$tblSpecialDisorderTypeList = array();
$tblSpecialDisorderList = (new Data($this->getBinding()))->getSpecialDisorderBySpecial($tblSpecial);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function deleteSupport(TblSupport $tblSupport)
{
$IsRemove = true;
if(($tblSupportFocusList = $this->getSupportFocusListBySupport($tblSupport))){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 101.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function deleteSpecial(TblSpecial $tblSpecial)
{
$IsRemove = true;
if(($tblSpecialDisorderList = $this->getSpecialDisorderAllBySpecial($tblSpecial))){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 101.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 4 locations. Consider refactoring. Open
if($tblAccount){
$tblPersonList = Account::useService()->getPersonAllByAccount($tblAccount);
if($tblPersonList){
$tblPersonEditor = $tblPersonList[0];
if($tblPersonEditor){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 4 locations. Consider refactoring. Open
if($tblAccount){
$tblPersonList = Account::useService()->getPersonAllByAccount($tblAccount);
if($tblPersonList){
$tblPersonEditor = $tblPersonList[0];
if($tblPersonEditor){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 4 locations. Consider refactoring. Open
if($tblAccount){
$tblPersonList = Account::useService()->getPersonAllByAccount($tblAccount);
if($tblPersonList){
$tblPersonEditor = $tblPersonList[0];
if($tblPersonEditor){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 4 locations. Consider refactoring. Open
if($tblAccount){
$tblPersonList = Account::useService()->getPersonAllByAccount($tblAccount);
if($tblPersonList){
$tblPersonEditor = $tblPersonList[0];
if($tblPersonEditor){
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76