Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Person/Frontend/FrontendBasic.php

Summary

Maintainability
D
3 days
Test Coverage

Function loadSimilarPersonContent has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadSimilarPersonContent($Person)
    {
        if ((!isset($Person['FirstName']) || empty($Person['FirstName']))
            || (!isset($Person['LastName']) || empty($Person['LastName']))
        ) {
Severity: Minor
Found in Application/People/Person/Frontend/FrontendBasic.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FrontendBasic.php has 357 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 11.12.2018
Severity: Minor
Found in Application/People/Person/Frontend/FrontendBasic.php - About 4 hrs to fix

    Method loadSimilarPersonContent has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadSimilarPersonContent($Person)
    {
        if ((!isset($Person['FirstName']) || empty($Person['FirstName']))
            || (!isset($Person['LastName']) || empty($Person['LastName']))
        ) {
    Severity: Major
    Found in Application/People/Person/Frontend/FrontendBasic.php - About 2 hrs to fix

      Method getBasicFormRow has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getBasicFormRow($isCreate)
    {
        $tblSalutationAll = Person::useService()->getSalutationAll();

        $tblGroupList = Group::useService()->getGroupAllSorted();
      Severity: Major
      Found in Application/People/Person/Frontend/FrontendBasic.php - About 2 hrs to fix

        Method getBasicContent has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function getBasicContent($PersonId = null)
    {
        if (($tblPerson = Person::useService()->getPersonById($PersonId, true))) {
            $groups = array();
            if (($tblGroupList = Group::useService()->getGroupAllSortedByPerson($tblPerson))) {
        Severity: Minor
        Found in Application/People/Person/Frontend/FrontendBasic.php - About 1 hr to fix

          Function getEditBasicContent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getEditBasicContent($PersonId = null)
    {

        $tblPerson = false;
        if ($PersonId && ($tblPerson = Person::useService()->getPersonById($PersonId))) {
          Severity: Minor
          Found in Application/People/Person/Frontend/FrontendBasic.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                          if ($tblCommonBirthDates) {
                                    if ($tblCommonBirthDates->getBirthday() != '') {
                                        $BirthDay = $tblCommonBirthDates->getBirthday();
                                    }
                                }
          Severity: Major
          Found in Application/People/Person/Frontend/FrontendBasic.php - About 45 mins to fix

            Function getBasicContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function getBasicContent($PersonId = null)
    {
        if (($tblPerson = Person::useService()->getPersonById($PersonId, true))) {
            $groups = array();
            if (($tblGroupList = Group::useService()->getGroupAllSortedByPerson($tblPerson))) {
            Severity: Minor
            Found in Application/People/Person/Frontend/FrontendBasic.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 13 locations. Consider refactoring.
            Open

                            new FormRow(array(
                    new FormColumn(array(
                        (new Primary('Speichern', ApiPersonEdit::getEndpoint(), new Save()))
                            ->ajaxPipelineOnClick(ApiPersonEdit::pipelineSaveBasicContent($tblPerson ? $tblPerson->getId() : 0)),
                        (new Primary('Abbrechen', ApiPersonEdit::getEndpoint(), new Disable()))
            Severity: Major
            Found in Application/People/Person/Frontend/FrontendBasic.php and 12 other locations - About 1 hr to fix
            Application/Corporation/Company/FrontendReadOnly.php on lines 401..408
            Application/People/Person/Frontend/FrontendClub.php on lines 174..181
            Application/People/Person/Frontend/FrontendCommon.php on lines 220..227
            Application/People/Person/Frontend/FrontendCustody.php on lines 163..170
            Application/People/Person/Frontend/FrontendProspect.php on lines 254..261
            Application/People/Person/Frontend/FrontendStudent.php on lines 388..395
            Application/People/Person/Frontend/FrontendStudentGeneral.php on lines 417..424
            Application/People/Person/Frontend/FrontendStudentMedicalRecord.php on lines 177..184
            Application/People/Person/Frontend/FrontendStudentProcess.php on lines 419..426
            Application/People/Person/Frontend/FrontendStudentSubject.php on lines 319..326
            Application/People/Person/Frontend/FrontendStudentTransfer.php on lines 883..890
            Application/People/Person/Frontend/FrontendTeacher.php on lines 139..146

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                case 'COMMON':
                        $Global = $this->getGlobal();
                        $Global->POST['Person']['Group'][$tblGroup->getId()] = $tblGroup->getId();
                        $Global->savePost();
                        $tblGroup = new RadioBox(
            Severity: Major
            Found in Application/People/Person/Frontend/FrontendBasic.php and 1 other location - About 1 hr to fix
            Application/Corporation/Company/FrontendReadOnly.php on lines 356..365

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private function getEditBasicTitle(TblPerson $tblPerson = null, $isCreatePerson = false)
    {
        return new Title(new PersonParent() . ' ' . self::TITLE, 'der Person '
            . ($tblPerson ? new Bold(new Success($tblPerson->getFullName())) : '')
            . ($isCreatePerson ? ' anlegen' : ' bearbeiten'));
            Severity: Minor
            Found in Application/People/Person/Frontend/FrontendBasic.php and 1 other location - About 30 mins to fix
            Application/Corporation/Company/FrontendReadOnly.php on lines 332..337

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status