Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Person/Frontend/FrontendStudentGeneral.php

Summary

Maintainability
F
3 days
Test Coverage

Method getStudentGeneralContent has 161 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getStudentGeneralContent($PersonId = null)
    {

        if (($tblPerson = Person::useService()->getPersonById($PersonId))) {
            $billingSiblingRank = '';
Severity: Major
Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 6 hrs to fix

    Function getEditStudentGeneralContent has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getEditStudentGeneralContent($PersonId = null)
    {

        $tblPerson = false;
        if ($PersonId && ($tblPerson = Person::useService()->getPersonById($PersonId))) {
    Severity: Minor
    Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File FrontendStudentGeneral.php has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 17.12.2018
    Severity: Minor
    Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 4 hrs to fix

      Method getEditStudentGeneralForm has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getEditStudentGeneralForm(TblPerson $tblPerson = null)
    {

        /**
         * Panel: Agreement
      Severity: Major
      Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 3 hrs to fix

        Function getStudentGeneralContent has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getStudentGeneralContent($PersonId = null)
    {

        if (($tblPerson = Person::useService()->getPersonById($PersonId))) {
            $billingSiblingRank = '';
        Severity: Minor
        Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getEditStudentGeneralContent has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getEditStudentGeneralContent($PersonId = null)
    {

        $tblPerson = false;
        if ($PersonId && ($tblPerson = Person::useService()->getPersonById($PersonId))) {
        Severity: Minor
        Found in Application/People/Person/Frontend/FrontendStudentGeneral.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                      new Layout(new LayoutGroup(array(
                                new LayoutRow(array(
                                    self::getLayoutColumnLabel('Schließfachnummer', 6),
                                    self::getLayoutColumnValue($lockerNumber, 6),
                                )),
          Severity: Major
          Found in Application/People/Person/Frontend/FrontendStudentGeneral.php and 1 other location - About 2 hrs to fix
          Application/People/Person/Frontend/FrontendStudentProcess.php on lines 230..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 127.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

                          new FormRow(array(
                    new FormColumn(array(
                        (new Primary('Speichern', ApiPersonEdit::getEndpoint(), new Save()))
                            ->ajaxPipelineOnClick(ApiPersonEdit::pipelineSaveStudentGeneralContent($tblPerson ? $tblPerson->getId() : 0)),
                        (new Primary('Abbrechen', ApiPersonEdit::getEndpoint(), new Disable()))
          Severity: Major
          Found in Application/People/Person/Frontend/FrontendStudentGeneral.php and 12 other locations - About 1 hr to fix
          Application/Corporation/Company/FrontendReadOnly.php on lines 401..408
          Application/People/Person/Frontend/FrontendBasic.php on lines 328..335
          Application/People/Person/Frontend/FrontendClub.php on lines 174..181
          Application/People/Person/Frontend/FrontendCommon.php on lines 220..227
          Application/People/Person/Frontend/FrontendCustody.php on lines 163..170
          Application/People/Person/Frontend/FrontendProspect.php on lines 254..261
          Application/People/Person/Frontend/FrontendStudent.php on lines 388..395
          Application/People/Person/Frontend/FrontendStudentMedicalRecord.php on lines 177..184
          Application/People/Person/Frontend/FrontendStudentProcess.php on lines 419..426
          Application/People/Person/Frontend/FrontendStudentSubject.php on lines 319..326
          Application/People/Person/Frontend/FrontendStudentTransfer.php on lines 883..890
          Application/People/Person/Frontend/FrontendTeacher.php on lines 139..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 114.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status