Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Person/Frontend/FrontendStudentMedicalRecord.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getStudentMedicalRecordContent has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getStudentMedicalRecordContent($PersonId = null)
    {

        if (($tblPerson = Person::useService()->getPersonById($PersonId))) {
            if (($tblStudent = Student::useService()->getStudentByPerson($tblPerson))
Severity: Minor
Found in Application/People/Person/Frontend/FrontendStudentMedicalRecord.php - About 1 hr to fix

    Method getEditStudentMedicalRecordForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getEditStudentMedicalRecordForm(TblPerson $tblPerson = null)
    {

        return (new Form(array(
            new FormGroup(array(
    Severity: Minor
    Found in Application/People/Person/Frontend/FrontendStudentMedicalRecord.php - About 1 hr to fix

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

                      new FormRow(array(
                    new FormColumn(array(
                        (new Primary('Speichern', ApiPersonEdit::getEndpoint(), new Save()))
                            ->ajaxPipelineOnClick(ApiPersonEdit::pipelineSaveStudentMedicalRecordContent($tblPerson ? $tblPerson->getId() : 0)),
                        (new Primary('Abbrechen', ApiPersonEdit::getEndpoint(), new Disable()))
      Severity: Major
      Found in Application/People/Person/Frontend/FrontendStudentMedicalRecord.php and 12 other locations - About 1 hr to fix
      Application/Corporation/Company/FrontendReadOnly.php on lines 401..408
      Application/People/Person/Frontend/FrontendBasic.php on lines 328..335
      Application/People/Person/Frontend/FrontendClub.php on lines 174..181
      Application/People/Person/Frontend/FrontendCommon.php on lines 220..227
      Application/People/Person/Frontend/FrontendCustody.php on lines 163..170
      Application/People/Person/Frontend/FrontendProspect.php on lines 254..261
      Application/People/Person/Frontend/FrontendStudent.php on lines 388..395
      Application/People/Person/Frontend/FrontendStudentGeneral.php on lines 417..424
      Application/People/Person/Frontend/FrontendStudentProcess.php on lines 419..426
      Application/People/Person/Frontend/FrontendStudentSubject.php on lines 319..326
      Application/People/Person/Frontend/FrontendStudentTransfer.php on lines 883..890
      Application/People/Person/Frontend/FrontendTeacher.php on lines 139..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status