Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Relationship/Frontend.php

Summary

Maintainability
F
6 days
Test Coverage

File Frontend.php has 645 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\People\Relationship;

use SPHERE\Application\Api\Contact\ApiRelationshipToCompany;
use SPHERE\Application\Api\Contact\ApiRelationshipToPerson;
Severity: Major
Found in Application/People/Relationship/Frontend.php - About 1 day to fix

    Method formRelationshipToPerson has 156 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formRelationshipToPerson(
        $PersonId,
        $ToPersonId = null,
        $setPost = false,
        $Search = '',
    Severity: Major
    Found in Application/People/Relationship/Frontend.php - About 6 hrs to fix

      Method frontendLayoutPersonNew has 101 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendLayoutPersonNew(TblPerson $tblPerson, $Group = null)
    {

        $tblRelationshipAll = Relationship::useService()->getPersonRelationshipAllByPerson($tblPerson);
      Severity: Major
      Found in Application/People/Relationship/Frontend.php - About 4 hrs to fix

        Method frontendLayoutCompanyNew has 91 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendLayoutCompanyNew(Element $tblEntity)
    {

        if ($tblEntity instanceof TblPerson) {
            $tblRelationshipAll = Relationship::useService()->getCompanyRelationshipAllByPerson($tblEntity);
        Severity: Major
        Found in Application/People/Relationship/Frontend.php - About 3 hrs to fix

          Method formRelationshipToCompany has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function formRelationshipToCompany($PersonId, $ToCompanyId = null, $setPost = false, $Search = '', IMessageInterface $message = null)
    {
        if (!($tblPerson = Person::useService()->getPersonById($PersonId))) {
            return false;
        }
          Severity: Major
          Found in Application/People/Relationship/Frontend.php - About 3 hrs to fix

            Function formRelationshipToPerson has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formRelationshipToPerson(
        $PersonId,
        $ToPersonId = null,
        $setPost = false,
        $Search = '',
            Severity: Minor
            Found in Application/People/Relationship/Frontend.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method loadExtraOptions has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function loadExtraOptions(IMessageInterface $message = null, $Post = null)
    {
        if ($Post) {
            $global = $this->getGlobal();
            $global->POST['Type']['Ranking'] = $Post;
            Severity: Minor
            Found in Application/People/Relationship/Frontend.php - About 1 hr to fix

              Method loadPersonSearch has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function loadPersonSearch($Search, IMessageInterface $message = null, $IsChild = false)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblPersonList = Person::useService()->getPersonListLike($Search))) {
              Severity: Minor
              Found in Application/People/Relationship/Frontend.php - About 1 hr to fix

                Method loadCompanySearch has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function loadCompanySearch($Search, IMessageInterface $message = null)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblCompanyList = Company::useService()->getCompanyListLike($Search))) {
                Severity: Minor
                Found in Application/People/Relationship/Frontend.php - About 1 hr to fix

                  Function loadPersonSearch has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function loadPersonSearch($Search, IMessageInterface $message = null, $IsChild = false)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblPersonList = Person::useService()->getPersonListLike($Search))) {
                  Severity: Minor
                  Found in Application/People/Relationship/Frontend.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function frontendLayoutCompanyNew has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function frontendLayoutCompanyNew(Element $tblEntity)
    {

        if ($tblEntity instanceof TblPerson) {
            $tblRelationshipAll = Relationship::useService()->getCompanyRelationshipAllByPerson($tblEntity);
                  Severity: Minor
                  Found in Application/People/Relationship/Frontend.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function loadCompanySearch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function loadCompanySearch($Search, IMessageInterface $message = null)
    {

        if ($Search != '' && strlen($Search) > 2) {
            if (($tblCompanyList = Company::useService()->getCompanyListLike($Search))) {
                  Severity: Minor
                  Found in Application/People/Relationship/Frontend.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method formRelationshipToPerson has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $PersonId,
        $ToPersonId = null,
        $setPost = false,
        $Search = '',
        IMessageInterface $message = null,
                  Severity: Major
                  Found in Application/People/Relationship/Frontend.php - About 50 mins to fix

                    Function formRelationshipToCompany has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function formRelationshipToCompany($PersonId, $ToCompanyId = null, $setPost = false, $Search = '', IMessageInterface $message = null)
    {
        if (!($tblPerson = Person::useService()->getPersonById($PersonId))) {
            return false;
        }
                    Severity: Minor
                    Found in Application/People/Relationship/Frontend.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method formRelationshipToCompany has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function formRelationshipToCompany($PersonId, $ToCompanyId = null, $setPost = false, $Search = '', IMessageInterface $message = null)
                    Severity: Minor
                    Found in Application/People/Relationship/Frontend.php - About 35 mins to fix

                      Function loadExtraOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function loadExtraOptions(IMessageInterface $message = null, $Post = null)
    {
        if ($Post) {
            $global = $this->getGlobal();
            $global->POST['Type']['Ranking'] = $Post;
                      Severity: Minor
                      Found in Application/People/Relationship/Frontend.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                              $options =
                            (new \SPHERE\Common\Frontend\Link\Repository\Link(
                                new Edit(),
                                ApiRelationshipToCompany::getEndpoint(),
                                null,
                      Severity: Major
                      Found in Application/People/Relationship/Frontend.php and 1 other location - About 2 hrs to fix
                      Application/People/Relationship/Frontend.php on lines 726..747

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 128.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                              $options =
                            (new \SPHERE\Common\Frontend\Link\Repository\Link(
                                new Edit(),
                                ApiRelationshipToPerson::getEndpoint(),
                                null,
                      Severity: Major
                      Found in Application/People/Relationship/Frontend.php and 1 other location - About 2 hrs to fix
                      Application/People/Relationship/Frontend.php on lines 850..871

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 128.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      $result = new TableData(
                    $resultList,
                    null,
                    array(
                        'Select' => '',
                      Severity: Major
                      Found in Application/People/Relationship/Frontend.php and 1 other location - About 1 hr to fix
                      Application/Billing/Bookkeeping/Balance/Frontend.php on lines 605..624

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 103.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status