Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/People/Search/Group/Frontend.php

Summary

Maintainability
D
2 days
Test Coverage

Method frontendSearch has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendSearch($Id = false)
    {

        $Stage = new Stage('Suche', 'nach Gruppe');
        $Stage->addButton(new Standard('Zurück', '/People', new ChevronLeft()));
Severity: Major
Found in Application/People/Search/Group/Frontend.php - About 7 hrs to fix

    Function frontendSearch has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendSearch($Id = false)
    {

        $Stage = new Stage('Suche', 'nach Gruppe');
        $Stage->addButton(new Standard('Zurück', '/People', new ChevronLeft()));
    Severity: Minor
    Found in Application/People/Search/Group/Frontend.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Frontend.php has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace SPHERE\Application\People\Search\Group;

use SPHERE\Application\Api\Education\Division\ValidationFilter;
use SPHERE\Application\Contact\Address\Service\Entity\TblAddress;
    Severity: Minor
    Found in Application/People/Search/Group/Frontend.php - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                                              if ($tblToPerson->getTblType()->getName() == "Sorgeberechtigt"
                                            && ($tblPersonFrom = $tblToPerson->getServiceTblPersonFrom())
                                            && ($tblPersonTo = $tblToPerson->getServiceTblPersonTo())
                                            && $tblPersonFrom->getId() == $tblPerson->getId()
                                        ) {
      Severity: Major
      Found in Application/People/Search/Group/Frontend.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                            if ($tblProspectReservation) {
                                        $level = $tblProspectReservation->getReservationDivision();
                                        $year = $tblProspectReservation->getReservationYear();
                                        $optionA = $tblProspectReservation->getServiceTblTypeOptionA();
                                        $optionB = $tblProspectReservation->getServiceTblTypeOptionB();
        Severity: Major
        Found in Application/People/Search/Group/Frontend.php - About 45 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (!empty($tblGroupAll)) {
            /** @noinspection PhpUnusedParameterInspection */
            array_walk($tblGroupAll, function (TblGroup &$tblGroup) use ($Stage) {

                $Stage->addButton(
          Severity: Major
          Found in Application/People/Search/Group/Frontend.php and 1 other location - About 1 hr to fix
          Application/Corporation/Search/Group/Frontend.php on lines 52..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 115.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              new LayoutRow(new LayoutColumn(
                        new Panel(new PersonGroup() . ' Gruppe', array(
                            new Bold($tblGroup->getName()),
                            ($tblGroup->getDescription() ? new Small($tblGroup->getDescription()) : ''),
                            ($tblGroup->getRemark() ? new Danger(new Italic(nl2br($tblGroup->getRemark()))) : '')
          Severity: Major
          Found in Application/People/Search/Group/Frontend.php and 1 other location - About 1 hr to fix
          Application/Corporation/Search/Group/Frontend.php on lines 108..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                                              if ($tblProspectReservation) {
                                        $level = $tblProspectReservation->getReservationDivision();
                                        $year = $tblProspectReservation->getReservationYear();
                                        $optionA = $tblProspectReservation->getServiceTblTypeOptionA();
                                        $optionB = $tblProspectReservation->getServiceTblTypeOptionB();
          Severity: Major
          Found in Application/People/Search/Group/Frontend.php and 2 other locations - About 1 hr to fix
          Application/Reporting/CheckList/Frontend.php on lines 1498..1510
          Application/Reporting/CheckList/Service.php on lines 1068..1080

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status