DerDu/SPHERE-Framework

View on GitHub
Application/Platform/Gatekeeper/Authorization/Access/Frontend.php

Summary

Maintainability
F
2 wks
Test Coverage

File Frontend.php has 607 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Platform\Gatekeeper\Authorization\Access;

use SPHERE\Application\Platform\Gatekeeper\Authorization\Access\Frontend\Summary;
use SPHERE\Application\Platform\Gatekeeper\Authorization\Access\Service\Entity\TblLevel;
Severity: Major
Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 1 day to fix

    Function frontendWelcome has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendWelcome()
        {
    
            $Stage = new Stage('Rechteverwaltung');
            $this->menuButton($Stage);
    Severity: Minor
    Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method frontendPrivilegeGrantRight has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendPrivilegeGrantRight($Id)
        {
    
            $Stage = new Stage('Berechtigungen', 'Privileg');
            $this->menuButton($Stage);
    Severity: Major
    Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 3 hrs to fix

      Method frontendLevelGrantPrivilege has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendLevelGrantPrivilege($Id)
          {
      
              $Stage = new Stage('Berechtigungen', 'Zugriffslevel');
              $this->menuButton($Stage);
      Severity: Major
      Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 3 hrs to fix

        Method frontendRoleGrantLevel has 91 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendRoleGrantLevel($Id)
            {
        
                $Stage = new Stage('Berechtigungen', 'Rolle');
                $this->menuButton($Stage);
        Severity: Major
        Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 3 hrs to fix

          Method frontendRole has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendRole($Name, $IsSecure = false, $IsIndividual = false)
              {
          
                  $Stage = new Stage('Berechtigungen', 'Rollen');
                  $this->menuButton($Stage);
          Severity: Major
          Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 2 hrs to fix

            Method frontendRight has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendRight($Name = null)
                {
            
                    $Stage = new Stage('Berechtigungen', 'Rechte');
                    $this->menuButton($Stage);
            Severity: Major
            Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 2 hrs to fix

              Method frontendLevel has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendLevel($Name)
                  {
              
                      $Stage = new Stage('Berechtigungen', 'Zugriffslevel');
                      $this->menuButton($Stage);
              Severity: Major
              Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 2 hrs to fix

                Method frontendPrivilege has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function frontendPrivilege($Name)
                    {
                
                        $Stage = new Stage('Berechtigungen', 'Privilegien');
                        $this->menuButton($Stage);
                Severity: Major
                Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 2 hrs to fix

                  Method frontendWelcome has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function frontendWelcome()
                      {
                  
                          $Stage = new Stage('Rechteverwaltung');
                          $this->menuButton($Stage);
                  Severity: Minor
                  Found in Application/Platform/Gatekeeper/Authorization/Access/Frontend.php - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function frontendPrivilegeGrantRight($Id)
                        {
                    
                            $Stage = new Stage('Berechtigungen', 'Privileg');
                            $this->menuButton($Stage);
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 408..510
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 517..621

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 763.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function frontendRoleGrantLevel($Id)
                        {
                    
                            $Stage = new Stage('Berechtigungen', 'Rolle');
                            $this->menuButton($Stage);
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 517..621
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 628..728

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 763.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function frontendLevelGrantPrivilege($Id)
                        {
                    
                            $Stage = new Stage('Berechtigungen', 'Zugriffslevel');
                            $this->menuButton($Stage);
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 408..510
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 628..728

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 763.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($tblLevelAll) {
                                array_walk($tblLevelAll, function (TblLevel &$tblLevel) use (&$levelList) {
                    
                                    $tblPrivilegeList = Access::useService()->getPrivilegeAllByLevel($tblLevel);
                                    if (empty( $tblPrivilegeList )) {
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 194..224

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 260.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($tblPrivilegeAll) {
                                array_walk($tblPrivilegeAll, function (TblPrivilege &$tblPrivilege) use (&$privilegeList) {
                    
                                    $tblRightList = Access::useService()->getRightAllByPrivilege($tblPrivilege);
                                    if (empty( $tblRightList )) {
                    Application/Platform/Gatekeeper/Authorization/Access/Frontend.php on lines 127..158

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 260.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status