Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Platform/System/Archive/Service.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method fixArchive has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function fixArchive($Object)
    {

        if (!is_object($Object) && gettype($Object) == 'object') {
            // preg_replace_callback handler. Needed to calculate new key-length.
Severity: Minor
Found in Application/Platform/System/Archive/Service.php - About 1 hr to fix

    Method createArchiveEntry has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $DatabaseName,
        TblAccount $tblAccount = null,
        TblConsumer $tblConsumer = null,
        Element $Entity = null,
        $Type = TblArchive::ARCHIVE_TYPE_CREATE,
    Severity: Minor
    Found in Application/Platform/System/Archive/Service.php - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!is_object($Object) && gettype($Object) == 'object') {
            // preg_replace_callback handler. Needed to calculate new key-length.
            $Fix = create_function(
                '$matches',
                'return ":" . strlen( $matches[1] ) . ":\"" . $matches[1] . "\"";'
      Severity: Major
      Found in Application/Platform/System/Archive/Service.php and 1 other location - About 2 hrs to fix
      Application/Platform/System/Protocol/Service/Data.php on lines 35..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status