DerDu/SPHERE-Framework

View on GitHub
Application/Platform/System/Database/Database.php

Summary

Maintainability
F
5 days
Test Coverage

File Database.php has 432 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Platform\System\Database;

use SPHERE\Application\IModuleInterface;
use SPHERE\Application\IServiceInterface;
Severity: Minor
Found in Application/Platform/System/Database/Database.php - About 6 hrs to fix

    Method frontendSetup has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendSetup($Simulation = true, $Heal = false)
        {
    
            $ClassList = get_declared_classes();
            self::$ServiceRegister = array_merge(
    Severity: Major
    Found in Application/Platform/System/Database/Database.php - About 4 hrs to fix

      Method frontendSetupUpgrade has 109 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendSetupUpgrade()
          {
      
              $Stage = new Stage('Database', 'Setup aller Mandanten (Struktur)');
              $this->menuButton($Stage);
      Severity: Major
      Found in Application/Platform/System/Database/Database.php - About 4 hrs to fix

        Method frontendStatus has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendStatus()
            {
        
                $Stage = new Stage('Database', 'Status');
                $this->menuButton($Stage);
        Severity: Major
        Found in Application/Platform/System/Database/Database.php - About 2 hrs to fix

          Function frontendStatus has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendStatus()
              {
          
                  $Stage = new Stage('Database', 'Status');
                  $this->menuButton($Stage);
          Severity: Minor
          Found in Application/Platform/System/Database/Database.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method registerModule has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function registerModule()
              {
          
                  /**
                   * Register Navigation
          Severity: Minor
          Found in Application/Platform/System/Database/Database.php - About 1 hr to fix

            Function frontendSetupUpgrade has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendSetupUpgrade()
                {
            
                    $Stage = new Stage('Database', 'Setup aller Mandanten (Struktur)');
                    $this->menuButton($Stage);
            Severity: Minor
            Found in Application/Platform/System/Database/Database.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function frontendSetup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frontendSetup($Simulation = true, $Heal = false)
                {
            
                    $ClassList = get_declared_classes();
                    self::$ServiceRegister = array_merge(
            Severity: Minor
            Found in Application/Platform/System/Database/Database.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        array_walk($ClassList, function (&$Class) {
            
                            $Inspection = new \ReflectionClass($Class);
                            if ($Inspection->isInternal()) {
                                $Class = false;
            Severity: Major
            Found in Application/Platform/System/Database/Database.php and 1 other location - About 1 day to fix
            Application/Platform/System/Database/Database.php on lines 446..474

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 262.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        array_walk($ClassList, function (&$Class) {
            
                            $Inspection = new \ReflectionClass($Class);
                            if ($Inspection->isInternal()) {
                                $Class = false;
            Severity: Major
            Found in Application/Platform/System/Database/Database.php and 1 other location - About 1 day to fix
            Application/Platform/System/Database/Database.php on lines 480..508

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 262.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            try {
                                $Connection = new \SPHERE\System\Database\Database(
                                    new Identifier(
                                        $Service[0],
                                        $Service[1],
            Severity: Major
            Found in Application/Platform/System/Database/Database.php and 1 other location - About 3 hrs to fix
            Application/Platform/System/Database/Database.php on lines 139..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                try {
                                    $Connection = new \SPHERE\System\Database\Database(
                                        new Identifier(
                                            $Service[0],
                                            $Service[1],
            Severity: Major
            Found in Application/Platform/System/Database/Database.php and 1 other location - About 3 hrs to fix
            Application/Platform/System/Database/Database.php on lines 157..170

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status