Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Platform/System/Database/ReportingUpgrade.php

Summary

Maintainability
D
2 days
Test Coverage

Function migrateReporting has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public function migrateReporting()
    {
        // All available Consumer
        try {
            $ConsumerList = $this->getConsumerList();
Severity: Minor
Found in Application/Platform/System/Database/ReportingUpgrade.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method migrateReporting has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function migrateReporting()
    {
        // All available Consumer
        try {
            $ConsumerList = $this->getConsumerList();
Severity: Major
Found in Application/Platform/System/Database/ReportingUpgrade.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                return new Danger('Migration failed on '.$ProtocolError.' Views') . new Listing($ProtocolList);
    Severity: Major
    Found in Application/Platform/System/Database/ReportingUpgrade.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new Success('Migration finished') . new Listing($ProtocolList);
      Severity: Major
      Found in Application/Platform/System/Database/ReportingUpgrade.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return new Danger('Template ' . $File . ' not available!')
                        . (isset($Exception) ? $this->parseException($Exception, 'Template') : '');
        Severity: Major
        Found in Application/Platform/System/Database/ReportingUpgrade.php - About 30 mins to fix

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                  foreach ((array)$Exception->getTrace() as $Trace) {
            $TraceList .= nl2br('<samp class="text-info small">'
                . (isset($Trace['type']) && isset($Trace['function']) ? 'Method: ' . $Trace['type'] . $Trace['function'] : 'Method: ')
                . (isset($Trace['class']) ? '<br/>Class: ' . $Trace['class'] : '<br/>Class: ')
                . (isset($Trace['file']) ? '<br/>File: ' . $Trace['file'] : '<br/>File: ')
          Severity: Major
          Found in Application/Platform/System/Database/ReportingUpgrade.php and 3 other locations - About 3 hrs to fix
          Application/Api/Dispatcher.php on lines 95..105
          Application/Api/Reporting/Individual/ApiIndividual.php on lines 2255..2262
          Common/Window/Display.php on lines 238..245

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 143.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              } else {
                        // View is missing
                        $ProtocolList[] = new FileExtension() . ' Create new ' . $ViewName . ' @ SettingConsumer_' . strtoupper($Acronym) . new Scrollable('<pre><code class="sql">' . $View->getSql() . '</code></pre>', 100);
                        try {
                            $SchemaManager->createView($View);
          Severity: Major
          Found in Application/Platform/System/Database/ReportingUpgrade.php and 1 other location - About 2 hrs to fix
          Application/Platform/System/Database/ReportingUpgrade.php on lines 140..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 124.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (array_key_exists(strtolower($ViewName), $SchemaManager->listViews())) {
                        // View exists
                        $ProtocolList[] = new Task() . ' Update existing ' . $ViewName . ' @ SettingConsumer_' . strtoupper($Acronym) . new Scrollable('<pre><code class="sql">' . $View->getSql() . '</code></pre>', 100);
                        try {
                            $SchemaManager->dropAndCreateView($View);
          Severity: Major
          Found in Application/Platform/System/Database/ReportingUpgrade.php and 1 other location - About 2 hrs to fix
          Application/Platform/System/Database/ReportingUpgrade.php on lines 151..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 124.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              private $TemplateList = array(
        'viewContactAddress' => 'viewContactAddress.twig',
        'viewContactMail' => 'viewContactMail.twig',
        'viewContactPhone' => 'viewContactPhone.twig',
        'viewEducationStudent' => 'viewEducationStudent.twig',
          Severity: Major
          Found in Application/Platform/System/Database/ReportingUpgrade.php and 2 other locations - About 1 hr to fix
          Application/Education/Certificate/Generator/Frontend.php on lines 368..391
          Application/Reporting/Standard/Person/Frontend.php on lines 1078..1100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status