DerDu/SPHERE-Framework

View on GitHub
Application/Reporting/Custom/Herrnhut/Person/Frontend.php

Summary

Maintainability
F
2 wks
Test Coverage

File Frontend.php has 811 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Reporting\Custom\Herrnhut\Person;

use SPHERE\Application\Education\Lesson\Division\Division;
Severity: Major
Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 day to fix

    Method frontendLanguageList has 158 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendLanguageList($DivisionId = null)
        {
            $Stage = new Stage('EZSH Auswertung', 'Klassenliste Fremdsprachen');
            if (null !== $DivisionId) {
                $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/LanguageList', new ChevronLeft()));
    Severity: Major
    Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 6 hrs to fix

      Method frontendClassList has 154 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendClassList($DivisionId = null)
          {
      
              $Stage = new Stage('EZSH Auswertung', 'Klassenliste');
              if (null !== $DivisionId) {
      Severity: Major
      Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 6 hrs to fix

        Method frontendExtendedClassList has 153 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendExtendedClassList($DivisionId = null)
            {
        
                $Stage = new Stage('EZSH Auswertung', 'Erweiterte Klassenliste');
                if (null !== $DivisionId) {
        Severity: Major
        Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 6 hrs to fix

          Method frontendProfileList has 148 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendProfileList($DivisionId = null)
              {
                  $Stage = new Stage('EZSH Auswertung', 'Klassenliste Profile');
                  if (null !== $DivisionId) {
                      $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/ProfileList', new ChevronLeft()));
          Severity: Major
          Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 5 hrs to fix

            Method frontendSignList has 148 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendSignList($DivisionId = null)
                {
                    $Stage = new Stage('EZSH Auswertung', 'Unterschriften Liste');
                    if (null !== $DivisionId) {
                        $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/SignList', new ChevronLeft()));
            Severity: Major
            Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 5 hrs to fix

              Function frontendClassList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendClassList($DivisionId = null)
                  {
              
                      $Stage = new Stage('EZSH Auswertung', 'Klassenliste');
                      if (null !== $DivisionId) {
              Severity: Minor
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function frontendProfileList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendProfileList($DivisionId = null)
                  {
                      $Stage = new Stage('EZSH Auswertung', 'Klassenliste Profile');
                      if (null !== $DivisionId) {
                          $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/ProfileList', new ChevronLeft()));
              Severity: Minor
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function frontendLanguageList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendLanguageList($DivisionId = null)
                  {
                      $Stage = new Stage('EZSH Auswertung', 'Klassenliste Fremdsprachen');
                      if (null !== $DivisionId) {
                          $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/LanguageList', new ChevronLeft()));
              Severity: Minor
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function frontendExtendedClassList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendExtendedClassList($DivisionId = null)
                  {
              
                      $Stage = new Stage('EZSH Auswertung', 'Erweiterte Klassenliste');
                      if (null !== $DivisionId) {
              Severity: Minor
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function frontendSignList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendSignList($DivisionId = null)
                  {
                      $Stage = new Stage('EZSH Auswertung', 'Unterschriften Liste');
                      if (null !== $DivisionId) {
                          $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/SignList', new ChevronLeft()));
              Severity: Minor
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  public function frontendProfileList($DivisionId = null)
                  {
                      $Stage = new Stage('EZSH Auswertung', 'Klassenliste Profile');
                      if (null !== $DivisionId) {
                          $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/ProfileList', new ChevronLeft()));
              Severity: Major
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php and 2 other locations - About 6 days to fix
              Application/Reporting/Custom/Chemnitz/Person/Frontend.php on lines 677..839
              Application/Reporting/Custom/Herrnhut/Person/Frontend.php on lines 219..376

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1148.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  public function frontendSignList($DivisionId = null)
                  {
                      $Stage = new Stage('EZSH Auswertung', 'Unterschriften Liste');
                      if (null !== $DivisionId) {
                          $Stage->addButton(new Standard('Zurück', '/Reporting/Custom/Herrnhut/Person/SignList', new ChevronLeft()));
              Severity: Major
              Found in Application/Reporting/Custom/Herrnhut/Person/Frontend.php and 2 other locations - About 6 days to fix
              Application/Reporting/Custom/Chemnitz/Person/Frontend.php on lines 677..839
              Application/Reporting/Custom/Herrnhut/Person/Frontend.php on lines 55..212

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1148.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status