Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/Custom/Muldental/Person/Frontend.php

Summary

Maintainability
F
6 days
Test Coverage

Method frontendClassList has 227 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendClassList($LevelId = null, $YearId = null)
    {

        $Stage = new Stage('Auswertung', 'Klassenliste');
        if (null !== $LevelId || $YearId !== null) {
Severity: Major
Found in Application/Reporting/Custom/Muldental/Person/Frontend.php - About 1 day to fix

    Function frontendClassList has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendClassList($LevelId = null, $YearId = null)
    {

        $Stage = new Stage('Auswertung', 'Klassenliste');
        if (null !== $LevelId || $YearId !== null) {
    Severity: Minor
    Found in Application/Reporting/Custom/Muldental/Person/Frontend.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Frontend.php has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace SPHERE\Application\Reporting\Custom\Muldental\Person;

use SPHERE\Application\Education\Lesson\Division\Division;
    Severity: Minor
    Found in Application/Reporting/Custom/Muldental/Person/Frontend.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (!empty($LevelList)) {
                array_walk($LevelList, function ($tblLevelList) use (&$TableContent) {
                    $tblDivisionList = array();

                    /** @var TblLevel $tblLevel */
      Severity: Major
      Found in Application/Reporting/Custom/Muldental/Person/Frontend.php and 1 other location - About 2 days to fix
      Application/Reporting/Custom/BadDueben/Person/Frontend.php on lines 69..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 473.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          ( $tblPersonList
                        ? new LayoutGroup(array(
                            new LayoutRow(array(
                                new LayoutColumn(
                                    new Panel('Weiblich', array(
      Severity: Major
      Found in Application/Reporting/Custom/Muldental/Person/Frontend.php and 1 other location - About 6 hrs to fix
      Application/Reporting/Custom/BadDueben/Person/Frontend.php on lines 259..288

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 212.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if ($LevelId !== null && $YearId !== null) {
                $Global = $this->getGlobal();
                if (!$Global->POST) {
                    $Global->POST['Select']['Level'] = $LevelId;
                    $Global->POST['Select']['Year'] = $YearId;
      Severity: Major
      Found in Application/Reporting/Custom/Muldental/Person/Frontend.php and 1 other location - About 6 hrs to fix
      Application/Reporting/Custom/BadDueben/Person/Frontend.php on lines 157..181

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 211.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          new LayoutGroup(
                        new LayoutRow(array(
                            ( $tblYear ?
                                new LayoutColumn(
                                    new Panel('Jahr', $tblYear->getDisplayName(),
      Severity: Major
      Found in Application/Reporting/Custom/Muldental/Person/Frontend.php and 1 other location - About 3 hrs to fix
      Application/Reporting/Custom/BadDueben/Person/Frontend.php on lines 200..218

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 150.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                                          array(
                                        "pageLength" => -1,
                                        "responsive" => false,
                                        'order'      => array(
                                            array(2, 'asc'),
      Severity: Minor
      Found in Application/Reporting/Custom/Muldental/Person/Frontend.php and 1 other location - About 40 mins to fix
      Application/Reporting/Custom/BadDueben/Person/Frontend.php on lines 243..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status