Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/Custom/Radebeul/Person/Service.php

Summary

Maintainability
F
1 wk
Test Coverage

Function createPhoneList has a Cognitive Complexity of 144 (exceeds 5 allowed). Consider refactoring.
Open

    public function createPhoneList(TblGroup $tblGroup)
    {

        $TableContent = array();
Severity: Minor
Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 819 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 12.09.2016
Severity: Major
Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 day to fix

    Method createNurseryExcel has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createNurseryExcel($PersonList, $PLZ = '')
    {

        if (!empty($PersonList)) {
    Severity: Major
    Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 5 hrs to fix

      Method createPhoneList has 101 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createPhoneList(TblGroup $tblGroup)
    {

        $TableContent = array();
      Severity: Major
      Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 4 hrs to fix

        Function createKindergartenList has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createKindergartenList(TblGroup $tblGroup)
    {

        $TableContent = array();
        Severity: Minor
        Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createRegularSchoolList has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createRegularSchoolList(TblGroup $tblGroup)
    {

        $TableContent = array();
        Severity: Minor
        Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createPhoneListExcel has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createPhoneListExcel($PersonList)
    {

        if (!empty($PersonList)) {
        Severity: Major
        Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 2 hrs to fix

          Function createDenominationList has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createDenominationList(&$countArray)
    {

        $TableContent = array();
        $countArray = array(
          Severity: Minor
          Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createNursery has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createNursery(TblGroup $tblGroup, $PLZ = '')
    {

        $TableContent = array();
          Severity: Minor
          Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createDiseaseListExcel has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createDiseaseListExcel(TblGroup $tblGroup, $PersonList)
    {

        if (!empty($PersonList)) {
          Severity: Major
          Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 2 hrs to fix

            Method createKindergartenListExcel has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createKindergartenListExcel(TblGroup $tblGroup, $PersonList)
    {

        if (!empty($PersonList)) {
            Severity: Minor
            Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

              Method createKindergartenList has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function createKindergartenList(TblGroup $tblGroup)
    {

        $TableContent = array();
              Severity: Minor
              Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                Method createNursery has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createNursery(TblGroup $tblGroup, $PLZ = '')
    {

        $TableContent = array();
                Severity: Minor
                Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                  Method createNurseryListExcel has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function createNurseryListExcel($PersonList, $PLZ = '')
    {

        if (!empty($PersonList)) {
                  Severity: Minor
                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                    Method createParentTeacherConferenceListExcel has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function createParentTeacherConferenceListExcel(TblDivision $tblDivision, $PersonList)
    {

        if (!empty($PersonList)) {
                    Severity: Minor
                    Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                      Method createDenominationListExcel has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function createDenominationListExcel($PersonList, $countArray)
    {

        if (!empty($PersonList)) {
                      Severity: Minor
                      Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                        Method createRegularSchoolListExcel has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function createRegularSchoolListExcel($PersonList)
    {

        if (!empty($PersonList)) {
                        Severity: Minor
                        Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                          Method createDenominationList has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function createDenominationList(&$countArray)
    {

        $TableContent = array();
        $countArray = array(
                          Severity: Minor
                          Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                            Method createRegularSchoolList has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function createRegularSchoolList(TblGroup $tblGroup)
    {

        $TableContent = array();
                            Severity: Minor
                            Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 1 hr to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                              if (($tblFromPersonToPhoneList = Phone::useService()->getPhoneAllByPerson($tblFromPerson))) {
                                    foreach ($tblFromPersonToPhoneList as $tblToMother) {
                                        if ($tblToMother->getTblType()->getName() == 'Privat'
                                            && $tblToMother->getTblType()->getDescription() == 'Mobil'
                                        ) {
                              Severity: Major
                              Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                                if (($tblFromPersonToPhoneList = Phone::useService()->getPhoneAllByPerson($tblFromPerson))) {
                                    foreach ($tblFromPersonToPhoneList as $tblToFather) {
                                        if ($tblToFather->getTblType()->getName() == 'Privat'
                                            && $tblToFather->getTblType()->getDescription() == 'Mobil'
                                        ) {
                                Severity: Major
                                Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 45 mins to fix

                                  Function createDiseaseList has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function createDiseaseList(TblGroup $tblGroup)
    {

        $TableContent = array();
                                  Severity: Minor
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 35 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function createNurseryListExcel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function createNurseryListExcel($PersonList, $PLZ = '')
    {

        if (!empty($PersonList)) {
                                  Severity: Minor
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php - About 25 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                              foreach ($PersonList as $PersonData) {
                $row++;
                $column = 0;

                $export->setValue($export->getCell($column++, $row), $PersonData['Number']);
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 3 hrs to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 796..806

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 157.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                              foreach ($PersonList as $PersonData) {
                $row++;
                $column = 0;

                $export->setValue($export->getCell($column++, $row), $PersonData['Division']);
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 3 hrs to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 682..692

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 157.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      public function createParentTeacherConferenceList(TblDivision $tblDivision)
    {

        $tblPersonList = Division::useService()->getStudentAllByDivision($tblDivision);
        $TableContent = array();
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 3 hrs to fix
                                  Application/Reporting/Custom/Chemnitz/Person/Service.php on lines 906..925

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 150.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                              if (trim(strtoupper($tblToPerson->getRemark())) == 'VATER') {
                                if (($tblFromPersonToPhoneList = Phone::useService()->getPhoneAllByPerson($tblFromPerson))) {
                                    foreach ($tblFromPersonToPhoneList as $tblToFather) {
                                        if ($tblToFather->getTblType()->getName() == 'Privat'
                                            && $tblToFather->getTblType()->getDescription() == 'Mobil'
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 2 hrs to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 313..326

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 125.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                              if (trim(strtoupper($tblToPerson->getRemark())) == 'MUTTER') {
                                if (($tblFromPersonToPhoneList = Phone::useService()->getPhoneAllByPerson($tblFromPerson))) {
                                    foreach ($tblFromPersonToPhoneList as $tblToMother) {
                                        if ($tblToMother->getTblType()->getName() == 'Privat'
                                            && $tblToMother->getTblType()->getDescription() == 'Mobil'
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 2 hrs to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 336..349

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 125.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                          elseif (($remark = $tblTransfer->getRemark())
                            && ($pos = strpos($remark, 'Kita:')) !== false
                        ) {
                            $startPos = $pos + strlen('Kita:');
                            if (($pos2 = strpos($remark, 'Staatliche Schule:')) !== false
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 1 hr to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 624..635

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 119.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                          if (($remark = $tblTransfer->getRemark())
                            && ($pos = strpos($remark, 'Staatliche Schule:')) !== false
                        ) {
                            $startPos = $pos + strlen('Staatliche Schule:');
                            if (($pos2 = strpos($remark, 'Kita:')) !== false
                                  Severity: Major
                                  Found in Application/Reporting/Custom/Radebeul/Person/Service.php and 1 other location - About 1 hr to fix
                                  Application/Reporting/Custom/Radebeul/Person/Service.php on lines 494..505

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 119.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status