Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/Dynamic/Frontend.php

Summary

Maintainability
F
6 days
Test Coverage

File Frontend.php has 736 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Reporting\Dynamic;

use SPHERE\Application\Corporation\Group\Service\Entity\ViewCompanyGroupMember;
use SPHERE\Application\Education\Lesson\Term\Service\Entity\ViewYear;
Severity: Major
Found in Application/Reporting/Dynamic/Frontend.php - About 1 day to fix

    Function frontendSetupFilter has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

        public function frontendSetupFilter($DynamicFilter = 0, $DynamicFilterMask = null, $FilterFieldName = null)
    {

        $Stage = new Stage('Flexible Auswertung', 'Filter definieren');
        $Stage->setMessage('');
    Severity: Minor
    Found in Application/Reporting/Dynamic/Frontend.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method frontendRunFilter has 183 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendRunFilter($DynamicFilter = 0, $SearchFieldName = array())
    {
        // BlackFire.io
//        $DynamicFilter = 2;
    Severity: Major
    Found in Application/Reporting/Dynamic/Frontend.php - About 7 hrs to fix

      Method frontendSetupFilter has 169 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendSetupFilter($DynamicFilter = 0, $DynamicFilterMask = null, $FilterFieldName = null)
    {

        $Stage = new Stage('Flexible Auswertung', 'Filter definieren');
        $Stage->setMessage('');
      Severity: Major
      Found in Application/Reporting/Dynamic/Frontend.php - About 6 hrs to fix

        Method frontendCreateFilter has 128 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendCreateFilter($FilterName = null, $IsPublic = 0)
    {

        $tblAccount = Account::useService()->getAccountBySession();
//        if ($tblAccount) {
        Severity: Major
        Found in Application/Reporting/Dynamic/Frontend.php - About 5 hrs to fix

          Function frontendRunFilter has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

              public function frontendRunFilter($DynamicFilter = 0, $SearchFieldName = array())
    {
        // BlackFire.io
//        $DynamicFilter = 2;
          Severity: Minor
          Found in Application/Reporting/Dynamic/Frontend.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method formCreateStandard has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function formCreateStandard(TblAccount $tblAccount)
    {

        // possible Filter
        $DataAll = $this->FilterPackAll;
          Severity: Major
          Found in Application/Reporting/Dynamic/Frontend.php - About 2 hrs to fix

            Method frontendRemoveFilter has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendRemoveFilter($Id = null, $Confirm = false)
    {

        $Stage = new Stage('Flexible Auswertung', 'Löschen');
        $tblDynamicFilter = $Id === null ? false : Dynamic::useService()->getDynamicFilterById($Id);
            Severity: Minor
            Found in Application/Reporting/Dynamic/Frontend.php - About 1 hr to fix

              Method frontendUpdateFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendUpdateFilter($Id, $FilterName = null, $IsPublic = null)
    {
        $Stage = new Stage('Flexible Auswertung', 'Bearbeiten');

        $tblDynamicFilter = $Id === null ? false : Dynamic::useService()->getDynamicFilterById($Id);
              Severity: Minor
              Found in Application/Reporting/Dynamic/Frontend.php - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    new FormColumn(
                        new Panel('Benutzte Standard-Auswertung',
                            new TableData($TableListRight, null,
//                            new \SPHERE\Common\Frontend\Table\Repository\Title(new Plus().' Resetten', 'von Standard-Auswertungen'),
                                array('CheckBox' => 'Zurücksetzen',
                Severity: Major
                Found in Application/Reporting/Dynamic/Frontend.php and 1 other location - About 2 hrs to fix
                Application/Reporting/Dynamic/Frontend.php on lines 337..353

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 131.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    new FormColumn(
                        new Panel('Neue Standard-Auswertung',
                            new TableData($TableListLeft, null,
//                            new \SPHERE\Common\Frontend\Table\Repository\Title(new Plus().' Hinzufügen', 'von Standard-Auswertungen'),
                                array('CheckBox' => 'Erstellen',
                Severity: Major
                Found in Application/Reporting/Dynamic/Frontend.php and 1 other location - About 2 hrs to fix
                Application/Reporting/Dynamic/Frontend.php on lines 354..370

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 131.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status