DerDu/SPHERE-Framework

View on GitHub
Application/Reporting/Individual/Service/Entity/ViewPerson.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getFormField has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null, $doResetCount = false )
    {

        switch ($PropertyName) {
//            case self::TBL_PERSON_FIRST_NAME:
Severity: Minor
Found in Application/Reporting/Individual/Service/Entity/ViewPerson.php - About 1 hr to fix

    Method loadNameDefinition has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadNameDefinition()
        {
    
            //NameDefinition
            $this->setNameDefinition(self::TBL_SALUTATION_SALUTATION, 'Person: Anrede');
    Severity: Minor
    Found in Application/Reporting/Individual/Service/Entity/ViewPerson.php - About 1 hr to fix

      Function getFormField has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null, $doResetCount = false )
          {
      
              switch ($PropertyName) {
      //            case self::TBL_PERSON_FIRST_NAME:
      Severity: Minor
      Found in Application/Reporting/Individual/Service/Entity/ViewPerson.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null, $doResetCount = false )
      Severity: Minor
      Found in Application/Reporting/Individual/Service/Entity/ViewPerson.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status