Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/Individual/Service/Entity/ViewPersonContact.php

Summary

Maintainability
C
1 day
Test Coverage

Function getFormField has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null,
        $doResetCount = false, $ViewType = TblWorkSpace::VIEW_TYPE_ALL  )
    {

        switch ($PropertyName) {
Severity: Minor
Found in Application/Reporting/Individual/Service/Entity/ViewPersonContact.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFormField has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null,
        $doResetCount = false, $ViewType = TblWorkSpace::VIEW_TYPE_ALL  )
    {

        switch ($PropertyName) {
Severity: Major
Found in Application/Reporting/Individual/Service/Entity/ViewPersonContact.php - About 3 hrs to fix

    Method loadNameDefinition has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadNameDefinition()
    {

        //NameDefinition
        $this->setNameDefinition(self::TBL_ADDRESS_STREET_NAME, 'Hauptadresse: Straße');
    Severity: Minor
    Found in Application/Reporting/Individual/Service/Entity/ViewPersonContact.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                      if ($tblCity) {
                                    if (!isset($Data[$tblCity->getId()])) {
                                        $Data[$tblCity->getId()] = $tblCity->getName();
                                    }
                                }
      Severity: Major
      Found in Application/Reporting/Individual/Service/Entity/ViewPersonContact.php - About 45 mins to fix

        Method getFormField has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null,
        $doResetCount = false, $ViewType = TblWorkSpace::VIEW_TYPE_ALL  )
        Severity: Minor
        Found in Application/Reporting/Individual/Service/Entity/ViewPersonContact.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status