Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/Individual/Service/Entity/ViewProspectCustody.php

Summary

Maintainability
F
2 wks
Test Coverage

Method loadNameDefinition has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadNameDefinition()
    {

        // S1
        $this->setNameDefinition(self::TBL_SALUTATION_SALUTATION_S1, 'S1: Anrede');
Severity: Major
Found in Application/Reporting/Individual/Service/Entity/ViewProspectCustody.php - About 7 hrs to fix

    File ViewProspectCustody.php has 360 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace SPHERE\Application\Reporting\Individual\Service\Entity;

use Doctrine\ORM\Mapping\Cache;
    Severity: Minor
    Found in Application/Reporting/Individual/Service/Entity/ViewProspectCustody.php - About 4 hrs to fix

      Method getFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function getFormField( $PropertyName, $Placeholder = null, $Label = null, IIconInterface $Icon = null, $doResetCount = false )
      Severity: Minor
      Found in Application/Reporting/Individual/Service/Entity/ViewProspectCustody.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php

namespace SPHERE\Application\Reporting\Individual\Service\Entity;

use Doctrine\ORM\Mapping\Cache;
        Severity: Major
        Found in Application/Reporting/Individual/Service/Entity/ViewProspectCustody.php and 1 other location - About 2 wks to fix
        Application/Reporting/Individual/Service/Entity/ViewStudentCustody.php on lines 1..621

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 2902.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status