Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Reporting/KamenzReport/KamenzService.php

Summary

Maintainability
F
1 wk
Test Coverage

Function validate has a Cognitive Complexity of 247 (exceeds 5 allowed). Consider refactoring.
Open

    public static function validate(TblType $tblSchoolType, &$summary = array())
    {
        if (($tblSetting = Consumer::useService()->getSetting(
                'Reporting', 'KamenzReport', 'Validation', 'FirstForeignLanguageLevel'))
            && $tblSetting->getValue()
Severity: Minor
Found in Application/Reporting/KamenzReport/KamenzService.php - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 228 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function validate(TblType $tblSchoolType, &$summary = array())
    {
        if (($tblSetting = Consumer::useService()->getSetting(
                'Reporting', 'KamenzReport', 'Validation', 'FirstForeignLanguageLevel'))
            && $tblSetting->getValue()
Severity: Major
Found in Application/Reporting/KamenzReport/KamenzService.php - About 1 day to fix

    Function getStudentsWithoutDivision has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getStudentsWithoutDivision(&$count = 0)
    {

        $personList = array();
        if (($tblGroup = Group::useService()->getGroupByMetaTable('STUDENT'))
    Severity: Minor
    Found in Application/Reporting/KamenzReport/KamenzService.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File KamenzService.php has 425 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by PhpStorm.
 * User: lehmann
 * Date: 23.06.2017
    Severity: Minor
    Found in Application/Reporting/KamenzReport/KamenzService.php - About 6 hrs to fix

      Method getStudentsWithoutDivision has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function getStudentsWithoutDivision(&$count = 0)
    {

        $personList = array();
        if (($tblGroup = Group::useService()->getGroupByMetaTable('STUDENT'))
      Severity: Major
      Found in Application/Reporting/KamenzReport/KamenzService.php - About 2 hrs to fix

        Method setSummary has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function setSummary(&$summary, $count)
    {

        if ($count['Gender'] > 0) {
            $summary[] = new Warning($count['Gender'] . ' Schüler/n ist kein Geschlecht zugeordnet.'
        Severity: Minor
        Found in Application/Reporting/KamenzReport/KamenzService.php - About 1 hr to fix

          Function setSummary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function setSummary(&$summary, $count)
    {

        if ($count['Gender'] > 0) {
            $summary[] = new Warning($count['Gender'] . ' Schüler/n ist kein Geschlecht zugeordnet.'
          Severity: Minor
          Found in Application/Reporting/KamenzReport/KamenzService.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                              if (!isset($studentList[$tblPerson->getId()])) {
                                        $count['Student']++;
                                        $gender = false;
                                        $birthday = false;
                                        $nationality = '';
          Severity: Major
          Found in Application/Reporting/KamenzReport/KamenzService.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (($tblCommonBirthDates = $tblCommon->getTblCommonBirthDates())) {
                                if (($tblGender = $tblCommonBirthDates->getTblCommonGender())) {
                                    $gender = $tblGender->getName();
                                }
                                if (($birthdayDate = $tblCommonBirthDates->getBirthday())) {
            Severity: Major
            Found in Application/Reporting/KamenzReport/KamenzService.php - About 45 mins to fix

              Function getForeignLanguages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private static function getForeignLanguages(TblPerson $tblPerson)
    {
        $subjects = array();
        if (($tblStudent = $tblPerson->getStudent())
            && ($tblStudentSubjectType = Student::useService()->getStudentSubjectTypeByIdentifier('FOREIGN_LANGUAGE'))
              Severity: Minor
              Found in Application/Reporting/KamenzReport/KamenzService.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  private static function getForeignLanguages(TblPerson $tblPerson)
    {
        $subjects = array();
        if (($tblStudent = $tblPerson->getStudent())
            && ($tblStudentSubjectType = Student::useService()->getStudentSubjectTypeByIdentifier('FOREIGN_LANGUAGE'))
              Severity: Major
              Found in Application/Reporting/KamenzReport/KamenzService.php and 1 other location - About 1 hr to fix
              Application/Document/Generator/Service/Kamenz/KamenzReportService.php on lines 838..859

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status