Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/Authorization/Token/Frontend.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method frontendDestroyToken has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function frontendDestroyToken($Id, $Confirm = false)
    {

        $Stage = new Stage('Hardware-Schlüssel', 'Löschen');
        if ($Id) {
Severity: Major
Found in Application/Setting/Authorization/Token/Frontend.php - About 2 hrs to fix

    Method frontendLayoutToken has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendLayoutToken()
    {

        $headerList = array(
            'Serial' => 'Seriennummer',
    Severity: Major
    Found in Application/Setting/Authorization/Token/Frontend.php - About 2 hrs to fix

      Function frontendLayoutToken has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendLayoutToken()
    {

        $headerList = array(
            'Serial' => 'Seriennummer',
      Severity: Minor
      Found in Application/Setting/Authorization/Token/Frontend.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function frontendDestroyToken has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendDestroyToken($Id, $Confirm = false)
    {

        $Stage = new Stage('Hardware-Schlüssel', 'Löschen');
        if ($Id) {
      Severity: Minor
      Found in Application/Setting/Authorization/Token/Frontend.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (!$Confirm) {

                    $Serial = $tblToken->getSerial();
                    $Serial = substr($Serial, 0, 4) . ' ' . substr($Serial, 4, 4);
      Severity: Minor
      Found in Application/Setting/Authorization/Token/Frontend.php and 1 other location - About 40 mins to fix
      Application/Setting/Authorization/Account/Frontend.php on lines 543..602

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status