DerDu/SPHERE-Framework

View on GitHub
Application/Setting/Consumer/Responsibility/Frontend.php

Summary

Maintainability
F
1 wk
Test Coverage

File Frontend.php has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Setting\Consumer\Responsibility;

use SPHERE\Application\Contact\Address\Address;
use SPHERE\Application\Corporation\Company\Company;
Severity: Minor
Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 4 hrs to fix

    Method frontendResponsibilityDestroy has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendResponsibilityDestroy($Id, $Confirm = false)
        {
    
            $Stage = new Stage('Schulträger', 'Löschen');
            if ($Id) {
    Severity: Major
    Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 2 hrs to fix

      Function frontendResponsibilityDestroy has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendResponsibilityDestroy($Id, $Confirm = false)
          {
      
              $Stage = new Stage('Schulträger', 'Löschen');
              if ($Id) {
      Severity: Minor
      Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method frontendResponsibilityDelete has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendResponsibilityDelete()
          {
      
              $Stage = new Stage('Schulträger', 'Entfernen');
              $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/Responsibility', new ChevronLeft()));
      Severity: Major
      Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 2 hrs to fix

        Method frontendDashboard has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendDashboard()
            {
        
                $Stage = new Stage('Schulträger', 'Übersicht');
        
        
        Severity: Minor
        Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 1 hr to fix

          Method frontendResponsibilityEdit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendResponsibilityEdit($Id = null, $CompanyNumber = null, $Responsibility = null)
              {
          
                  $Stage = new Stage('Unternehmensnr. des Unfallversicherungsträgers', 'Bearbeiten');
                  $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/Responsibility', new ChevronLeft()));
          Severity: Minor
          Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 1 hr to fix

            Method formResponsibilityCompanyCreate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function formResponsibilityCompanyCreate()
                {
            
                    $PanelSelectCompanyTitle = new PullClear(
                        'Schulträger auswählen:'
            Severity: Minor
            Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 1 hr to fix

              Function frontendResponsibilityDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendResponsibilityDelete()
                  {
              
                      $Stage = new Stage('Schulträger', 'Entfernen');
                      $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/Responsibility', new ChevronLeft()));
              Severity: Minor
              Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function frontendDashboard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendDashboard()
                  {
              
                      $Stage = new Stage('Schulträger', 'Übersicht');
              
              
              Severity: Minor
              Found in Application/Setting/Consumer/Responsibility/Frontend.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function frontendResponsibilityDelete()
                  {
              
                      $Stage = new Stage('Schulträger', 'Entfernen');
                      $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/Responsibility', new ChevronLeft()));
              Severity: Major
              Found in Application/Setting/Consumer/Responsibility/Frontend.php and 1 other location - About 2 days to fix
              Application/Setting/Consumer/SponsorAssociation/Frontend.php on lines 186..246

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 471.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (!$Confirm) {
                              $Address = array();
                              if ($tblResponsibility->getServiceTblCompany()) {
                                  $Address[] = $tblResponsibility->getServiceTblCompany()->getName()
                                      .new Container($tblResponsibility->getServiceTblCompany()->getExtendedName())
              Severity: Major
              Found in Application/Setting/Consumer/Responsibility/Frontend.php and 1 other location - About 1 day to fix
              Application/Setting/Consumer/SponsorAssociation/Frontend.php on lines 261..307

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 401.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function formResponsibilityCompanyCreate()
                  {
              
                      $PanelSelectCompanyTitle = new PullClear(
                          'Schulträger auswählen:'
              Severity: Major
              Found in Application/Setting/Consumer/Responsibility/Frontend.php and 1 other location - About 1 day to fix
              Application/Setting/Consumer/SponsorAssociation/Frontend.php on lines 133..180

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 371.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function frontendResponsibilityCreate($Responsibility)
                  {
              
                      $Stage = new Stage('Schulträger', 'Hinzufügen');
                      $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/Responsibility', new ChevronLeft()));
              Severity: Major
              Found in Application/Setting/Consumer/Responsibility/Frontend.php and 1 other location - About 3 hrs to fix
              Application/Setting/Consumer/SponsorAssociation/Frontend.php on lines 105..128

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 158.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $Stage->setContent(
                          new Layout(
                              new LayoutGroup(array(
                                  new LayoutRow(
                                      new LayoutColumn(
              Severity: Minor
              Found in Application/Setting/Consumer/Responsibility/Frontend.php and 1 other location - About 30 mins to fix
              Application/Setting/Consumer/School/Frontend.php on lines 490..507

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status