Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/Consumer/School/Frontend.php

Summary

Maintainability
F
4 days
Test Coverage

File Frontend.php has 548 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Setting\Consumer\School;

use SPHERE\Application\Contact\Address\Address;
use SPHERE\Application\Contact\Address\Service\Entity\TblToCompany;
Severity: Major
Found in Application/Setting/Consumer/School/Frontend.php - About 1 day to fix

    Method frontendLayoutCombine has 157 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendLayoutCombine(TblCompany $tblCompany)
    {

        $tblAddressAllUnsorted = Address::useService()->getAddressAllByCompany($tblCompany);
    Severity: Major
    Found in Application/Setting/Consumer/School/Frontend.php - About 6 hrs to fix

      Function frontendLayoutCombine has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

          public function frontendLayoutCombine(TblCompany $tblCompany)
    {

        $tblAddressAllUnsorted = Address::useService()->getAddressAllByCompany($tblCompany);
      Severity: Minor
      Found in Application/Setting/Consumer/School/Frontend.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method frontendDashboard has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendDashboard()
    {

        $Stage = new Stage('Schulen', 'Übersicht');
        $Stage->addButton(new Standard('Schule hinzufügen', '/Setting/Consumer/School/Create'));
      Severity: Major
      Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

        Function frontendSchoolDestroy has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendSchoolDestroy($Id = null, $Confirm = false)
    {

        $Stage = new Stage('Schule', 'Löschen');
        if ($Id) {
        Severity: Minor
        Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method frontendSchoolDestroy has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendSchoolDestroy($Id = null, $Confirm = false)
    {

        $Stage = new Stage('Schule', 'Löschen');
        if ($Id) {
        Severity: Major
        Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

          Method formSchoolCompanyCreate has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function formSchoolCompanyCreate()
    {

        $PanelSelectCompanyTitle = new PullClear(
            'Schule auswählen:'
          Severity: Major
          Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

            Method frontendSchoolDelete has 52 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendSchoolDelete()
    {

        $Stage = new Stage('Schule', 'Entfernen');
        $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/School', new ChevronLeft()));
            Severity: Major
            Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

              Method frontendSchoolEdit has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendSchoolEdit($Id = null, $CompanyNumber = null, $School = null)
    {

        $Stage = new Stage('Unternehmensnr. des Unfallversicherungsträgers', 'Bearbeiten');
        $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/School', new ChevronLeft()));
              Severity: Minor
              Found in Application/Setting/Consumer/School/Frontend.php - About 2 hrs to fix

                Function frontendDashboard has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendDashboard()
    {

        $Stage = new Stage('Schulen', 'Übersicht');
        $Stage->addButton(new Standard('Schule hinzufügen', '/Setting/Consumer/School/Create'));
                Severity: Minor
                Found in Application/Setting/Consumer/School/Frontend.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function frontendSchoolDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function frontendSchoolDelete()
    {

        $Stage = new Stage('Schule', 'Entfernen');
        $Stage->addButton(new Standard('Zurück', '/Setting/Consumer/School', new ChevronLeft()));
                Severity: Minor
                Found in Application/Setting/Consumer/School/Frontend.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                function (\SPHERE\Application\Contact\Mail\Service\Entity\TblToCompany &$tblToCompany) {

                    $Panel = array($tblToCompany->getTblMail()->getAddress());
                    if ($tblToCompany->getRemark()) {
                        array_push($Panel, new Muted(new Small($tblToCompany->getRemark())));
                Severity: Major
                Found in Application/Setting/Consumer/School/Frontend.php and 1 other location - About 1 hr to fix
                Application/Setting/Consumer/School/Frontend.php on lines 189..200

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            array_walk($tblAddressAll, function (TblToCompany &$tblToCompany) {

                $Panel = array($tblToCompany->getTblAddress()->getGuiLayout());
                if ($tblToCompany->getRemark()) {
                    array_push($Panel, new Muted(new Small($tblToCompany->getRemark())));
                Severity: Major
                Found in Application/Setting/Consumer/School/Frontend.php and 1 other location - About 1 hr to fix
                Application/Setting/Consumer/School/Frontend.php on lines 247..259

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            new Layout(
                new LayoutGroup(
                    new LayoutRow(
                        new LayoutColumn(new Well(
                            School::useService()->createSchool(
                Severity: Minor
                Found in Application/Setting/Consumer/School/Frontend.php and 1 other location - About 55 mins to fix
                Application/Education/Lesson/Division/Frontend.php on lines 1558..1571

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        $Stage->setContent(
            new Layout(
                new LayoutGroup(array(
                    new LayoutRow(
                        new LayoutColumn(
                Severity: Minor
                Found in Application/Setting/Consumer/School/Frontend.php and 1 other location - About 30 mins to fix
                Application/Setting/Consumer/Responsibility/Frontend.php on lines 241..258

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status