Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/Consumer/Service.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function updateSettingList has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateSettingList(IFormInterface $form, $Data, $isSystem)
    {
        if ($Data == null) {
            return $form;
        }
Severity: Minor
Found in Application/Setting/Consumer/Service.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updateSettingList has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateSettingList(IFormInterface $form, $Data, $isSystem)
    {
        if ($Data == null) {
            return $form;
        }
Severity: Minor
Found in Application/Setting/Consumer/Service.php - About 1 hr to fix

    Method createSetting has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $Cluster,
        $Application,
        $Module = null,
        $Identifier,
        $Type = TblSetting::TYPE_BOOLEAN,
    Severity: Minor
    Found in Application/Setting/Consumer/Service.php - About 45 mins to fix

      Function getSchoolTypeBySettingString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getSchoolTypeBySettingString($Value)
    {

        $Value = str_replace(' ', '', $Value);
        $ValueList = explode(',', $Value);
      Severity: Minor
      Found in Application/Setting/Consumer/Service.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getGermanSortBySetting has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getGermanSortBySetting()
    {
        // Setting controlled DataTable
        $IsUmlautWithE = true;
        if(($tblSetting = Consumer::useService()->getSetting('Setting', 'Consumer', 'Service', 'Sort_UmlautWithE'))){
      Severity: Minor
      Found in Application/Setting/Consumer/Service.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status