Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/MyAccount/Frontend.php

Summary

Maintainability
F
5 days
Test Coverage

File Frontend.php has 349 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Setting\MyAccount;

use SPHERE\Application\Api\Setting\ApiMyAccount\ApiMyAccount;
use SPHERE\Application\Contact\Mail\Mail;
Severity: Minor
Found in Application/Setting/MyAccount/Frontend.php - About 4 hrs to fix

    Method frontendMyAccount has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendMyAccount($Setting = array())
    {

        $Stage = new Stage('Mein Benutzerkonto', 'Profil');
    Severity: Major
    Found in Application/Setting/MyAccount/Frontend.php - About 4 hrs to fix

      Method listingSponsorAssociation has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function listingSponsorAssociation()
    {

        $tblSponsorAssociationAll = SponsorAssociation::useService()->getSponsorAssociationAll();
        $Result = array();
      Severity: Minor
      Found in Application/Setting/MyAccount/Frontend.php - About 1 hr to fix

        Method listingSchool has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function listingSchool()
    {

        $tblSchoolAll = School::useService()->getSchoolAll();
        $Result = array();
        Severity: Minor
        Found in Application/Setting/MyAccount/Frontend.php - About 1 hr to fix

          Method listingResponsibility has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function listingResponsibility()
    {

        $tblResponsibilityAll = Responsibility::useService()->getResponsibilityAll();
        $Result = array();
          Severity: Minor
          Found in Application/Setting/MyAccount/Frontend.php - About 1 hr to fix

            Method frontendChangePassword has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function frontendChangePassword($CredentialLock = null, $CredentialLockSafety = null)
    {

        $tblAccount = Account::useService()->getAccountBySession();
        $Stage = new Stage('Mein Benutzerkonto', 'Passwort ändern');
            Severity: Minor
            Found in Application/Setting/MyAccount/Frontend.php - About 1 hr to fix

              Function frontendMyAccount has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendMyAccount($Setting = array())
    {

        $Stage = new Stage('Mein Benutzerkonto', 'Profil');
              Severity: Minor
              Found in Application/Setting/MyAccount/Frontend.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function listingResponsibility()
    {

        $tblResponsibilityAll = Responsibility::useService()->getResponsibilityAll();
        $Result = array();
              Severity: Major
              Found in Application/Setting/MyAccount/Frontend.php and 1 other location - About 1 day to fix
              Application/Setting/MyAccount/Frontend.php on lines 391..435

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 383.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private function listingSponsorAssociation()
    {

        $tblSponsorAssociationAll = SponsorAssociation::useService()->getSponsorAssociationAll();
        $Result = array();
              Severity: Major
              Found in Application/Setting/MyAccount/Frontend.php and 1 other location - About 1 day to fix
              Application/Setting/MyAccount/Frontend.php on lines 344..386

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 383.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status