Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/MyAccount/Service.php

Summary

Maintainability
C
1 day
Test Coverage

Function updatePassword has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public function updatePassword(
        IFormInterface $Form,
        TblAccount $tblAccount,
        $CredentialLock,
        $CredentialLockSafety
Severity: Minor
Found in Application/Setting/MyAccount/Service.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method updatePassword has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updatePassword(
        IFormInterface $Form,
        TblAccount $tblAccount,
        $CredentialLock,
        $CredentialLockSafety
Severity: Major
Found in Application/Setting/MyAccount/Service.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return new Danger('Das Passwort konnte nicht geändert werden').new Redirect('/Setting/MyAccount', Redirect::TIMEOUT_ERROR);
    Severity: Major
    Found in Application/Setting/MyAccount/Service.php - About 30 mins to fix

      Function updateSetting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function updateSetting(
        IFormInterface $Form,
        TblAccount $tblAccount,
        $Setting
    ) {
      Severity: Minor
      Found in Application/Setting/MyAccount/Service.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status