Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Setting/User/Account/Service.php

Summary

Maintainability
F
1 wk
Test Coverage

File Service.php has 682 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Setting\User\Account;

use MOC\V\Component\Document\Component\Bridge\Repository\PhpExcel;
use MOC\V\Component\Document\Component\Exception\Repository\TypeFileException;
Severity: Major
Found in Application/Setting/User/Account/Service.php - About 1 day to fix

    Function createAccount has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createAccount(/*IFormInterface $form, */
        $PersonIdArray = array(),
        $AccountType = 'S'
    )
    {
    Severity: Minor
    Found in Application/Setting/User/Account/Service.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getCompanySchoolByPerson has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getCompanySchoolByPerson(TblPerson $tblPerson, $IsParent = false)
    {

        $tblCompany = false;
        if($IsParent){
    Severity: Minor
    Found in Application/Setting/User/Account/Service.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generatePdfControl has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function generatePdfControl(IFormInterface $Form, TblUserAccount $tblUserAccount, $Data = null, $Path = '/Setting/User')
    {

        if($Data === null){
            return $Form;
    Severity: Major
    Found in Application/Setting/User/Account/Service.php - About 3 hrs to fix

      Service has 27 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Service extends AbstractService
{
    /**
     * @param bool $doSimulation
     * @param bool $withData
      Severity: Minor
      Found in Application/Setting/User/Account/Service.php - About 3 hrs to fix

        Method createAccount has 74 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createAccount(/*IFormInterface $form, */
        $PersonIdArray = array(),
        $AccountType = 'S'
    )
    {
        Severity: Major
        Found in Application/Setting/User/Account/Service.php - About 2 hrs to fix

          Method getStudentFilterResultList has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getStudentFilterResultList(
        $FilterGroup = null,
        $FilterStudent = null,
//        $FilterPerson = null,
        $FilterYear = null,
          Severity: Major
          Found in Application/Setting/User/Account/Service.php - About 2 hrs to fix

            Method getExcelData has 63 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getExcelData($tblUserAccountList = array())
    {

        $result = array();
        if (!empty($tblUserAccountList)) {
            Severity: Major
            Found in Application/Setting/User/Account/Service.php - About 2 hrs to fix

              Method createClassListExcel has 58 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function createClassListExcel($result = array())
    {

        if (!empty($result)) {
              Severity: Major
              Found in Application/Setting/User/Account/Service.php - About 2 hrs to fix

                Method getPersonFilterResultList has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getPersonFilterResultList(
        $FilterGroup = null,
        $FilterPerson = null,
        &$IsTimeout = false
    ) {
                Severity: Minor
                Found in Application/Setting/User/Account/Service.php - About 1 hr to fix

                  Function getLastExport has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getLastExport($tblUserAccountList)
    {
        $BiggestDate = false;
        if(is_array($tblUserAccountList)){
            /** @var TblUserAccount $tblUserAccount */
                  Severity: Minor
                  Found in Application/Setting/User/Account/Service.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getCompanySchoolByPerson has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getCompanySchoolByPerson(TblPerson $tblPerson, $IsParent = false)
    {

        $tblCompany = false;
        if($IsParent){
                  Severity: Minor
                  Found in Application/Setting/User/Account/Service.php - About 1 hr to fix

                    Function generateUserName has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function generateUserName(TblPerson $tblPerson = null, TblConsumer $tblConsumer = null)
    {
        $UserName = '';

        if ($tblConsumer) {
                    Severity: Minor
                    Found in Application/Setting/User/Account/Service.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                                    if(($tblSchoolCompany = School::useService()->getSchoolByType($tblSchoolType))){
                                    $tblSchoolCompany = current($tblSchoolCompany);
                                    $tblCompany = $tblSchoolCompany->getServiceTblCompany();
                                }
                    Severity: Major
                    Found in Application/Setting/User/Account/Service.php - About 45 mins to fix

                      Method createUserAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              TblAccount $tblAccount,
        TblPerson $tblPerson,
        \DateTime $TimeStamp,
        $userPassword,
        $Type,
                      Severity: Minor
                      Found in Application/Setting/User/Account/Service.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                    if ($tblGender) {
                                $item['Gender'] = substr($tblGender->getName(), 0, 1);
                            }
                        Severity: Major
                        Found in Application/Setting/User/Account/Service.php - About 45 mins to fix

                          Function getStudentFilterResultList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getStudentFilterResultList(
        $FilterGroup = null,
        $FilterStudent = null,
//        $FilterPerson = null,
        $FilterYear = null,
                          Severity: Minor
                          Found in Application/Setting/User/Account/Service.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (isset($FilterStudent)) {
            array_walk($FilterStudent, function (&$Input) {
                if (!is_array($Input)) {
                    if (!empty($Input)) {
                        $Input = explode(' ', $Input);
                          Severity: Major
                          Found in Application/Setting/User/Account/Service.php and 1 other location - About 1 hr to fix
                          Application/Setting/User/Account/Service.php on lines 436..450

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 120.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (isset($FilterYear)) {
            array_walk($FilterYear, function (&$Input) {
                if (!is_array($Input)) {
                    if (!empty($Input)) {
                        $Input = explode(' ', $Input);
                          Severity: Major
                          Found in Application/Setting/User/Account/Service.php and 1 other location - About 1 hr to fix
                          Application/Setting/User/Account/Service.php on lines 420..434

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 120.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 7 locations. Consider refactoring.
                          Open

                                  if ($FilterGroup) {
            // Preparation FilterGroup
            array_walk($FilterGroup, function (&$Input) {

                if (!is_array($Input)) {
                          Severity: Major
                          Found in Application/Setting/User/Account/Service.php and 6 other locations - About 1 hr to fix
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 71..87
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 205..221
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 391..407
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 652..668
                          Application/Setting/User/Account/Service.php on lines 486..502
                          Application/Setting/User/Account/Service.php on lines 504..519

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 118.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 7 locations. Consider refactoring.
                          Open

                                  if ($FilterPerson) {
            array_walk($FilterPerson, function (&$Input) {

                if (!is_array($Input)) {
                    if (!empty($Input)) {
                          Severity: Major
                          Found in Application/Setting/User/Account/Service.php and 6 other locations - About 1 hr to fix
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 71..87
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 205..221
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 391..407
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 652..668
                          Application/Setting/User/Account/Service.php on lines 383..399
                          Application/Setting/User/Account/Service.php on lines 486..502

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 118.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 7 locations. Consider refactoring.
                          Open

                                  if ($FilterGroup) {
            // Preparation FilterGroup
            array_walk($FilterGroup, function (&$Input) {

                if (!is_array($Input)) {
                          Severity: Major
                          Found in Application/Setting/User/Account/Service.php and 6 other locations - About 1 hr to fix
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 71..87
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 205..221
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 391..407
                          Application/Reporting/SerialLetter/SerialLetterFilter.php on lines 652..668
                          Application/Setting/User/Account/Service.php on lines 383..399
                          Application/Setting/User/Account/Service.php on lines 504..519

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 118.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status