Application/Setting/User/Account/Service/Data.php
Method createUserAccount has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
TblAccount $tblAccount,
TblPerson $tblPerson,
\DateTime $TimeStamp,
$userPassword,
$Type = 'STUDENT',Similar blocks of code found in 57 locations. Consider refactoring. Open
Open
public function removeUserAccount(TblUserAccount $tblUserAccount)
{
$Manager = $this->getConnection()->getEntityManager();
/** @var TblUserAccount $Entity */- Read upRead up
Application/Billing/Accounting/Creditor/Service/Data.php on lines 136..149
Application/Billing/Accounting/Debtor/Service/Data.php on lines 665..678
Application/Billing/Accounting/Debtor/Service/Data.php on lines 685..698
Application/Billing/Accounting/Debtor/Service/Data.php on lines 705..718
Application/Billing/Accounting/Debtor/Service/Data.php on lines 725..738
Application/Billing/Inventory/Document/Service/Data.php on lines 216..230
Application/Billing/Inventory/Item/Service/Data.php on lines 600..614
Application/Billing/Inventory/Item/Service/Data.php on lines 621..634
Application/Billing/Inventory/Item/Service/Data.php on lines 641..654
Application/Billing/Inventory/Item/Service/Data.php on lines 661..674
Application/Contact/Address/Service/Data.php on lines 789..801
Application/Contact/Mail/Service/Data.php on lines 255..267
Application/Contact/Phone/Service/Data.php on lines 257..269
Application/Contact/Web/Service/Data.php on lines 223..235
Application/Corporation/Company/Service/Data.php on lines 230..243
Application/Corporation/Group/Service/Data.php on lines 334..346
Application/Corporation/Group/Service/Data.php on lines 353..365
Application/Corporation/Group/Service/Data.php on lines 372..384
Application/Education/Certificate/Generator/Service/Data.php on lines 3924..3936
Application/Education/Graduation/Gradebook/MinimumGradeCount/Data.php on lines 257..270
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 659..671
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 678..690
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 697..709
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 716..728
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 735..747
Application/Education/Graduation/Gradebook/ScoreRule/Data.php on lines 1097..1112
Application/Education/Graduation/Gradebook/Service/Data.php on lines 230..243
Application/Education/Graduation/Gradebook/Service/Data.php on lines 618..631
Application/Education/Lesson/Division/Service/Data.php on lines 1641..1654
Application/Education/Lesson/Term/Service/Data.php on lines 893..908
Application/People/Group/Service/Data.php on lines 452..464
Application/People/Group/Service/Data.php on lines 471..483
Application/People/Meta/Student/Service/Data/Agreement.php on lines 212..224
Application/People/Meta/Student/Service/Data/Integration.php on lines 351..363
Application/People/Meta/Student/Service/Data/Integration.php on lines 409..421
Application/People/Meta/Student/Service/Data/Liberation.php on lines 195..207
Application/People/Meta/Student/Service/Data/Student.php on lines 404..416
Application/People/Meta/Student/Service/Data/Subject.php on lines 240..254
Application/People/Meta/Student/Service/Data/Support.php on lines 694..706
Application/People/Meta/Student/Service/Data/Support.php on lines 713..725
Application/People/Meta/Student/Service/Data/Support.php on lines 732..744
Application/People/Meta/Student/Service/Data/Support.php on lines 751..763
Application/People/Meta/Student/Service/Data/Support.php on lines 770..782
Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 158..170
Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 463..475
Application/Platform/Gatekeeper/Authorization/Account/Service/Data.php on lines 697..709
Application/Platform/System/Test/Service/Data.php on lines 65..80
Application/Reporting/CheckList/Service/Data.php on lines 676..688
Application/Reporting/Individual/Service/Data.php on lines 341..353
Application/Reporting/Individual/Service/Data.php on lines 360..372
Application/Reporting/Individual/Service/Data.php on lines 379..391
Application/Reporting/SerialLetter/Service/Data.php on lines 887..900
Application/Reporting/SerialLetter/Service/Data.php on lines 907..920
Application/Setting/Consumer/Responsibility/Service/Data.php on lines 113..127
Application/Setting/Consumer/School/Service/Data.php on lines 142..156
Application/Setting/Consumer/SponsorAssociation/Service/Data.php on lines 72..86
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 98.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76