Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Import/Coswig/Service.php

Summary

Maintainability
F
3 wks
Test Coverage

Function createStudentsFromFile has a Cognitive Complexity of 456 (exceeds 5 allowed). Consider refactoring.
Open

    public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Minor
Found in Application/Transfer/Import/Coswig/Service.php - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createStudentsFromFile has 529 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Major
Found in Application/Transfer/Import/Coswig/Service.php - About 2 days to fix

    File Service.php has 566 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace SPHERE\Application\Transfer\Import\Coswig;
    Severity: Major
    Found in Application/Transfer/Import/Coswig/Service.php - About 1 day to fix

      Avoid deeply nested control flow statements.
      Open

                                              if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(4);
                                        }
      Severity: Major
      Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                                if ($tblLevel) {
                                            $tblDivision = Division::useService()->insertDivision($tblYear, $tblLevel,
                                                '');
                                        }
        Severity: Major
        Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                                  if ($tblPeriod) {
                                            Term::useService()->insertYearPeriod($tblYear, $tblPeriod);
                                        }
          Severity: Major
          Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                                    if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
            Severity: Major
            Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                                      if ($tblPeriod) {
                                            Term::useService()->insertYearPeriod($tblYear, $tblPeriod);
                                        }
              Severity: Major
              Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                        return new Danger('File nicht gefunden');
                Severity: Major
                Found in Application/Transfer/Import/Coswig/Service.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                                  if ($pos === false) {
                                    if ($fatherFullName != '') {
                                        $error[] = 'Zeile: ' . ($RunY + 1) . ' Der Vater wurde nicht angelegt, da der Name des Vaters nicht getrennt werden konnte (Enthält kein Leerzeichen).';
                                    }
                                } else {
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 1 other location - About 3 days to fix
                  Application/Transfer/Import/Coswig/Service.php on lines 365..458

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 643.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                                  if ($pos === false) {
                                    if ($motherFullName != '') {
                                        $error[] = 'Zeile: ' . ($RunY + 1) . ' Die Mutter wurde nicht angelegt, da der Name der Mutter nicht getrennt werden konnte (Enthält kein Leerzeichen).';
                                    }
                                } else {
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 1 other location - About 3 days to fix
                  Application/Transfer/Import/Coswig/Service.php on lines 266..358

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 643.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 19 locations. Consider refactoring.
                  Open

                                      return
                        new Success('Es wurden ' . $countStudent . ' Schüler erfolgreich angelegt.') .
                        new Success('Es wurden ' . $countFather . ' Väter erfolgreich angelegt.') .
                        ($countFatherExists > 0 ?
                            new Warning($countFatherExists . ' Väter exisistieren bereits.') : '') .
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 18 other locations - About 3 hrs to fix
                  Application/Transfer/Import/Annaberg/Service.php on lines 1553..1567
                  Application/Transfer/Import/BadDueben/Service.php on lines 1759..1773
                  Application/Transfer/Import/Braeunsdorf/Service.php on lines 431..445
                  Application/Transfer/Import/Braeunsdorf/Service.php on lines 790..804
                  Application/Transfer/Import/Meerane/Service.php on lines 597..611
                  Application/Transfer/Import/Muldental/Service.php on lines 1260..1274
                  Application/Transfer/Import/Naundorf/Service.php on lines 653..667
                  Application/Transfer/Import/Radebeul/Service.php on lines 1170..1184
                  Application/Transfer/Import/Schneeberg/Service.php on lines 470..484
                  Application/Transfer/Import/Schneeberg/Service.php on lines 1615..1629
                  Application/Transfer/Import/Schulstiftung/Service.php on lines 605..619
                  Application/Transfer/Import/Seelitz/Service.php on lines 477..491
                  Application/Transfer/Import/Seelitz/Service.php on lines 1337..1351
                  Application/Transfer/Import/Seelitz/Service.php on lines 1776..1790
                  Application/Transfer/Import/Tharandt/Service.php on lines 730..744
                  Application/Transfer/Import/Tharandt/Service.php on lines 1135..1149
                  Application/Transfer/Import/Zwickau/Service.php on lines 1203..1217
                  Application/Transfer/Import/Zwickau/Service.php on lines 1574..1588

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 154.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                                  if ($phoneBusiness2Location) {
                                    $phoneNumber = trim($Document->getValue($Document->getCell($phoneBusiness2Location,
                                        $RunY)));
                                    if ($phoneNumber != '') {
                                        $tblType = Phone::useService()->getTypeById(3);
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 2 other locations - About 1 hr to fix
                  Application/Transfer/Import/Coswig/Service.php on lines 532..547
                  Application/Transfer/Import/Hormersdorf/Service.php on lines 1118..1133

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                                  if ($phonePrivate2Location) {
                                    $phoneNumber = trim($Document->getValue($Document->getCell($phonePrivate2Location,
                                        $RunY)));
                                    if ($phoneNumber != '') {
                                        $tblType = Phone::useService()->getTypeById(1);
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 2 other locations - About 1 hr to fix
                  Application/Transfer/Import/Coswig/Service.php on lines 549..564
                  Application/Transfer/Import/Hormersdorf/Service.php on lines 1118..1133

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                  for ($RunX = 0; $RunX < $X; $RunX++) {
                    $Value = trim($Document->getValue($Document->getCell($RunX, 0)));
                    if (array_key_exists($Value, $Location)) {
                        $Location[$Value] = $RunX;
                    }
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php and 2 other locations - About 1 hr to fix
                  Application/Transfer/Import/Chemnitz/Service.php on lines 109..121
                  Application/Transfer/Import/Hormersdorf/Service.php on lines 889..901

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 105.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status