Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Import/Naundorf/Service.php

Summary

Maintainability
F
1 mo
Test Coverage

Function createStudentsFromFile has a Cognitive Complexity of 247 (exceeds 5 allowed). Consider refactoring.
Open

    public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Minor
Found in Application/Transfer/Import/Naundorf/Service.php - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createInterestedPersonsFromFile has a Cognitive Complexity of 180 (exceeds 5 allowed). Consider refactoring.
Open

    public function createInterestedPersonsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Minor
Found in Application/Transfer/Import/Naundorf/Service.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Service.php has 1100 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 04.03.2019
Severity: Major
Found in Application/Transfer/Import/Naundorf/Service.php - About 2 days to fix

    Function createStaffsFromFile has a Cognitive Complexity of 129 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createStaffsFromFile(IFormInterface $Form = null, UploadedFile $File = null)
    {

        /**
         * Skip to Frontend
    Severity: Minor
    Found in Application/Transfer/Import/Naundorf/Service.php - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createClubsFromFile has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createClubsFromFile(IFormInterface $Form = null, UploadedFile $File = null)
    {

        /**
         * Skip to Frontend
    Severity: Minor
    Found in Application/Transfer/Import/Naundorf/Service.php - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createStudentMetasFromFile has a Cognitive Complexity of 105 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createStudentMetasFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
    Severity: Minor
    Found in Application/Transfer/Import/Naundorf/Service.php - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createInterestedPersonsFromFile has 294 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createInterestedPersonsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
    Severity: Major
    Found in Application/Transfer/Import/Naundorf/Service.php - About 1 day to fix

      Method createStudentsFromFile has 284 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
      Severity: Major
      Found in Application/Transfer/Import/Naundorf/Service.php - About 1 day to fix

        Method createStaffsFromFile has 193 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createStaffsFromFile(IFormInterface $Form = null, UploadedFile $File = null)
    {

        /**
         * Skip to Frontend
        Severity: Major
        Found in Application/Transfer/Import/Naundorf/Service.php - About 7 hrs to fix

          Method createClubsFromFile has 161 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createClubsFromFile(IFormInterface $Form = null, UploadedFile $File = null)
    {

        /**
         * Skip to Frontend
          Severity: Major
          Found in Application/Transfer/Import/Naundorf/Service.php - About 6 hrs to fix

            Method createStudentMetasFromFile has 113 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createStudentMetasFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
            Severity: Major
            Found in Application/Transfer/Import/Naundorf/Service.php - About 4 hrs to fix

              Avoid deeply nested control flow statements.
              Open

                                                      if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
              Severity: Major
              Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                    if (0 === strpos($phone, '01')) {
                                        $tblType = Phone::useService()->getTypeById(2);
                                    }
                Severity: Major
                Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                          if ($entrance != '') {
                                            $entrance = str_replace('ab ', '', $entrance);
                                            // php kommt nicht mit 2 stelligen Jahreszahlen klar :(
                                            if (($split = preg_split('/[.]/', $entrance))) {
                                                $entrance = $split[0] . '.' . $split[1] . '.' . '20' . $split[2];
                  Severity: Major
                  Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                    if ($pos !== null) {
                                    $streetName = trim(substr($Street, 0, $pos));
                                    $streetNumber = trim(substr($Street, $pos));
                                }
                    Severity: Major
                    Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                          if (0 === strpos($phone, '01')) {
                                        $tblType = Phone::useService()->getTypeById(2);
                                    }
                      Severity: Major
                      Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                            if ($pos !== false) {
                                        $cityDistrict = trim(substr($cityName, $pos + 4));
                                        $cityName = trim(substr($cityName, 0, $pos));
                                    }
                        Severity: Major
                        Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                              if ($pos !== null) {
                                        $StreetName = trim(substr($Street, 0, $pos));
                                        $StreetNumber = trim(substr($Street, $pos));
                                    }
                          Severity: Major
                          Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                                if ($mailAddress != '') {
                                        Mail::useService()->insertMailToPerson(
                                            $tblPerson,
                                            $mailAddress,
                                            Mail::useService()->getTypeById(1),
                            Severity: Major
                            Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                                      if ((Common::useService()->updateMetaService($tblPerson, $Meta))) {
                                            $countStudent++;
                                        }
                              Severity: Major
                              Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                                if ($pos !== false) {
                                    $cityDistrict = trim(substr($cityName, $pos + 4));
                                    $cityName = trim(substr($cityName, 0, $pos));
                                }
                                Severity: Major
                                Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                      if ($phoneNumber != '') {
                                        $tblType = Phone::useService()->getTypeById(1);
                                        if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
                                  Severity: Major
                                  Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                            if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
                                    Severity: Major
                                    Found in Application/Transfer/Import/Naundorf/Service.php - About 45 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                              return new Danger('File nicht gefunden');
                                      Severity: Major
                                      Found in Application/Transfer/Import/Naundorf/Service.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                return new Danger('File nicht gefunden');
                                        Severity: Major
                                        Found in Application/Transfer/Import/Naundorf/Service.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                  return new Danger('File nicht gefunden');
                                          Severity: Major
                                          Found in Application/Transfer/Import/Naundorf/Service.php - About 30 mins to fix

                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                                            if ($firstNameCustody1 !== '' && $lastNameCustody1 !== '') {
                                    $tblPersonCustody1Exists = Person::useService()->existsPerson(
                                        $firstNameCustody1,
                                        $lastNameCustody1,
                                        $cityCode
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 1 other location - About 1 day to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 552..604

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 267.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                                            if ($firstNameCustody2 !== '' && $lastNameCustody2 !== '') {
                                    $tblPersonCustody2Exists = Person::useService()->existsPerson(
                                        $firstNameCustody2,
                                        $lastNameCustody2,
                                        $cityCode
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 1 other location - About 1 day to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 490..543

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 267.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 4 locations. Consider refactoring.
                                            Open

                                                                            if ($phoneNumber !== '') {
                                    $phoneNumberList = explode(',', $phoneNumber);
                                    foreach ($phoneNumberList as $phone) {
                                        $phone = trim($phone);
                                        $remark = '';
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 3 other locations - About 4 hrs to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 928..946
                                            Application/Transfer/Import/Naundorf/Service.php on lines 950..968
                                            Application/Transfer/Import/Naundorf/Service.php on lines 972..990

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 169.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 4 locations. Consider refactoring.
                                            Open

                                                                            if ($phoneNumber !== '') {
                                    $phoneNumberList = explode(',', $phoneNumber);
                                    foreach ($phoneNumberList as $phone) {
                                        $phone = trim($phone);
                                        $remark = '';
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 3 other locations - About 4 hrs to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 906..924
                                            Application/Transfer/Import/Naundorf/Service.php on lines 950..968
                                            Application/Transfer/Import/Naundorf/Service.php on lines 972..990

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 169.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 4 locations. Consider refactoring.
                                            Open

                                                                            if ($phoneNumber !== '') {
                                    $phoneNumberList = explode(',', $phoneNumber);
                                    foreach ($phoneNumberList as $phone) {
                                        $phone = trim($phone);
                                        $remark = '';
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 3 other locations - About 4 hrs to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 906..924
                                            Application/Transfer/Import/Naundorf/Service.php on lines 928..946
                                            Application/Transfer/Import/Naundorf/Service.php on lines 972..990

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 169.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 4 locations. Consider refactoring.
                                            Open

                                                                            if ($phoneNumber !== '') {
                                    $phoneNumberList = explode(',', $phoneNumber);
                                    foreach ($phoneNumberList as $phone) {
                                        $phone = trim($phone);
                                        $remark = '';
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 3 other locations - About 4 hrs to fix
                                            Application/Transfer/Import/Naundorf/Service.php on lines 906..924
                                            Application/Transfer/Import/Naundorf/Service.php on lines 928..946
                                            Application/Transfer/Import/Naundorf/Service.php on lines 950..968

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 169.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 19 locations. Consider refactoring.
                                            Open

                                                                return
                        new Success('Es wurden ' . $countInterestedPerson . ' Intessenten erfolgreich angelegt.')
                        . new Success('Es wurden ' . $countFather . ' Sorgeberechtigte1 erfolgreich angelegt.') .
                        ($countFatherExists > 0 ?
                            new Warning($countFatherExists . ' Sorgeberechtigte1 exisistieren bereits.') : '') .
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 18 other locations - About 3 hrs to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 1553..1567
                                            Application/Transfer/Import/BadDueben/Service.php on lines 1759..1773
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 431..445
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 790..804
                                            Application/Transfer/Import/Coswig/Service.php on lines 644..658
                                            Application/Transfer/Import/Meerane/Service.php on lines 597..611
                                            Application/Transfer/Import/Muldental/Service.php on lines 1260..1274
                                            Application/Transfer/Import/Radebeul/Service.php on lines 1170..1184
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 470..484
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 1615..1629
                                            Application/Transfer/Import/Schulstiftung/Service.php on lines 605..619
                                            Application/Transfer/Import/Seelitz/Service.php on lines 477..491
                                            Application/Transfer/Import/Seelitz/Service.php on lines 1337..1351
                                            Application/Transfer/Import/Seelitz/Service.php on lines 1776..1790
                                            Application/Transfer/Import/Tharandt/Service.php on lines 730..744
                                            Application/Transfer/Import/Tharandt/Service.php on lines 1135..1149
                                            Application/Transfer/Import/Zwickau/Service.php on lines 1203..1217
                                            Application/Transfer/Import/Zwickau/Service.php on lines 1574..1588

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 154.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 5 locations. Consider refactoring.
                                            Open

                                                                            if ($pos !== false) {
                                    $cityCode = trim(substr($cityName, 0, $pos));
                                    $cityName = trim(substr($cityName, $pos + 1));

                                    $pos = strpos($cityName, " OT ");
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 4 other locations - About 3 hrs to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 259..268
                                            Application/Transfer/Import/BadDueben/Service.php on lines 145..154
                                            Application/Transfer/Import/BadDueben/Service.php on lines 461..470
                                            Application/Transfer/Import/Naundorf/Service.php on lines 1276..1285

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 151.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 5 locations. Consider refactoring.
                                            Open

                                                                        if ($pos !== false) {
                                $cityCode = trim(substr($cityName, 0, $pos));
                                $cityName = trim(substr($cityName, $pos + 1));

                                $pos = strpos($cityName, " OT ");
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 4 other locations - About 3 hrs to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 259..268
                                            Application/Transfer/Import/BadDueben/Service.php on lines 145..154
                                            Application/Transfer/Import/BadDueben/Service.php on lines 461..470
                                            Application/Transfer/Import/Naundorf/Service.php on lines 411..420

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 151.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 6 locations. Consider refactoring.
                                            Open

                                                                if ($tblYear) {
                        $tblPeriodList = Term::useService()->getPeriodAllByYear($tblYear);
                        if (!$tblPeriodList) {
                            // firstTerm
                            $tblPeriod = Term::useService()->insertPeriod(
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 5 other locations - About 3 hrs to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 620..643
                                            Application/Transfer/Import/Annaberg/Service.php on lines 646..669
                                            Application/Transfer/Import/BadDueben/Service.php on lines 938..961
                                            Application/Transfer/Import/LebensweltZwenkau/Service.php on lines 142..165
                                            Application/Transfer/Import/Service.php on lines 48..71

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 145.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                            $Location = array(
                    'Schuljahr' => null,
                    'Name' => null,
                    'Vorname' => null,
                    'Geburtsdatum' => null,
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 1 other location - About 1 hr to fix
                                            Application/Transfer/Import/Muldental/Service.php on lines 1522..1537

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 120.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 3 locations. Consider refactoring.
                                            Open

                                                            $Location = array(
                    'Klasse' => null,
                    'Name' => null,
                    'Vorname' => null,
                    'Geburtsdatum' => null,
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 2 other locations - About 1 hr to fix
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 853..867
                                            Application/Transfer/Import/Hormersdorf/Service.php on lines 418..432

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 112.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Identical blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                                            if ($level !== '' && $tblYear && $tblSchoolType) {
                                    $tblLevel = Division::useService()->insertLevel($tblSchoolType, $level);
                                    if ($tblLevel) {
                                        $tblDivision = Division::useService()->insertDivision(
                                            $tblYear,
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 1 other location - About 1 hr to fix
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 234..249

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 110.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                                            $Location = array(
                    'Name' => null,
                    'Vorname' => null,
                    'Kürzel' => null,
                    'Geburtsdatum' => null,
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 1 other location - About 1 hr to fix
                                            Application/Transfer/Import/Hormersdorf/Service.php on lines 80..93

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 104.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 9 locations. Consider refactoring.
                                            Open

                                                                return
                        new Success('Es wurden ' . $countClub . ' Vereinsmitglieder erfolgreich angelegt.') .
                        ($countClubExists > 0 ?
                            new Warning($countClubExists . ' Vereinsmitglieder exisistieren bereits.') : '')
                        . new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 8 other locations - About 30 mins to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 412..422
                                            Application/Transfer/Import/BadDueben/Service.php on lines 316..326
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 978..988
                                            Application/Transfer/Import/Muldental/Service.php on lines 1719..1729
                                            Application/Transfer/Import/Naundorf/Service.php on lines 277..287
                                            Application/Transfer/Import/Radebeul/Service.php on lines 1823..1833
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 714..724
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 2212..2222

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 91.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            Similar blocks of code found in 9 locations. Consider refactoring.
                                            Open

                                                                return
                        new Success('Es wurden ' . $countStaff . ' Mitarbeiter erfolgreich angelegt.') .
                        ($countStaffExists > 0 ?
                            new Warning($countStaffExists . ' Mitarbeiter exisistieren bereits.') : '')
                        . new Layout(new LayoutGroup(new LayoutRow(new LayoutColumn(
                                            Severity: Major
                                            Found in Application/Transfer/Import/Naundorf/Service.php and 8 other locations - About 30 mins to fix
                                            Application/Transfer/Import/Annaberg/Service.php on lines 412..422
                                            Application/Transfer/Import/BadDueben/Service.php on lines 316..326
                                            Application/Transfer/Import/Braeunsdorf/Service.php on lines 978..988
                                            Application/Transfer/Import/Muldental/Service.php on lines 1719..1729
                                            Application/Transfer/Import/Naundorf/Service.php on lines 1398..1408
                                            Application/Transfer/Import/Radebeul/Service.php on lines 1823..1833
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 714..724
                                            Application/Transfer/Import/Schneeberg/Service.php on lines 2212..2222

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 91.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            There are no issues that match your filters.

                                            Category
                                            Status