Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Import/Schulstiftung/Service.php

Summary

Maintainability
F
1 wk
Test Coverage

Function createStudentsFromFile has a Cognitive Complexity of 348 (exceeds 5 allowed). Consider refactoring.
Open

    public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Minor
Found in Application/Transfer/Import/Schulstiftung/Service.php - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createStudentsFromFile has 485 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createStudentsFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {
Severity: Major
Found in Application/Transfer/Import/Schulstiftung/Service.php - About 2 days to fix

    File Service.php has 523 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by PhpStorm.
 * User: Kauschke
 * Date: 04.01.2017
    Severity: Major
    Found in Application/Transfer/Import/Schulstiftung/Service.php - About 1 day to fix

      Avoid deeply nested control flow statements.
      Open

                                              if (!$tblPeriodList) {
                                            // firstTerm
                                            $tblPeriod = Term::useService()->insertPeriod(
                                                '1. Halbjahr',
                                                '01.08.20' . $year,
      Severity: Major
      Found in Application/Transfer/Import/Schulstiftung/Service.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                                if ($tblSchoolType) {
                                            $tblLevel = Division::useService()->insertLevel($tblSchoolType, $level);
                                            if ($tblLevel) {
                                                $tblDivision = Division::useService()->insertDivision(
                                                    $tblYear,
        Severity: Major
        Found in Application/Transfer/Import/Schulstiftung/Service.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                  return new Danger('File nicht gefunden');
          Severity: Major
          Found in Application/Transfer/Import/Schulstiftung/Service.php - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($tblPersonMother !== null) {
                                    $motherStreetName = trim($Document->getValue($Document->getCell($Location['Straße Sorg 1'],
                                        $RunY)));
                                    $motherStreetNumber = trim($Document->getValue($Document->getCell($Location['Hausnr. Sorg 1'],
                                        $RunY)));
            Severity: Major
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 3 hrs to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 467..485

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($tblPersonFather !== null) {
                                    $fatherStreetName = trim($Document->getValue($Document->getCell($Location['Straße Sorg 2'],
                                        $RunY)));
                                    $fatherStreetNumber = trim($Document->getValue($Document->getCell($Location['Hausnr. Sorg 2'],
                                        $RunY)));
            Severity: Major
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 3 hrs to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 486..504

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 19 locations. Consider refactoring.
            Open

                                return
                        new Success('Es wurden ' . $countStudent . ' Schüler erfolgreich angelegt.') .
                        new Success('Es wurden ' . $countFather . ' Sorgeberechtigte2 erfolgreich angelegt.') .
                        ($countFatherExists > 0 ?
                            new Warning($countFatherExists . ' Sorgeberechtigte2 exisistieren bereits.') : '') .
            Severity: Major
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 18 other locations - About 3 hrs to fix
            Application/Transfer/Import/Annaberg/Service.php on lines 1553..1567
            Application/Transfer/Import/BadDueben/Service.php on lines 1759..1773
            Application/Transfer/Import/Braeunsdorf/Service.php on lines 431..445
            Application/Transfer/Import/Braeunsdorf/Service.php on lines 790..804
            Application/Transfer/Import/Coswig/Service.php on lines 644..658
            Application/Transfer/Import/Meerane/Service.php on lines 597..611
            Application/Transfer/Import/Muldental/Service.php on lines 1260..1274
            Application/Transfer/Import/Naundorf/Service.php on lines 653..667
            Application/Transfer/Import/Radebeul/Service.php on lines 1170..1184
            Application/Transfer/Import/Schneeberg/Service.php on lines 470..484
            Application/Transfer/Import/Schneeberg/Service.php on lines 1615..1629
            Application/Transfer/Import/Seelitz/Service.php on lines 477..491
            Application/Transfer/Import/Seelitz/Service.php on lines 1337..1351
            Application/Transfer/Import/Seelitz/Service.php on lines 1776..1790
            Application/Transfer/Import/Tharandt/Service.php on lines 730..744
            Application/Transfer/Import/Tharandt/Service.php on lines 1135..1149
            Application/Transfer/Import/Zwickau/Service.php on lines 1203..1217
            Application/Transfer/Import/Zwickau/Service.php on lines 1574..1588

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 154.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                            Common::useService()->insertMeta(
                                    $tblPerson,
                                    $birthday,
                                    trim($Document->getValue($Document->getCell($Location['Geburtsort'],
                                        $RunY))),
            Severity: Minor
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 2 other locations - About 35 mins to fix
            Application/Transfer/Import/Dresden/Service.php on lines 221..233
            Application/Transfer/Import/Seelitz/Service.php on lines 890..902

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($sibling !== '' && $tblPerson) {
                                    if (isset($studentList[$sibling])) {
                                        /** @var TblPerson $tblPersonTo */
                                        $tblPersonTo = $studentList[$sibling];
                                        Relationship::useService()->insertRelationshipToPerson($tblPerson, $tblPersonTo,
            Severity: Minor
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 30 mins to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 568..577

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($sibling !== '' && $tblPerson) {
                                    if (isset($studentList[$sibling])) {
                                        /** @var TblPerson $tblPersonTo */
                                        $tblPersonTo = $studentList[$sibling];
                                        Relationship::useService()->insertRelationshipToPerson($tblPerson, $tblPersonTo,
            Severity: Minor
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 30 mins to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 556..565

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($phoneNumber !== '') {
                                    $tblType = Phone::useService()->getTypeById(5);
                                    if (0 === strpos($phoneNumber, '01')) {
                                        $tblType = Phone::useService()->getTypeById(6);
                                    }
            Severity: Minor
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 30 mins to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 508..521

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                            if ($phoneNumber !== '') {
                                    $tblType = Phone::useService()->getTypeById(1);
                                    if (0 === strpos($phoneNumber, '01')) {
                                        $tblType = Phone::useService()->getTypeById(2);
                                    }
            Severity: Minor
            Found in Application/Transfer/Import/Schulstiftung/Service.php and 1 other location - About 30 mins to fix
            Application/Transfer/Import/Schulstiftung/Service.php on lines 525..538

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status