Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Indiware/Import/Service/Data.php

Summary

Maintainability
F
5 days
Test Coverage

File Data.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Transfer\Indiware\Import\Service;

use SPHERE\Application\Education\Lesson\Division\Service\Entity\TblDivision;
Severity: Minor
Found in Application/Transfer/Indiware/Import/Service/Data.php - About 6 hrs to fix

    Function createIndiwareImportLectureshipBulk has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createIndiwareImportLectureshipBulk(
        $ImportList,
        TblYear $tblYear,
        TblAccount $tblAccount
    ) {
    Severity: Minor
    Found in Application/Transfer/Indiware/Import/Service/Data.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Data has 28 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Data extends AbstractData
{

    public function setupDatabaseContent()
    {
    Severity: Minor
    Found in Application/Transfer/Indiware/Import/Service/Data.php - About 3 hrs to fix

      Function createIndiwareImportStudentBulk has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createIndiwareImportStudentBulk(
        $ImportList,
        TblYear $tblYear,
        TblAccount $tblAccount,
        $LevelString = ''
      Severity: Minor
      Found in Application/Transfer/Indiware/Import/Service/Data.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createIndiwareImportLectureshipBulk has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createIndiwareImportLectureshipBulk(
        $ImportList,
        TblYear $tblYear,
        TblAccount $tblAccount
    ) {
      Severity: Minor
      Found in Application/Transfer/Indiware/Import/Service/Data.php - About 1 hr to fix

        Method createIndiwareImportStudentCourse has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                $SubjectGroup = '',
        $SubjectName = '',
        $Number,
        $IsIntensiveCourse = false,
        $IsIgnoreCourse = false,
        Severity: Major
        Found in Application/Transfer/Indiware/Import/Service/Data.php - About 50 mins to fix

          Method updateIndiwareImportLectureship has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  TblIndiwareImportLectureship $tblIndiwareImportLectureship = null,
        TblDivision $tblDivision = null,
        TblTeacher $tblTeacher = null,
        TblSubject $tblSubject = null,
        $SubjectGroup = '',
          Severity: Minor
          Found in Application/Transfer/Indiware/Import/Service/Data.php - About 45 mins to fix

            Method createIndiwareImportLectureship has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    Manager $Manager,
        TblYear $tblYear,
        TblAccount $tblAccount,
        $Result = array(),
        $TeacherCount = 1,
            Severity: Minor
            Found in Application/Transfer/Indiware/Import/Service/Data.php - About 45 mins to fix

              Consider simplifying this complex logical expression.
              Open

                                      if ((isset($Result['FileTeacher1']) && $Result['FileTeacher1'] == '')
                            && (isset($Result['FileTeacher2']) && $Result['FileTeacher2'] == '')
                            && (isset($Result['FileTeacher3']) && $Result['FileTeacher3'] == '')
                        ) {
                            $this->createIndiwareImportLectureship($Manager, $tblYear, $tblAccount, $Result, 1,
              Severity: Major
              Found in Application/Transfer/Indiware/Import/Service/Data.php - About 40 mins to fix

                Method updateIndiwareImportStudentCourse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        TblIndiwareImportStudentCourse $tblIndiwareImportStudentCourse,
        $tblSubject = null,
        $SubjectGroup = '',
        $IsIntensive = false,
        $IgnoreCourse = false
                Severity: Minor
                Found in Application/Transfer/Indiware/Import/Service/Data.php - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function updateIndiwareImportLectureship(
        TblIndiwareImportLectureship $tblIndiwareImportLectureship = null,
        TblDivision $tblDivision = null,
        TblTeacher $tblTeacher = null,
        TblSubject $tblSubject = null,
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 1 other location - About 6 hrs to fix
                  Application/Transfer/Untis/Import/Service/Data.php on lines 110..137

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 211.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      public function destroyIndiwareImportStudentCourse(TblIndiwareImportStudent $tblIndiwareImportStudent)
    {

        $Manager = $this->getConnection()->getEntityManager();
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 3 other locations - About 2 hrs to fix
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 566..584
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 616..634
                  Application/Transfer/Untis/Import/Service/Data.php on lines 168..186

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      public function destroyIndiwareImportLectureshipByAccount(TblAccount $tblAccount)
    {

        $Manager = $this->getConnection()->getEntityManager();
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 3 other locations - About 2 hrs to fix
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 591..609
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 616..634
                  Application/Transfer/Untis/Import/Service/Data.php on lines 168..186

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      public function destroyIndiwareImportStudentByAccount(TblAccount $tblAccount)
    {

        $Manager = $this->getConnection()->getEntityManager();
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 3 other locations - About 2 hrs to fix
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 566..584
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 591..609
                  Application/Transfer/Untis/Import/Service/Data.php on lines 168..186

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function updateIndiwareImportStudent(
        TblIndiwareImportStudent $tblIndiwareImportStudent,
        TblDivision $tblDivision = null
    ) {
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 1 other location - About 2 hrs to fix
                  Application/Reporting/Individual/Service/Data.php on lines 194..211

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 131.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                      public function updateIndiwareImportStudentIsIgnore(
        TblIndiwareImportStudent $tblIndiwareImportStudent,
        $isIgnore = true
    ) {
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 5 other locations - About 2 hrs to fix
                  Application/Billing/Bookkeeping/Invoice/Service/Data.php on lines 494..511
                  Application/Education/Certificate/Generate/Service/Data.php on lines 167..187
                  Application/People/Relationship/Service/Data.php on lines 216..229
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 495..513
                  Application/Transfer/Untis/Import/Service/Data.php on lines 145..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 128.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                      public function updateIndiwareImportLectureshipIsIgnore(
        TblIndiwareImportLectureship $tblIndiwareImportLectureship,
        $isIgnore = true
    ) {
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 5 other locations - About 2 hrs to fix
                  Application/Billing/Bookkeeping/Invoice/Service/Data.php on lines 494..511
                  Application/Education/Certificate/Generate/Service/Data.php on lines 167..187
                  Application/People/Relationship/Service/Data.php on lines 216..229
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 541..559
                  Application/Transfer/Untis/Import/Service/Data.php on lines 145..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 128.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      public function destroyIndiwareImportStudent(TblIndiwareImportStudent $tblIndiwareImportStudent)
    {

        $Manager = $this->getConnection()->getEntityManager();
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 2 other locations - About 1 hr to fix
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 641..656
                  Application/Transfer/Untis/Import/Service/Data.php on lines 193..208

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 107.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                      public function destroyIndiwareImportLectureship(TblIndiwareImportLectureship $tblIndiwareImportLectureship)
    {

        $Manager = $this->getConnection()->getEntityManager();
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/Service/Data.php and 2 other locations - About 1 hr to fix
                  Application/Transfer/Indiware/Import/Service/Data.php on lines 663..678
                  Application/Transfer/Untis/Import/Service/Data.php on lines 193..208

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 107.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status