Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Indiware/Import/StudentCourse.php

Summary

Maintainability
F
1 wk
Test Coverage

File StudentCourse.php has 781 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Transfer\Indiware\Import;

use SPHERE\Application\Document\Storage\FilePointer;
Severity: Major
Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 1 day to fix

    Method frontendStudentCourseShow has 209 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function frontendStudentCourseShow($Visible = false)
    {
        $Stage = new Stage('Schüler-Kurse SEK II ', 'Übersicht');
        $Stage->addButton(new Standard('Zurück', '/Transfer/Indiware/Import', new ChevronLeft()));
        $tblIndiwareImportStudentList = Import::useService()->getIndiwareImportStudentAll(true);
    Severity: Major
    Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 1 day to fix

      Method frontendStudentCourseUpload has 160 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function frontendStudentCourseUpload(
        UploadedFile $File = null,
        $tblYear = null,
        $Level = null
    ) {
      Severity: Major
      Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 6 hrs to fix

        Function formSubjectCourse has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

            public function formSubjectCourse(TblIndiwareImportStudent $tblIndiwareImportStudent, TblYear $tblYear = null)
    {

        $FormSubjectAll = array();
        $tblSubjectList = Subject::useService()->getSubjectAll();
        Severity: Minor
        Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function frontendStudentCourseUpload has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            public function frontendStudentCourseUpload(
        UploadedFile $File = null,
        $tblYear = null,
        $Level = null
    ) {
        Severity: Minor
        Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method frontendStudentCourseEdit has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function frontendStudentCourseEdit($Id = null, $Data = null, $Visible = false)
    {
        $Stage = new Stage('Lehrauftrag', 'Bearbeiten');
        $tblIndiwareImportStudent = ($Id !== null ? Import::useService()->getIndiwareImportStudentById($Id) : false);
        if (!$tblIndiwareImportStudent) {
        Severity: Major
        Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 2 hrs to fix

          Method formSubjectCourse has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function formSubjectCourse(TblIndiwareImportStudent $tblIndiwareImportStudent, TblYear $tblYear = null)
    {

        $FormSubjectAll = array();
        $tblSubjectList = Subject::useService()->getSubjectAll();
          Severity: Major
          Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 2 hrs to fix

            Method frontendStudentCoursePrepare has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function frontendStudentCoursePrepare()
    {
        $Stage = new Stage('Indiware', 'Datentransfer');
        $Stage->addButton(new Standard('Zurück', '/Transfer/Indiware/Import', new ChevronLeft()));
            Severity: Major
            Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 2 hrs to fix

              Function frontendStudentCourseEdit has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function frontendStudentCourseEdit($Id = null, $Data = null, $Visible = false)
    {
        $Stage = new Stage('Lehrauftrag', 'Bearbeiten');
        $tblIndiwareImportStudent = ($Id !== null ? Import::useService()->getIndiwareImportStudentById($Id) : false);
        if (!$tblIndiwareImportStudent) {
              Severity: Minor
              Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method frontendStudentCourseDestroy has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function frontendStudentCourseDestroy($Confirm = false)
    {

        $Stage = new Stage('Importvorbereitung', 'Leeren');
        $Stage->setMessage('Hierbei werden alle nicht importierte Daten der letzten Importvorbereitung gelöscht.');
              Severity: Minor
              Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 1 hr to fix

                Avoid too many return statements within this method.
                Open

                        return $Stage;
                Severity: Major
                Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $Stage->setContent(new WarningMessage('Ungültige Dateiendung!'))
                .new Redirect('/Transfer/Indiware/Import', Redirect::TIMEOUT_ERROR);
                  Severity: Major
                  Found in Application/Transfer/Indiware/Import/StudentCourse.php - About 30 mins to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function frontendStudentCourseDestroy($Confirm = false)
    {

        $Stage = new Stage('Importvorbereitung', 'Leeren');
        $Stage->setMessage('Hierbei werden alle nicht importierte Daten der letzten Importvorbereitung gelöscht.');
                    Severity: Major
                    Found in Application/Transfer/Indiware/Import/StudentCourse.php and 2 other locations - About 1 day to fix
                    Application/Transfer/Indiware/Import/Lectureship.php on lines 823..871
                    Application/Transfer/Untis/Import/Lectureship.php on lines 727..775

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 397.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status