Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Indiware/Import/StudentCourseGateway.php

Summary

Maintainability
F
3 days
Test Coverage

Method __construct has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($File, TblYear $tblYear, $Level = null, StudentCourseControl $Control)
    {
        $this->loadFile($File);
        $this->Year = $tblYear;
        $this->Level = $Level;
Severity: Major
Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php - About 4 hrs to fix

    Method runConvert has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function runConvert($Row)
    {
        $Result = array();
        foreach ($Row as $Part) {
            $Result = array_merge($Result, $Part);
    Severity: Major
    Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php - About 3 hrs to fix

      File StudentCourseGateway.php has 292 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * Import Schüler-Kurse. Reihenfolge der Felder aus der CSV-Datei Schüler.csv
 * wird Dynamisch ausgelesen (Erfolgt in Control)
 */
      Severity: Minor
      Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php - About 3 hrs to fix

        Function runConvert has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function runConvert($Row)
    {
        $Result = array();
        foreach ($Row as $Part) {
            $Result = array_merge($Result, $Part);
        Severity: Minor
        Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } elseif ($Level == 4) {    // Klasse 12 2. Halbjahr
            $SubjectGroupList[1] = $ColumnList['Kurs41'];
            $SubjectGroupList[2] = $ColumnList['Kurs42'];
            $SubjectGroupList[3] = $ColumnList['Kurs43'];
            $SubjectGroupList[4] = $ColumnList['Kurs44'];
        Severity: Major
        Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php and 1 other location - About 1 day to fix
        Application/Transfer/Indiware/Import/StudentCourseGateway.php on lines 92..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 263.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } elseif ($Level == 3) {   // Klasse 12 1. Halbjahr
            $SubjectGroupList[1] = $ColumnList['Kurs31'];
            $SubjectGroupList[2] = $ColumnList['Kurs32'];
            $SubjectGroupList[3] = $ColumnList['Kurs33'];
            $SubjectGroupList[4] = $ColumnList['Kurs34'];
        Severity: Major
        Found in Application/Transfer/Indiware/Import/StudentCourseGateway.php and 1 other location - About 1 day to fix
        Application/Transfer/Indiware/Import/StudentCourseGateway.php on lines 110..128

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 263.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status