Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star
Application/Transfer/Untis/Import/LectureshipGateway.php

Summary

Maintainability
F
4 days
Test Coverage

Function fetchDivision has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    protected function fetchDivision($Value)
    {
        if ($Value != '') {
            $LevelName = null;
            $DivisionName = null;
Severity: Minor
Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sanitizeDivision has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    protected function sanitizeDivision($Value)
    {
        $LevelName = null;
        $DivisionName = null;
        if ($Value === '') {
Severity: Minor
Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanitizeDivision has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function sanitizeDivision($Value)
    {
        $LevelName = null;
        $DivisionName = null;
        if ($Value === '') {
Severity: Major
Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 2 hrs to fix

    File LectureshipGateway.php has 253 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Export Unterricht (GPU002.TXT) Reihenfolge der Felder in der DIF-Datei GPU002.TXT
 * GPU002.TXT DIF-Datei Unterricht:
 * Nummer        Feld                Art
    Severity: Minor
    Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 2 hrs to fix

      Method fetchDivision has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function fetchDivision($Value)
    {
        if ($Value != '') {
            $LevelName = null;
            $DivisionName = null;
      Severity: Minor
      Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 1 hr to fix

        Method runConvert has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function runConvert($Row)
    {
        $Result = array();
        foreach ($Row as $Part) {
            $Result = array_merge($Result, $Part);
        Severity: Minor
        Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                          return new Danger(new Ban().' Zu viele Treffer für die Klasse!');
          Severity: Major
          Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new Danger(new Ban().' Schuljahr nicht gefunden!');
            Severity: Major
            Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return new Danger(new Ban().' Klasse nicht gefunden!');
              Severity: Major
              Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $tblDivision->getDisplayName();
                Severity: Major
                Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return new Danger(new Ban().' Klasse nicht gefunden!');
                  Severity: Major
                  Found in Application/Transfer/Untis/Import/LectureshipGateway.php - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        protected function fetchDivision($Value)
    {
        if ($Value != '') {
            $LevelName = null;
            $DivisionName = null;
                    Severity: Major
                    Found in Application/Transfer/Untis/Import/LectureshipGateway.php and 1 other location - About 1 day to fix
                    Application/Transfer/Indiware/Import/LectureshipGateway.php on lines 440..489

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 344.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        protected function sanitizeTeacher($Value)
    {
        if (empty($Value)) {
            return new Warning(new WarningIcon().' Lehrer wurde nicht angegeben');
        }
                    Severity: Major
                    Found in Application/Transfer/Untis/Import/LectureshipGateway.php and 1 other location - About 1 hr to fix
                    Application/Transfer/Indiware/Import/LectureshipGateway.php on lines 565..576

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 103.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (empty($tblDivisionList)) {
                $this->IsError = true;
                return new Danger(new Ban().' Klasse nicht gefunden!');
            } elseif (count($tblDivisionList) == 1) {
                /** @var TblDivision $tblDivision */
                    Severity: Major
                    Found in Application/Transfer/Untis/Import/LectureshipGateway.php and 1 other location - About 1 hr to fix
                    Application/Transfer/Untis/Import/LectureshipGateway.php on lines 231..240

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (empty($tblDivisionList)) {
                $this->IsError = true;
                return new Danger(new Ban().' Klasse nicht gefunden!');
            } elseif (count($tblDivisionList) == 1) {
                $tblDivision = $tblDivisionList[0];
                    Severity: Major
                    Found in Application/Transfer/Untis/Import/LectureshipGateway.php and 1 other location - About 1 hr to fix
                    Application/Transfer/Untis/Import/LectureshipGateway.php on lines 210..220

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        protected function sanitizeSubject($Value)
    {
        if (empty($Value)) {
            return new Warning(new WarningIcon().' Fach wurde nicht angegeben');
        }
                    Severity: Minor
                    Found in Application/Transfer/Untis/Import/LectureshipGateway.php and 1 other location - About 1 hr to fix
                    Application/Transfer/Indiware/Import/LectureshipGateway.php on lines 617..628

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 100.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status